November 2019 - Koha-bugs - lists.koha-community.org

[Bug 24072] New: Typos in advance_notices.pl causes DUEDGST not to be sent
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24072 Bug ID: 24072 Summary: Typos in advance_notices.pl causes DUEDGST not to be sent Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: magnus(a)libriotech.no Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org In misc/cronjobs/advance_notices.pl we have this code: 372 if ($digest_per_branch) { 373 while (my ($branchcode, $digests) = each %$upcoming_digest) { 374 send_digests({ 375 sth => $sth_digest, 376 digests => $digests, 377 letter_code => 'PREDUEDGST', 378 branchcode => $branchcode, 379 get_item_info => sub { 380 my $params = shift; 381 $params->{sth}->execute($params->{borrowernumber}, 382 $params->{borrower_preferences}->{'days_in_advance'}); 383 return sub { 384 $params->{sth}->fetchrow_hashref; 385 }; 386 } 387 }); 388 } 389 390 while (my ($branchcode, $digests) = each %$due_digest) { 391 send_digests({ 392 sth => $sth_digest, 393 digest => $due_digest, ### HERE! 394 letter_code => 'DUEDGST', 395 branchcode => $branchcode, 396 get_item_info => sub { 397 my $params = shift; 398 $params->{sth}->execute($params->{borrowernumber}, 0); 399 return sub { 400 $params->{sth}->fetchrow_hashref; 401 }; 402 } 403 }); 404 } 405 } else { 406 send_digests({ 407 sth => $sth_digest, 408 digests => $upcoming_digest, 409 letter_code => 'PREDUEDGST', 410 get_item_info => sub { 411 my $params = shift; 412 $params->{sth}->execute($params->{borrowernumber}, 413 $params->{borrower_preferences}->{'days_in_advance'}); 414 return sub { 415 $params->{sth}->fetchrow_hashref; 416 }; 417 } 418 }); 419 420 send_digests({ 421 sth => $sth_digest, 422 digest => $due_digest, ### AND HERE! 423 letter_code => 'DUEDGST', 424 get_item_info => sub { 425 my $params = shift; 426 $params->{sth}->execute($params->{borrowernumber}, 0); 427 return sub { 428 $params->{sth}->fetchrow_hashref; 429 }; 430 } 431 }); 432 } A typo has crept in on lines 393 and 422, where "digest" should be written "digests", in the same way as it is done in the other two blocks of code. In send_digests() the incoming data is iterated over in this line: 531 PATRON: while ( my ( $borrowernumber, $digest ) = each %{$params->{digests}} ) { but when the data is actually in $params->{digest} they are not found and no DUEDGST messages are queued. -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 24064] New: DUEDGST typoed as DUEGST
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Bug ID: 24064 Summary: DUEDGST typoed as DUEGST Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: magnus(a)libriotech.no Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org Attachment 86382 of bug introduces a typo in the letter code DUEDGST: - my $letter_type = 'DUEDGST'; + letter_code => 'DUEGST', This causes "Item Due Reminder (Digest)" messages not to be sent. -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 24126] New: Article requests tab appears twice on patron's checkout screen
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 Bug ID: 24126 Summary: Article requests tab appears twice on patron's checkout screen Change sponsored?: Sponsored Product: Koha Version: master Hardware: All URL: http://devs.bywatersolutions.com/projects/claimed-retu rned/ OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: bdaeuber(a)cityoffargo.com, bklein(a)dubuque.lib.ia.us, cbrannon(a)cdalibrary.org, clackman(a)fargolibrary.org, cmartin(a)rcplib.org, cslone(a)camdencountylibrary.org, daniel.gaghan(a)pueblolibrary.org, george(a)nekls.org, gmcharlt(a)gmail.com, horganl(a)middlesex.mass.edu, hughr(a)brimbank.vic.gov.au, joy(a)bywatersolutions.com, jwagner(a)ptfs.com, jzairo(a)bywatersolutions.com, katrin.fischer(a)bsz-bw.de, kelly(a)bywatersolutions.com, kyle.m.hall(a)gmail.com, kyle(a)bywatersolutions.com, lisetteslatah(a)gmail.com, margaret(a)bywatersolutions.com, marjorie.barry-vila(a)collecto.ca, martin.renvoize(a)ptfs-europe.com, niamh.walker-headon(a)it-tallaght.ie, tmisilo(a)gmail.com, tomascohen(a)gmail.com Depends on: 14697 Added by Bug 14697, the "Article requests" tab on the patron checkout screen now appears twice. Presumably a merge error. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 [Bug 14697] Extend and enhance "Claims returned" lost status -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 16688] New: RenewSerialAddsSuggestion - suggestions not showing up, note not saved
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16688 Bug ID: 16688 Summary: RenewSerialAddsSuggestion - suggestions not showing up, note not saved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com When renewing a serial subscription with RenewSerialAddsSuggestion set to active, an entry is added to the suggestions table in Koha. The status is "ASKED" and the biblionumber is column is set to the existing record. But the suggestion isn't shown in the acquisition module - it cannot be found using the search options in suggestions, it doesn't show in the pending tab. Because the status is "ASKED", there is no way to create an order for it. When renewing the subscription, there is a note field you can fill out "for the librarian to process the order" - but this information is not stored in suggestion table and seems to be lost. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 5

[Bug 17160] New: Foreign key constraint for message_transports is too loose
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17160 Bug ID: 17160 Summary: Foreign key constraint for message_transports is too loose Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org I think this is the probable cause for Bug 13171. http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/my… The message transports definition -- -- Table structure for table `message_transports` -- DROP TABLE IF EXISTS `message_transports`; CREATE TABLE `message_transports` ( `message_attribute_id` int(11) NOT NULL, `message_transport_type` varchar(20) NOT NULL, `is_digest` tinyint(1) NOT NULL default '0', `letter_module` varchar(20) NOT NULL default '', `letter_code` varchar(20) NOT NULL default '', `branchcode` varchar(10) NOT NULL default '', PRIMARY KEY (`message_attribute_id`,`message_transport_type`,`is_digest`), KEY `message_transport_type` (`message_transport_type`), KEY `letter_module` (`letter_module`,`letter_code`), CONSTRAINT `message_transports_ibfk_1` FOREIGN KEY (`message_attribute_id`) REFERENCES `message_attributes` (`message_attribute_id`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `message_transports_ibfk_2` FOREIGN KEY (`message_transport_type`) REFERENCES `message_transport_types` (`message_transport_type`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `message_transports_ibfk_3` FOREIGN KEY (`letter_module`, `letter_code`, `branchcode`) REFERENCES `letter` (`module`, `code`, `branchcode`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; Has `message_transport_types` (`message_transport_type`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `message_transports_ibfk_3` FOREIGN KEY (`letter_module`, `letter_code`, `branchcode`) REFERENCES `letter` (`module`, `code`, `branchcode`) ON DELETE CASCADE ON UPDATE CASCADE The foreign key contstraints `module`, `code`, `branchcode` do *NOT* uniquely identify a row in the letter table, because message_transport_type may vary. Therefore, a deletion *any* message transport type will delete *all* rows matching `module`, `code`, `branchcode`. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 7

[Bug 20808] New: I cant install Koha on Ubuntu 18.04 LTS (Bionic Beaver) - Unmet dependences
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20808 Bug ID: 20808 Summary: I cant install Koha on Ubuntu 18.04 LTS (Bionic Beaver) - Unmet dependences Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: paul.messina(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Hello, I am installing Koha on Ubuntu 18.04 LTS Bionic Beaver (Fresh Installation). However, I have experienced the following error when I run "sudo apt-get install koha-common" The following packages have unmet dependencies: koha-common : Depends: libmarc-charset-perl but it is not installable Depends: libmarc-xml-perl but it is not installable E: Unable to correct problems, you have held broken packages. Workaround: sudo apt-get install libmarc-record-perl sudo apt-get install libxml-sax-perl wget http://ftp.br.debian.org/debian/pool/main/libm/libmarc-charset-perl/libmarc… wget http://ftp.br.debian.org/debian/pool/main/libm/libmarc-xml-perl/libmarc-xml… sudo dpkg -i libmarc-charset-perl_1.35-2_amd64.deb libmarc-xml-perl_1.0.3-1_all.deb sudo apt-get install koha-common -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 22907] New: Cannot add new suggestion with strict SQL modes turned on
by bugzilla-daemon＠bugs.koha-community.org 15 Dec '19

15 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Bug ID: 22907 Summary: Cannot add new suggestion with strict SQL modes turned on Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect integer value: '' for column 'copyrightdate' at row 1 at /home/vagrant/kohaclone/C4/Suggestions.pm line 457 -- You are receiving this mail because: You are watching all bug changes.

1 32

[Bug 21685] New: Name our exceptions consistently
by bugzilla-daemon＠bugs.koha-community.org 13 Dec '19

13 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21685 Bug ID: 21685 Summary: Name our exceptions consistently Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Few examples of inconsistencies: * Koha::Exceptions::WrongParameter Koha::Exceptions::BadParameter * Koha::Exceptions::CannotDeleteDefault Koha::Exceptions::Patron::FailedDelete * Koha::Exceptions::Account::IsNotCredit Koha::Exceptions::Password::Invalid => IsNotCredit vs NotCredit => IsNotValid vs Invalid vs NotValid * Koha::Exceptions::DuplicateObject Koha::Exceptions::Object::DuplicateID It would be good a write a guideline and adapt existing occurrences. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 23953] New: Cancelling hold does not work if checkout not completed
by bugzilla-daemon＠bugs.koha-community.org 12 Dec '19

12 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23953 Bug ID: 23953 Summary: Cancelling hold does not work if checkout not completed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To reproduce: 1. Place a hold on item A for patron A 2. Check out item A to patron B 3. See the prompt to confirm the checkout because the hold for patron A exists. Check the 'cancel hold' checkbox and click the 'No, don't check out' button 4. Notice the hold for patron A is NOT cancelled <-- bug 5. Attempt to check out item to patron B again 6. This time, check the 'cancel hold' checkbox but click the 'Yes, check out' button 7. Notice that item A is successfully checked out to patron B and the hold for patron A has been cancelled. Therefore, the 'cancel hold' checkbox does not work if the checkout is not completed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 7

[Bug 23843] New: Make existing endpoints use Koha::Object(s)->to_api
by bugzilla-daemon＠bugs.koha-community.org 12 Dec '19

12 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 Bug ID: 23843 Summary: Make existing endpoints use Koha::Object(s)->to_api Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Now we made the decision to move the to_api logic to the Koha::Object-level, we need to migrate the existing endpoints. This will be done without touching the tests at this stage, to prove no behavior change takes place. Once it is done, a new bug will remove the existing mappings in the API controllers, and adjust the tests accordingly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 71