November 2019 - Koha-bugs - lists.koha-community.org

[Bug 13775] software error when choosing authority via plugin
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '19

07 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775 --- Comment #9 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Wondering if this one is still relevant and whether Katrins information was enough and you wanted to take this forward Jonathan? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13775] software error when choosing authority via plugin
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '19

07 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt(a)gmail.com |jonathan.druart(a)bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13775] software error when choosing authority via plugin
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '19

07 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|critical |major -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15732] New: Remove accountno column from accountlines
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '19

07 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15732 Bug ID: 15732 Summary: Remove accountno column from accountlines Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org How that we have accountlines_id, accountno is superfluous. We should remove it. -- You are receiving this mail because: You are watching all bug changes.

1 5

[Bug 21683] New: Remove accountlines.accountno
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '19

07 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Bug ID: 21683 Summary: Remove accountlines.accountno Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org This database column is obsolete. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 94

[Bug 14963] Ability to suggest purchase on existing catalogue record
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '19

07 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Séverine Queune from comment #6) > (In reply to Jonathan Druart from comment #5) > > (In reply to Séverine Queune from comment #3) > > > Hi Jonathan, > > > > > > I found 2 issues. > > > > > > I have this software error : "Tag "" is not a valid tag. at > > > /var/repositories/koha/C4/Suggestions.pm line 690." when I want to add a > > > suggestion using the empty form (opac & staff client) and saving a > > > suggestion modification on staff client (no problem using the checkbox and > > > drop-down menu). > > > > I do not understand that one. There are 2 bugs opened with this error but no > > idea where the error comes from. Can you detail a bit more? > > Reading the code it seems related to the item type. > > > > (for the record) > > 685 my ($it_tag, $it_subfield) = > > GetMarcFromKohaField('biblioitems.itemtype', ''); > > 686 if ($record->field( $it_tag )) { > > 687 $record->field( $it_tag )->add_subfields( $it_subfield => > > $suggestion->{itemtype} ); > > 688 } > > 689 else { > > 690 $record->append_fields( > > 691 MARC::Field->new($it_tag, ' ', ' ', $it_subfield => > > $suggestion->{itemtype}) > > 692 ); > > 693 } > > Oh... Weird... In my instance, there is no field mapped to > biblioitems.itemtype, but if I add one, I can save the suggestion correctly. > Is it the expected / future behaviour ? > This a problem we don't have with 18.05.00 so we'll have to be be aware > about adding a mapping for biblioitems.itemtype if so. I am not sure, but the code that is exploding comes from bug 14973 (so not pushed yet). Do you know why you do not have this mapping? Discussion should continue on bug 14973 if needed. > My second try was an on different computer with a different resolution > screen, I noticed a tiny display issu with the new link in OPAC (see > attachement). Sorry I missed that on first test. Fixed. You will need to regenerate the CSS file to see the changes: yarn build --view opac -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14963] Ability to suggest purchase on existing catalogue record
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '19

07 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #8 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 95175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95175&action=ed… Bug 14963: Fix ergonomic issue on small screen -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14963] Ability to suggest purchase on existing catalogue record
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '19

07 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #7 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 95174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95174&action=ed… Tiny gap before the new "Suggestion" link -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14963] Ability to suggest purchase on existing catalogue record
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '19

07 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #6 from Séverine Queune <severine.queune(a)bulac.fr> --- (In reply to Jonathan Druart from comment #5) > (In reply to Séverine Queune from comment #3) > > Hi Jonathan, > > > > I found 2 issues. > > > > I have this software error : "Tag "" is not a valid tag. at > > /var/repositories/koha/C4/Suggestions.pm line 690." when I want to add a > > suggestion using the empty form (opac & staff client) and saving a > > suggestion modification on staff client (no problem using the checkbox and > > drop-down menu). > > I do not understand that one. There are 2 bugs opened with this error but no > idea where the error comes from. Can you detail a bit more? > Reading the code it seems related to the item type. > > (for the record) > 685 my ($it_tag, $it_subfield) = > GetMarcFromKohaField('biblioitems.itemtype', ''); > 686 if ($record->field( $it_tag )) { > 687 $record->field( $it_tag )->add_subfields( $it_subfield => > $suggestion->{itemtype} ); > 688 } > 689 else { > 690 $record->append_fields( > 691 MARC::Field->new($it_tag, ' ', ' ', $it_subfield => > $suggestion->{itemtype}) > 692 ); > 693 } Oh... Weird... In my instance, there is no field mapped to biblioitems.itemtype, but if I add one, I can save the suggestion correctly. Is it the expected / future behaviour ? This a problem we don't have with 18.05.00 so we'll have to be be aware about adding a mapping for biblioitems.itemtype if so. My second try was an on different computer with a different resolution screen, I noticed a tiny display issu with the new link in OPAC (see attachement). Sorry I missed that on first test. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14963] Ability to suggest purchase on existing catalogue record
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '19

07 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #5 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Séverine Queune from comment #3) > Hi Jonathan, > > I found 2 issues. > > I have this software error : "Tag "" is not a valid tag. at > /var/repositories/koha/C4/Suggestions.pm line 690." when I want to add a > suggestion using the empty form (opac & staff client) and saving a > suggestion modification on staff client (no problem using the checkbox and > drop-down menu). I do not understand that one. There are 2 bugs opened with this error but no idea where the error comes from. Can you detail a bit more? Reading the code it seems related to the item type. (for the record) 685 my ($it_tag, $it_subfield) = GetMarcFromKohaField('biblioitems.itemtype', ''); 686 if ($record->field( $it_tag )) { 687 $record->field( $it_tag )->add_subfields( $it_subfield => $suggestion->{itemtype} ); 688 } 689 else { 690 $record->append_fields( 691 MARC::Field->new($it_tag, ' ', ' ', $it_subfield => $suggestion->{itemtype}) 692 ); 693 } > For suggestions made from an existing notice, suggestion status is not > update after the adding to a basket (no problem for suggestions made from > the empty form, and for the "Available" status after the receipt). Fixed! > Except these point, everything seems very clear to me and respond to our > needs, so thanks a lot ! > Icon on opac is ok for me. Thanks! -- You are receiving this mail because: You are watching all bug changes.

1 0