November 2019 - Koha-bugs - lists.koha-community.org

[Bug 14963] Ability to suggest purchase on existing catalogue record
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '19

07 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #8 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 95175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95175&action=ed… Bug 14963: Fix ergonomic issue on small screen -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14963] Ability to suggest purchase on existing catalogue record
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '19

07 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #7 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 95174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95174&action=ed… Tiny gap before the new "Suggestion" link -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14963] Ability to suggest purchase on existing catalogue record
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '19

07 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #6 from Séverine Queune <severine.queune(a)bulac.fr> --- (In reply to Jonathan Druart from comment #5) > (In reply to Séverine Queune from comment #3) > > Hi Jonathan, > > > > I found 2 issues. > > > > I have this software error : "Tag "" is not a valid tag. at > > /var/repositories/koha/C4/Suggestions.pm line 690." when I want to add a > > suggestion using the empty form (opac & staff client) and saving a > > suggestion modification on staff client (no problem using the checkbox and > > drop-down menu). > > I do not understand that one. There are 2 bugs opened with this error but no > idea where the error comes from. Can you detail a bit more? > Reading the code it seems related to the item type. > > (for the record) > 685 my ($it_tag, $it_subfield) = > GetMarcFromKohaField('biblioitems.itemtype', ''); > 686 if ($record->field( $it_tag )) { > 687 $record->field( $it_tag )->add_subfields( $it_subfield => > $suggestion->{itemtype} ); > 688 } > 689 else { > 690 $record->append_fields( > 691 MARC::Field->new($it_tag, ' ', ' ', $it_subfield => > $suggestion->{itemtype}) > 692 ); > 693 } Oh... Weird... In my instance, there is no field mapped to biblioitems.itemtype, but if I add one, I can save the suggestion correctly. Is it the expected / future behaviour ? This a problem we don't have with 18.05.00 so we'll have to be be aware about adding a mapping for biblioitems.itemtype if so. My second try was an on different computer with a different resolution screen, I noticed a tiny display issu with the new link in OPAC (see attachement). Sorry I missed that on first test. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14963] Ability to suggest purchase on existing catalogue record
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '19

07 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #5 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Séverine Queune from comment #3) > Hi Jonathan, > > I found 2 issues. > > I have this software error : "Tag "" is not a valid tag. at > /var/repositories/koha/C4/Suggestions.pm line 690." when I want to add a > suggestion using the empty form (opac & staff client) and saving a > suggestion modification on staff client (no problem using the checkbox and > drop-down menu). I do not understand that one. There are 2 bugs opened with this error but no idea where the error comes from. Can you detail a bit more? Reading the code it seems related to the item type. (for the record) 685 my ($it_tag, $it_subfield) = GetMarcFromKohaField('biblioitems.itemtype', ''); 686 if ($record->field( $it_tag )) { 687 $record->field( $it_tag )->add_subfields( $it_subfield => $suggestion->{itemtype} ); 688 } 689 else { 690 $record->append_fields( 691 MARC::Field->new($it_tag, ' ', ' ', $it_subfield => $suggestion->{itemtype}) 692 ); 693 } > For suggestions made from an existing notice, suggestion status is not > update after the adding to a basket (no problem for suggestions made from > the empty form, and for the "Available" status after the receipt). Fixed! > Except these point, everything seems very clear to me and respond to our > needs, so thanks a lot ! > Icon on opac is ok for me. Thanks! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14963] Ability to suggest purchase on existing catalogue record
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '19

07 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #4 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 95173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95173&action=ed… Bug 14963: Set status=ORDERED for suggestions created from existing record -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14963] Ability to suggest purchase on existing catalogue record
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '19

07 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Séverine Queune <severine.queune(a)bulac.fr> --- Hi Jonathan, I found 2 issues. I have this software error : "Tag "" is not a valid tag. at /var/repositories/koha/C4/Suggestions.pm line 690." when I want to add a suggestion using the empty form (opac & staff client) and saving a suggestion modification on staff client (no problem using the checkbox and drop-down menu). For suggestions made from an existing notice, suggestion status is not update after the adding to a basket (no problem for suggestions made from the empty form, and for the "Available" status after the receipt). Except these point, everything seems very clear to me and respond to our needs, so thanks a lot ! Icon on opac is ok for me. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '19

07 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15449] Move stuffs to the Koha namespace
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '19

07 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23990 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 [Bug 23990] Move C4::Suggestions code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15449] Move stuffs to the Koha namespace
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '19

07 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23990 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 [Bug 23990] Move C4::Suggestions code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15449] Move stuffs to the Koha namespace
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '19

07 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23990 --- Comment #24 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Bug 23990 - Move C4::Suggestions code to the Koha namespace Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 [Bug 23990] Move C4::Suggestions code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.

1 0