December 2019 - Koha-bugs - lists.koha-community.org

[Bug 21010] New: Add a script to search for data inconsistencies
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21010 Bug ID: 21010 Summary: Add a script to search for data inconsistencies Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 23871] New: data inconsistencies - check title exists
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23871 Bug ID: 23871 Summary: data inconsistencies - check title exists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz In biblio records, a field must be linked to biblio.title. 200$a in UNIMARC, 100$a MARC21 (and other). If this field is undefined, some pages like checkouts table can fail. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15

[Bug 23084] New: Replace grep {^$var$} with grep {$var eq $_}
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Bug ID: 23084 Summary: Replace grep {^$var$} with grep {$var eq $_} Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- See bug 23006 and bug 22941. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 39

[Bug 17268] New: Advanced cataloging editor - rancor - macros are lost when browser storage cleared
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Bug ID: 17268 Summary: Advanced cataloging editor - rancor - macros are lost when browser storage cleared Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt(a)gmail.com Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl In development macros were stored in the browser to allow different users to have their own. Unfortunately this means macros are lost when browser storage is cleared. Should have a more robust method for retaining these. -- You are receiving this mail because: You are watching all bug changes.

1 129

[Bug 24185] New: 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Bug ID: 24185 Summary: 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: nugged(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl When "reserve/request.pl -> C4/Reserves.pm::IsAvailableForItemLevelRequest" called many times with hundred of items and "on shelf holds" parameter set to "If all unavailable" for these items+patron, it goes very slow. This happens because in subloop there are re-checking if all other item unavailable so it is O(n^2) and it re-checks each time a lot of the same info for each item with repeating DB/data requests, these three: - GetBranchItemRule (per item type) - IsItemOnHoldAndFound (per item) - notforloan (per item) Proposed fix: I created patch to have in-variable cache in upper-level subroutine before entering the first "items" loop and passing that hash reference down into subs to cache these three values by keys per-item and per-item-type. It is simplest way to make it fast without re-thinking pretty complicated whole algorithm and business logic, and, when tested by speed it gave big improvement in execution time. How to reproduce: 1) on fresh installed kohadevbox create/import one book, record that biblionumber for later use it in down below, 2) add 100 items for that book for some library, 3) find some patron, that patron's card number we will use as a borrower down below to open holds page, 4) check for the rule or set up single circulation rule in admin "/cgi-bin/koha/admin/smart-rules.pl", so that rule will match above book items/libary/patron, check that rule to have non-zero number of holds (total, daily, count) allowed, and, IMPORTANT: set up "On shelf holds allowed" to "If all unavailable", ("item level holds" doesn't matter). 5) open "Home > Catalog > THAT_BOOK > Place a hold on THAT_BOOK" page ("holds" tab), and enter patron code in the search field, or you can create direct link by yourself, for example in my case it was: /cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=23529000686353 6) it should be pretty long page generation time. I tested on my computer in VirtualBox for this page generation times, (stats below is for many runs and smallest value taken from similar in a repetition), last one block eith times with that in-var-cache solution I am proposing: "On shelf holds allowed" != "If all unavailable": for 100 items: 5 seconds, for 200 items: 10 seconds, for 300 items: 11 seconds, "On shelf holds allowed" == "If all unavailable": for 100 items: 50 seconds, for 200 items: 3.1 minutes, for 300 items: 7.0 minutes, "On shelf holds allowed" == "If all unavailable" with cache: for 100 items: 7 seconds, for 200 items: 20 seconds, for 300 items: 38 seconds, -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 55

[Bug 23173] New: ILL should be able to search third party sources prior to request creation
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 Bug ID: 23173 Summary: ILL should be able to search third party sources prior to request creation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com Target Milestone: --- Currently, there is no integrated way of knowing if an item being requested is already available. If a user creating a request wants to know if the item they are requesting is already available, it is necessary to search the, possibly, multiple sources the library has available (catalogue, discovery interface, open access provider etc.) first. The problem is further compounded if the institution has the unmediated ILL workflow enabled where a request can be placed with no oversight, even though the institution may already have access to it. I propose a mechanism by which, during request creation, one or more "sources" are searched with the provided metadata to try and determine if the item being requested is already available and, if so, links to that item are provided. This behaviour will be optional, via a syspref. "Sources" will be provided as Koha plugins and will provide the ability to accept metadata conforming to the established ILL schema, search the source with which they're concerned, and return results in a prescribed format. This will be performed via an API common to all "source" plugins. All plugins performing this task will be in a common plugin category and therefore enumerable. The workflow for two backends: Freeform: - User fills in Freeform form, clicks submit button - User is taken to an "Availability" page - ILL enumerates source plugins that can service this type of request (mostly determined by material type) and makes search requests to each using provided metadata - Displays results from each source, with links to matching items - User can then either choose a result and be taken to it, or choose none and continue with the request as normal BLDSS: - Identical to above except the user will choose a BLDSS result rather than filling in the Freeform form As part of this work, a source plugin, which will serve as a reference, will be provided. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 75

[Bug 21443] New: Add ability to exclude holidays when calculating rentals fees by time period
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443 Bug ID: 21443 Summary: Add ability to exclude holidays when calculating rentals fees by time period Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org It would be a nice addition if we could have the option to not count holidays when creating time period based rental fees. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 49

[Bug 23185] New: Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 Bug ID: 23185 Summary: Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P1 - high Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: dcook(a)prosentient.com.au, jonathan.druart(a)bugs.koha-community.org, koha-bugs(a)lists.koha-community.org, kyle(a)bywatersolutions.com, m.de.rooy(a)rijksmuseum.nl, martin.renvoize(a)ptfs-europe.com, testopia(a)bugs.koha-community.org, tomascohen(a)gmail.com Depends on: 21761 Target Milestone: --- +++ This bug was initially created as a clone of Bug #21761 +++ If we're adding triggers at the code level all over the place by overloading the store method we need to never ever let dbic handle it.. by allowing the 'update' method through we are exposing ourselves to places in the codebase skipping the store triggers. This would in effect bind us to the 'update_all' style of update call from dbic, which results in a loop over the affected rows so that in code triggers can be called per row rather than allowing any form of 'update all these rows to X' in one query. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug.

1 70

[Bug 22774] New: Limit Purchase Suggestion in a specified Time period
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Bug ID: 22774 Summary: Limit Purchase Suggestion in a specified Time period Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: joy(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Many libraries would like the ability to limit purchase suggestions made by a patron to a certain number over a specified period. i.e. 3 suggestions every 30 days. The MaxOpenSuggestions works to limit 'open' suggestions, but does not take into account the total suggestions made by patrons. We need the ability to limit the number of suggestions a patron can make in a "rolling number of weeks" (over last X weeks). The variables for this would be the number of suggestions and the number of rolling weeks. Suggested system preference "MaxTotalSuggestions" with two variables. First is the number of total suggestions and the second is the number of days. e.g. MaxTotalSuggestion Allow 3 total suggestions over 30 days. (user configures the numbers to suit their policy) Result: Users are prevented from making any suggestions if the total suggestions (pending/checked/accepted/rejected) they've made over the last X days is equal to the max specified. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 56

[Bug 22887] New: authorised_values is missing a unique constraint on category + authorised_value
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Bug ID: 22887 Summary: authorised_values is missing a unique constraint on category + authorised_value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Code using the authorised_values table expects the combination of 'category' with 'authorised_value' to always be unique. We should constrain it as such and also reap the rewards of dbic accessors that would give us. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 61