December 2019 - Koha-bugs - lists.koha-community.org

[Bug 20567] New: "Holds per record (count)" limit is not enforced after item is captured for hold
by bugzilla-daemon＠bugs.koha-community.org 21 May '20

21 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Bug ID: 20567 Summary: "Holds per record (count)" limit is not enforced after item is captured for hold Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: margaret(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Created attachment 74042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74042&action=ed… Multiple holds on one item record in staff client "Holds per record (count)" limit is not enforced after an item on the record is captured for hold and moves from Pending to Waiting Pickup status. At this point it is possible to place another hold on that record in violation of the "Holds per record (count)" setting. I was able to replicate this behavior with the following steps: 1. Set "Holds per record (count)" to 1 for your patron category/item type rule 2. Create a record and add at least two items, making sure the MARC and Item Koha Item Type is filled in 3. Place a hold on the record for a patron 4. Check in one of the items and confirm/transfer/capture the hold for the patron 5. Place a second hold on the same record for the same patron In either Staff or Opac the second hold on this bib is allowed after the first hold moves to Waiting for Pickup status. I think that this problem is very closely related to bugzilla 17978 and or 15404, but I did not see a specific mention of the "Holds per record (count)" limit upon perusal of those bugs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 31

[Bug 22917] New: Circulation.t fails if tests are ran slowly
by bugzilla-daemon＠bugs.koha-community.org 21 May '20

21 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22917 Bug ID: 22917 Summary: Circulation.t fails if tests are ran slowly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- After bug 21213 we wanted to know why Circulation.t was failing randomly on a given test. Since it is pushed, it failed (at least) twice, with the same error: # Failed test 'AddReturn must have debarred the patron' # at t/db_dependent/Circulation.t line 3112. # got: '' # expected: '1' # AddReturn returned message $VAR1 = { # 'WasReturned' => 1 # }; # Failed test 'Test at line 1918' # at t/db_dependent/Circulation.t line 3116. # got: '0' # expected: '1' # Failed test 'Test at line 1918' # at t/db_dependent/Circulation.t line 3119. # got: undef # expected: '2019-05-30' # Looks like you failed 3 tests of 21. The test at line 3113 expects the flags 'WasReturned' and 'Debarred' to be set, but only WasReturned is. Which means the patron has not been debarred. It is not because the checkout has not been detected as overdue. -- You are receiving this mail because: You are watching all bug changes.

1 27

[Bug 23234] New: Circulation.t failing on June 28th 2019
by bugzilla-daemon＠bugs.koha-community.org 21 May '20

21 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23234 Bug ID: 23234 Summary: Circulation.t failing on June 28th 2019 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Not sure what is behind this. kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ date Fri Jun 28 13:02:16 -05 2019 kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Circulation.t # Failed test 'Cannot auto renew, too late - no_auto_renewal_after is inclusive(returned code is auto_too_late)' # at t/db_dependent/Circulation.t line 691. # got: 'auto_too_soon' # expected: 'auto_too_late' # Looks like you failed 1 test of 14. # Failed test 'too_late_renewal / no_auto_renewal_after' # at t/db_dependent/Circulation.t line 722. # Failed test 'GetLatestAutoRenewDate should return -5 days if no_auto_renewal_after = 5 and date_due is 10 days before' # at t/db_dependent/Circulation.t line 862. # got: '2019-06-23T18:01:00' # expected: '2019-06-23T18:01:00' # Failed test 'GetLatestAutoRenewDate should return +5 days if no_auto_renewal_after = 15 and date_due is 10 days before' # at t/db_dependent/Circulation.t line 869. # got: '2019-07-03T18:01:00' # expected: '2019-07-03T18:01:00' # Failed test 'GetLatestAutoRenewDate should return +2 days if no_auto_renewal_after_hard_limit is defined and not no_auto_renewal_after' # at t/db_dependent/Circulation.t line 876. # got: '2019-06-30T00:00:00' # expected: '2019-06-30T00:00:00' # Failed test 'GetLatestAutoRenewDate should return +2 days if no_auto_renewal_after_hard_limit is < no_auto_renewal_after' # at t/db_dependent/Circulation.t line 882. # got: '2019-06-30T00:00:00' # expected: '2019-06-30T00:00:00' # Looks like you failed 4 tests of 5. # Failed test 'GetLatestAutoRenewDate' # at t/db_dependent/Circulation.t line 887. # Looks like you failed 2 tests of 71. # Failed test 'CanBookBeRenewed tests' # at t/db_dependent/Circulation.t line 998. # Failed test 'AddReturn must have debarred the patron' # at t/db_dependent/Circulation.t line 86. # got: '' # expected: '1' # AddReturn returned message $VAR1 = { # 'WasReturned' => 1 # }; # Failed test 'Test at line 1967' # at t/db_dependent/Circulation.t line 90. # got: '0' # expected: '1' # Failed test 'Test at line 1967' # at t/db_dependent/Circulation.t line 93. # got: undef # expected: '2019-07-12' # Looks like you failed 3 tests of 21. # Failed test 'AddReturn + suspension_chargeperiod' # at t/db_dependent/Circulation.t line 1976. # Looks like you failed 2 tests of 45. t/db_dependent/Circulation.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/45 subtests Test Summary Report ------------------- t/db_dependent/Circulation.t (Wstat: 512 Tests: 45 Failed: 2) Failed tests: 15, 29 Non-zero exit status: 2 Files=1, Tests=45, 27 wallclock secs ( 0.08 usr 0.01 sys + 19.81 cusr 4.37 csys = 24.27 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 20250] New: NoIssuesChargeGuarantees.t is still failing randomly
by bugzilla-daemon＠bugs.koha-community.org 20 May '20

20 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20250 Bug ID: 20250 Summary: NoIssuesChargeGuarantees.t is still failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 19529 patron_category is not a patron's attribute, it's categorycode! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19529 [Bug 19529] NoIssuesChargeGuarantees.t is failing randomly -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 20503] New: Borrower_PrevCheckout.t is failing randomly
by bugzilla-daemon＠bugs.koha-community.org 20 May '20

20 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20503 Bug ID: 20503 Summary: Borrower_PrevCheckout.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org AddIssue returns too soon if category_type="X" koha_1 | # Failed test 'patron, wants_check_for_previous_checkout, do_check_for_previous_checkout' koha_1 | # at t/db_dependent/Patron/Borrower_PrevCheckout.t line 443. koha_1 | # got: undef koha_1 | # expected: '1' koha_1 | # Looks like you failed 1 test of 59. koha_1 | [14:50:28] t/db_dependent/Patron/Borrower_PrevCheckout.t .................. koha_1 | Dubious, test returned 1 (wstat 256, 0x100) koha_1 | Failed 1/59 subtests https://jenkins.koha-community.org/job/Koha_Master_D8/415/console -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 20191] New: OAI/Server.t still fails on slow servers
by bugzilla-daemon＠bugs.koha-community.org 20 May '20

20 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 Bug ID: 20191 Summary: OAI/Server.t still fails on slow servers Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 18794 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18794 [Bug 18794] OAI/Server.t fails on slow servers -- You are receiving this mail because: You are watching all bug changes.

1 31

[Bug 20531] New: IssueSlip is failing randomly
by bugzilla-daemon＠bugs.koha-community.org 20 May '20

20 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20531 Bug ID: 20531 Summary: IssueSlip is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org There is sort on timestamp, issuedate, issue_id in Koha::Patron->pending_checkouts (previously GetPendingIssues) If at least 1 sec passed between 2 inserts, the tests will fail: https://jenkins.koha-community.org/job/Koha_Master_D8/422/console koha_1 | # Failed test 'IssueSlip should return a slip with 2 checkouts' koha_1 | # at t/db_dependent/Members/IssueSlip.t line 243. koha_1 | # got: 'Checked out: koha_1 | # koha_1 | # Title: My title 2 koha_1 | # Barcode: BC0202 koha_1 | # Date due: 04/05/2018 19:59 koha_1 | # koha_1 | # koha_1 | # Title: My title 1 koha_1 | # Barcode: BC0101 koha_1 | # Date due: 04/05/2018 19:59 koha_1 | # koha_1 | # koha_1 | # Overdues: koha_1 | # koha_1 | # ' koha_1 | # expected: 'Checked out: koha_1 | # koha_1 | # Title: My title 1 koha_1 | # Barcode: BC0101 koha_1 | # Date due: 04/05/2018 19:59 koha_1 | # koha_1 | # koha_1 | # Title: My title 2 koha_1 | # Barcode: BC0202 koha_1 | # Date due: 04/05/2018 19:59 koha_1 | # koha_1 | # koha_1 | # Overdues: koha_1 | # koha_1 | # ' koha_1 | # Looks like you failed 1 test of 2. koha_1 | koha_1 | # Failed test 'Hourly loans' koha_1 | # at t/db_dependent/Members/IssueSlip.t line 278. koha_1 | # Looks like you failed 1 test of 3. koha_1 | koha_1 | # Failed test 'Issue slip' koha_1 | # at t/db_dependent/Members/IssueSlip.t line 280. koha_1 | # Looks like you failed 1 test of 3. koha_1 | [18:15:19] t/db_dependent/Members/IssueSlip.t ............................. -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 17713] New: Members.t is failing randomly
by bugzilla-daemon＠bugs.koha-community.org 20 May '20

20 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17713 Bug ID: 17713 Summary: Members.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 16276 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 17733] New: Members.t is still failing randomly
by bugzilla-daemon＠bugs.koha-community.org 20 May '20

20 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Bug ID: 17733 Summary: Members.t is still failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 17713 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17713 [Bug 17713] Members.t is failing randomly -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 20557] New: Koha/Acquisition/Order.t is failing randomly
by bugzilla-daemon＠bugs.koha-community.org 20 May '20

20 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20557 Bug ID: 20557 Summary: Koha/Acquisition/Order.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org https://jenkins.koha-community.org/job/Koha_Master_D8/427/consoleFull t/db_dependent/Koha/Acquisition/Order.t .. 1/2 # No tests run! # Failed test 'No tests run for subtest "entrydate"' # at t/db_dependent/Koha/Acquisition/Order.t line 97. # Looks like you failed 1 test of 1. # Failed test 'store' # at t/db_dependent/Koha/Acquisition/Order.t line 99. Cannot insert order: Mandatory parameter quantity is missing at t/db_dependent/Koha/Acquisition/Order.t line 77. # Looks like your test exited with 255 just after 2. It happens when basket.is_standing is 0 -- You are receiving this mail because: You are watching all bug changes.

1 8