December 2019 - Koha-bugs - lists.koha-community.org

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '19

26 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #89 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- (In reply to Jonathan Druart from comment #88) > 1. Who is the original author of this patch? Bernardo? Regarding the history > I do not think so. I just signed, ~2015 first time, and now. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '19

26 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #88 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I am quite ok with this patch, just a couple of things: 1. Who is the original author of this patch? Bernardo? Regarding the history I do not think so. 2. Not blocker but, when a code is not nice, better refactore and improve it than duplicate it ;) I am referring to the JS code to test if a mandatory field is filled, it would have been easier to make the function accepts an argument to check for mandatories or importants. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '19

26 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #87 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #86) > Does not work for me: > > Can't use an undefined value as an ARRAY reference at > /usr/lib/x86_64-linux-gnu/perl5/5.24/DBI.pm line 2088 > DBD::_::st::fetchall_arrayref('DBI::st=HASH(0x5570f6dbc278)', > 'HASH(0x5570f6dbc440)', undef) called at > /kohadevbox/koha/admin/marctagstructure.pl line 330 > > CGI::Compile::ROOT::kohadevbox_koha_admin_marctagstructure_2epl:: > StringSearch(0, 'ACQ') called at /kohadevbox/koha/admin/marctagstructure.pl > line 284 > eval {...} at /kohadevbox/koha/admin/marctagstructure.pl line 349 Sorry, I forgot the new DB column! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '19

26 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #86 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Does not work for me: Can't use an undefined value as an ARRAY reference at /usr/lib/x86_64-linux-gnu/perl5/5.24/DBI.pm line 2088 DBD::_::st::fetchall_arrayref('DBI::st=HASH(0x5570f6dbc278)', 'HASH(0x5570f6dbc440)', undef) called at /kohadevbox/koha/admin/marctagstructure.pl line 330 CGI::Compile::ROOT::kohadevbox_koha_admin_marctagstructure_2epl::StringSearch(0, 'ACQ') called at /kohadevbox/koha/admin/marctagstructure.pl line 284 eval {...} at /kohadevbox/koha/admin/marctagstructure.pl line 349 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 25 Dec '19

25 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96625|0 |1 is obsolete| | --- Comment #85 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 96627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96627&action=ed… Bug 8643: Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: 1) Apply the patch 2) Run updatedatabase.pl 3) Regenerate CSS 4) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 5) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 6) Edit a record to clear the field 100 (subfields are all blank) 7) Save the record. 8) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? Sponsored by the CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Tested on update and new install, works as described. No errors. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 25 Dec '19

25 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 24 Dec '19

24 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Arthur Bousquet <arthur.bousquet(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92384|0 |1 is obsolete| | --- Comment #84 from Arthur Bousquet <arthur.bousquet(a)inlibro.com> --- Created attachment 96625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96625&action=ed… Bug 8643: Add important constraint to marc subfields I modified the MarcSubfieldStructure.pm file to match the new database shema (with the "important" column) This fix permits to add an "Important" option to the marc structure pages. Testing: 1) Apply the patch 2) Run updatedatabase.pl 3) Regenerate CSS 4) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 5) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 6) Edit a record to clear the field 100 (subfields are all blank) 7) Save the record. 8) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? Sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
by bugzilla-daemon＠bugs.koha-community.org 24 Dec '19

24 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 --- Comment #36 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- > Tests are missing anyhow This is a very important code, if anyone is willing to provide tests, you are welcome :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9156] System preference itemcallnumber not pulling more than 2 subfields
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '19

23 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #13 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #11) > After Nick's change, this is misbehaving slightly, not getting the right > order in the item record. > > My syspref says: 082abmqA > > My bib says: > 082 $a a > $b b > $m m > $q q > $A A > > The item call number generates as: a A b m q I cannot recreate this - the code for MARC::Field->as_string should preserve the order in the record. Can you share your sample record? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24243] New: Bad characters in AMRC cause internal server error when searching catalog
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '19

23 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Bug ID: 24243 Summary: Bad characters in AMRC cause internal server error when searching catalog Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Koha::Biblio::Metadata::record can throw an exception, it must always be caught If CoinsInOpac is enabled we call 'get_coins' on the search results - get_coins calls for the record. On the staff details page this exception is handled but not in opac results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20