December 2019 - Koha-bugs - lists.koha-community.org

[Bug 24311] New: aqbasket.booksellerinvoicenumber is not used and should be removed
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '19

26 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24311 Bug ID: 24311 Summary: aqbasket.booksellerinvoicenumber is not used and should be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org This field used to contain the invoice information. But it was moved to a separate table (aqinvoices) and the remainding occurrences in the codebase seem to translate it from the templates into a query on aqinvoices. i.e.: C4::Acquisitions:2464 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 24280] New: Claims Returned items give erroneous refund message on return
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '19

26 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24280 Bug ID: 24280 Summary: Claims Returned items give erroneous refund message on return Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To test: - Configure claims returned per bug 14697 - set Default lost item fee refund on return policy to Yes - Check an item out to a patron - Set to claims returned without charging a fee - Check item in - Koha gives a message that a refund was applied to the patron account, but no refund was generated as there was no lost fee -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '19

26 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #90 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #89) > (In reply to Jonathan Druart from comment #88) > > 1. Who is the original author of this patch? Bernardo? Regarding the history > > I do not think so. > I just signed, ~2015 first time, and now. All these people, from InLibro, seems to have worked on this bug Maxime Pelletier simith.doliveira@inlibro Rémi Mayrand-Provencher Mehdi Hamidi Philippe Audet-Fortin Charles Farmer Pierre-Marc Thibault Maryse Simard Arthur Bousquet -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7882] Add ability to move and reorder fields in MARC editor
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '19

26 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #64 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 96635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96635&action=ed… Bug 7882: (follow-up) Only show sortable icon for sortable tags Only tags which can be repeated can be sorted, so the "bars" icon should not display by these tags. Signed-off-by: Maryse Simard <maryse.simard(a)inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7882] Add ability to move and reorder fields in MARC editor
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '19

26 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #63 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 96634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96634&action=ed… Bug 7882: (follow-up) Update sorting interaction This follow-up modifies the CSS for the sortable fields so that a different icon is used. Elsewhere in Koha (stock rotation stage sorting) we use the "bars" icon to indicate a sortable element. I think it would be good to continue to use this. The cursor is now styled as a "Move" cursor. The configuration of the sortable function in the script has been updated in two ways: 1. The movement of the element is constrained along the y-axis, and 2. The movement of the element is contstrained to the container within which it can be moved (for the tag, the tab, and for the subfield, the tag). To test, apply the patch and edit a MARC record in the basic cataloging editor. Confirm that the new icon is used, and that the "Move" cursor shows when you hover over the icon. Confirm that a tag can be dragged up and down within the constraints of the visible section. A subfield should be only movable within its parent tag. Signed-off-by: Maryse Simard <maryse.simard(a)inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7882] Add ability to move and reorder fields in MARC editor
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '19

26 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96344|0 |1 is obsolete| | Attachment #96541|0 |1 is obsolete| | Attachment #96542|0 |1 is obsolete| | --- Comment #62 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 96633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96633&action=ed… Bug 7882: Add ability to move and reorder fields in MARC editor Use jQueryUI sortable to make fields and subfields moveable in the MARC editor for both records and authorities. This patch convert items from div's to ul's and consequently alter css and js to match. It also replace the up arrow with a more adapted icon (from font awesome). Primary authorship by Elliott Davis. To Test: 1. Add or edit a record in cataloguing module. 2. You should be able to move the fields and subfields around. - You can click on any part of the element to drag it, the move icon to the left of the item is a good place to do it. => You can only change the order of fields of the same tag. 3. Make sure all of the javascript driven fonctionnality still work : - Duplicate fields/subfields - Remove fields/subfields - Using the tag editor for control fields or to link authorities - etc 4. Reorder some fields/subfields and save the record. 5. Edit the record again. 6. The order in the editor should match the changes which were saved. - Empty subfields should appear after the ones with content. 7. Repeat steps 1-6 with the authority editor. Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5334] Omnibus: Add explicit foreign key constraints
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '19

26 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24289 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289 [Bug 24289] Deleting branch will not delete entry in special holidays -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 19233] New: Add ability to send itemnumbers in report results to batch modification
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '19

26 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Bug ID: 19233 Summary: Add ability to send itemnumbers in report results to batch modification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: nick(a)bywatersolutions.com Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 37

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '19

26 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #89 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- (In reply to Jonathan Druart from comment #88) > 1. Who is the original author of this patch? Bernardo? Regarding the history > I do not think so. I just signed, ~2015 first time, and now. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '19

26 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #88 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I am quite ok with this patch, just a couple of things: 1. Who is the original author of this patch? Bernardo? Regarding the history I do not think so. 2. Not blocker but, when a code is not nice, better refactore and improve it than duplicate it ;) I am referring to the JS code to test if a mandatory field is filled, it would have been easier to make the function accepts an argument to check for mandatories or importants. -- You are receiving this mail because: You are watching all bug changes.

1 0