December 2019 - Koha-bugs - lists.koha-community.org

[Bug 13897] Use XML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 17 Dec '19

17 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #13 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Cook from comment #12) > We could use YAML as a declarative format for the database data, and then > the Release Manager/Release Maintainer could run a tool to compile it into a > SQL script. > This could also be used to add support for different databases, especially in terms of optimizing bulk data loading. https://dev.mysql.com/doc/refman/5.6/en/optimizing-innodb-bulk-data-loading… https://www.postgresql.org/docs/9.1/ecpg-sql-set-autocommit.html -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use XML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 17 Dec '19

17 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #12 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Bernardo Gonzalez Kriegel from comment #11) > Do you think the sequence > a) Read YAML > Write $tmp/out.sql > > DBIx_::RunSQL->run_sql_file($tmp/out.sql) > is a valid approach, or > b) Read YAML > Insert into DB somehow > it's better? > I suppose b) is slower. > Since this is installer data, I don't think it necessarily has to be fast? I figure the most important part is to make it easy to read and update? Actually, I don't know if we necessarily need to change C4/Installer.pm? We could use YAML as a declarative format for the database data, and then the Release Manager/Release Maintainer could run a tool to compile it into a SQL script. If we only do that compilation at release time, it would also be easier to audit and find bugs in the final result. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13749] On loading holds in patron account 'processing' is not translatable
by bugzilla-daemon＠bugs.koha-community.org 17 Dec '19

17 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13749 Hayley Mapley <hayleymapley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00, 18.11.12 released in| | CC| |hayleymapley(a)catalyst.net.n | |z Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #10 from Hayley Mapley <hayleymapley(a)catalyst.net.nz> --- Backported 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14419] Expanding facets (Show more) performs a new search
by bugzilla-daemon＠bugs.koha-community.org 17 Dec '19

17 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419 --- Comment #18 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 96355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96355&action=ed… Bug 14419: [19.05.x] (squashed) Expanding facets (Show more) performs a new search This patch removes the constraint of only passing 5 facets to the template unless the list is expanded, in fact, it removes the 'expanded' attribute from Search.pm Now that all facets are passed to page it adds a 'show more' link at the bottom of lists and allows user to expand or collapse any facet set without reloading page. Updated tests included. To test: 1 - Perform an OPAC search that returns more than 5 of any given facet type 2 - Click the "Show more" link on the facets and see that the search is reloaded 3 - Apply patch 4 - Repeat search 5 - Note that you can click "Show more" without reloading page 6 - Test that page load is not greatly affected 7 - Ensure that all facet links function normally 8 - Ensure that facets are the same a prior to patch 9 - Repeat for staff client 10 - Prove t/Search.t NOTE: This patch makes it much easier to see that there is an existing issue with marking the "active" facet. Ending punctuation seems to confuse the matcher. Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Bug 14419: (QA follow-up) Restore the link styling Test plan: Look at Show more/less links in facets, in opac and staff client --> without this patch they are pure text, no styling, no hand cursor --> with this patch it is link, but continues to work as before Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23806] New: FinePaymentAutoPopup does not trigger pop-up for writeoff by "Write off" button
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23806 Bug ID: 23806 Summary: FinePaymentAutoPopup does not trigger pop-up for writeoff by "Write off" button Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com FinePaymentAutoPopup works correctly for payments by amount, but do not for the "Write off" button that appears on each fee line. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 11

[Bug 24072] New: Typos in advance_notices.pl causes DUEDGST not to be sent
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24072 Bug ID: 24072 Summary: Typos in advance_notices.pl causes DUEDGST not to be sent Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: magnus(a)libriotech.no Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org In misc/cronjobs/advance_notices.pl we have this code: 372 if ($digest_per_branch) { 373 while (my ($branchcode, $digests) = each %$upcoming_digest) { 374 send_digests({ 375 sth => $sth_digest, 376 digests => $digests, 377 letter_code => 'PREDUEDGST', 378 branchcode => $branchcode, 379 get_item_info => sub { 380 my $params = shift; 381 $params->{sth}->execute($params->{borrowernumber}, 382 $params->{borrower_preferences}->{'days_in_advance'}); 383 return sub { 384 $params->{sth}->fetchrow_hashref; 385 }; 386 } 387 }); 388 } 389 390 while (my ($branchcode, $digests) = each %$due_digest) { 391 send_digests({ 392 sth => $sth_digest, 393 digest => $due_digest, ### HERE! 394 letter_code => 'DUEDGST', 395 branchcode => $branchcode, 396 get_item_info => sub { 397 my $params = shift; 398 $params->{sth}->execute($params->{borrowernumber}, 0); 399 return sub { 400 $params->{sth}->fetchrow_hashref; 401 }; 402 } 403 }); 404 } 405 } else { 406 send_digests({ 407 sth => $sth_digest, 408 digests => $upcoming_digest, 409 letter_code => 'PREDUEDGST', 410 get_item_info => sub { 411 my $params = shift; 412 $params->{sth}->execute($params->{borrowernumber}, 413 $params->{borrower_preferences}->{'days_in_advance'}); 414 return sub { 415 $params->{sth}->fetchrow_hashref; 416 }; 417 } 418 }); 419 420 send_digests({ 421 sth => $sth_digest, 422 digest => $due_digest, ### AND HERE! 423 letter_code => 'DUEDGST', 424 get_item_info => sub { 425 my $params = shift; 426 $params->{sth}->execute($params->{borrowernumber}, 0); 427 return sub { 428 $params->{sth}->fetchrow_hashref; 429 }; 430 } 431 }); 432 } A typo has crept in on lines 393 and 422, where "digest" should be written "digests", in the same way as it is done in the other two blocks of code. In send_digests() the incoming data is iterated over in this line: 531 PATRON: while ( my ( $borrowernumber, $digest ) = each %{$params->{digests}} ) { but when the data is actually in $params->{digest} they are not found and no DUEDGST messages are queued. -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 24064] New: DUEDGST typoed as DUEGST
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Bug ID: 24064 Summary: DUEDGST typoed as DUEGST Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: magnus(a)libriotech.no Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org Attachment 86382 of bug introduces a typo in the letter code DUEDGST: - my $letter_type = 'DUEDGST'; + letter_code => 'DUEGST', This causes "Item Due Reminder (Digest)" messages not to be sent. -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 13897] Use XML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- (In reply to Jonathan Druart from comment #9) > Hola Bernado, > I like the idea, but not XML, neither the MySQL only limitation. Salut Jonathan, I don't like XML either, nor the MySQL only. Just remember that I was thinking in translations, and xml support it's included right now. But yaml can be handled. > Why not write our own stuff, yml-based? No problem, I'll write a POC patch, but have a question: Do you think the sequence a) Read YAML > Write $tmp/out.sql > DBIx_::RunSQL->run_sql_file($tmp/out.sql) is a valid approach, or b) Read YAML > Insert into DB somehow it's better? I suppose b) is slower. (In reply to Martin Renvoize from comment #10) > This looks good. My only slight concern is whether it ties us more strictly > to MySQL or in particular a particular MySQL version. (I'm not sure how > widely supported the MySQL XML dump format is.. do they change the format > when new feature are introduced for example and does MariaDB support it > natively too). > > Perhaps we could use the well supported and maintained SQL::Translator to > produce something similar in XML, YAML or JSON as our middle format ? Hi Martin, SQL::Translator documentation states: "Presently only the definition parts of SQL are handled (CREATE, ALTER), not the manipulation of data (INSERT, UPDATE, DELETE)." And this files normally do INSERTs, don't know if it's useful in this case. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7882] Add ability to move and reorder fields in MARC editor
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #55 from Owen Leonard <oleonard(a)myacpl.org> --- I've added a minor follow-up even though this isn't working correctly for me (comment 53). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7882] Add ability to move and reorder fields in MARC editor
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '19

16 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #54 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 96352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96352&action=ed… Bug 7882: (follow-up) Update sorting interaction This follow-up modifies the CSS for the sortable fields so that a different icon is used. Elsewhere in Koha (stock rotation stage sorting) we use the "bars" icon to indicate a sortable element. I think it would be good to continue to use this. The cursor is now styled as a "Move" cursor. The configuration of the sortable function in the script has been updated in two ways: 1. The movement of the element is constrained along the y-axis, and 2. The movement of the element is contstrained to the container within which it can be moved (for the tag, the tab, and for the subfield, the tag). To test, apply the patch and edit a MARC record in the basic cataloging editor. Confirm that the new icon is used, and that the "Move" cursor shows when you hover over the icon. Confirm that a tag can be dragged up and down within the constraints of the visible section. A subfield should be only movable within its parent tag. -- You are receiving this mail because: You are watching all bug changes.

1 0