December 2019 - Koha-bugs - lists.koha-community.org

[Bug 23894] New: accountlines.payment_type and accountlines.credit_type should be merged
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '24

08 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23894 Bug ID: 23894 Summary: accountlines.payment_type and accountlines.credit_type should be merged Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com During the implementation of bug 23805 and bug 23049 it became apparent to me that the introduction of payment_type appeared to be a workaround for the lack of distinct credit and debit categories. Now we have a distinct credit_type field in accountlines which is properly governed by foreign key relationships I believe we could merge the payment_type field with this credit_type field and expose a purpose build UI for managing such types. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 10

[Bug 20489] New: Prevent DB user login
by bugzilla-daemon＠bugs.koha-community.org 07 Feb '24

07 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 Bug ID: 20489 Summary: Prevent DB user login Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org Since we have the onboarding tool that create a superlibrarian patron as well as a misc script (misc/devel/create_superlibrarian.pl), we could reject login with the DB user. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 46

[Bug 18936] New: Convert issuingrules fields to circulation_rules
by bugzilla-daemon＠bugs.koha-community.org 07 Feb '24

07 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Bug ID: 18936 Summary: Convert issuingrules fields to circulation_rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 18930 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 [Bug 18930] Move lost item refund rules to circulation_rules table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 226

[Bug 21487] New: Disable CataloguingLog syspref in UNIMARC_sync_date_created_with_marc_biblio.pl
by bugzilla-daemon＠bugs.koha-community.org 07 Feb '24

07 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21487 Bug ID: 21487 Summary: Disable CataloguingLog syspref in UNIMARC_sync_date_created_with_marc_biblio.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz Script UNIMARC_sync_date_created_with_marc_biblio.pl edits MARC record to define 099 $c and $d. This should not be registered as a cataloguing change in action_logs table. So script must disable CataloguingLog syspref (if enabled) during its process. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 23033] New: C4::Items::AddItemBatchFromMarc does not queue bib record for indexing
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '24

05 Feb '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23033 Bug ID: 23033 Summary: C4::Items::AddItemBatchFromMarc does not queue bib record for indexing Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs(a)lists.koha-community.org Reporter: paul(a)flo.org QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Callers of C4::Items::AddItemBatchFromMarc must call ModZebra (directly or indirectly) afterwards, which strikes me as wrong. AddItemBatchFromMarc used to call C4::Biblio::ModBiblioMarc, which calls C4::Items::ModZebra[*] but the call to ModBiblioMarc was commented out in commit 3584c442 (2010-09-03 12:16:52 +0200, see bug #5579) and the comment was never removed. The only code in Koha 18.11 that calls AddItemBatchFromMarc is in migration_tools/bulkmarcimport.pl, which dutifully calls MobBiblioMarc once after each call to AddItemBatchFromMarc -- even(!) if AddItemBatchFromMarc fails, which seems weird but I don't fully understand the code. We could add a call to ModZebra in AddItemBatchFromMarc but I assume it would be better to reinstate the call to ModBiblioMarc. I'll attach a patch shortly. [*] C4::Items gets ModZebra from C4::Biblio, which implements and exports it, so my will also change this to a call to C4::Biblio::ModZebra. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 17755] New: Move C4::Members::AttributeTypes to Koha::* namespace
by bugzilla-daemon＠bugs.koha-community.org 31 Jan '24

31 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Bug ID: 17755 Summary: Move C4::Members::AttributeTypes to Koha::* namespace Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 53

[Bug 23272] New: Koha::AuthorisedValue should use Koha::Object::Limit::Library
by bugzilla-daemon＠bugs.koha-community.org 31 Jan '24

31 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272 Bug ID: 23272 Summary: Koha::AuthorisedValue should use Koha::Object::Limit::Library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Koha::Patron::Attribute::Type should be used as example. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 30

[Bug 23487] New: Utf8mb4 collation causes problems with missing tables when upgrading the database
by bugzilla-daemon＠bugs.koha-community.org 30 Jan '24

30 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23487 Bug ID: 23487 Summary: Utf8mb4 collation causes problems with missing tables when upgrading the database Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: andreas.hedstrom.mace(a)sub.su.se QA Contact: testopia(a)bugs.koha-community.org Changing the default encoding to utf8mb4 and collation to utf8mb4_unicode_ci, can create duplicate unique keys as it ignores differences in accented characters vs non-accented characters. An example would be the Swedish letter ö, which is treated like the letter o. More is discussed here: https://stackoverflow.com/questions/47119794/mysql-mariadb-unable-to-handle… When upgrading a large database to any version with the new encoding and collation, there is a chance of duplicate unique keys crashing the collation change of the table (or tables) and as a result corrupting InnoDB tablespace. The final result is one or more tables that both exist and don't exist, and thus can't be deleted or created again. We, not so fondly, called them Schrödinger's tables. For Stockholm University Library, we had about 30 duplicate unique keys in the borrowers table (out of ~220K patrons), mostly in userid. Which crashed the database every time we tried to upgrade until we found the cause. The workaround solution was to change/remove these duplicates, but perhaps a better solution for the community would be to change the default encoding/collation for columns with unique keys? Perhaps utf8mb4_bin? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 7

[Bug 19372] New: Selecti MARC framework doesn' t work when adding to basket from an external source
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '24

29 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 Bug ID: 19372 Summary: Selecti MARC framework doesn't work when adding to basket from an external source Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: mglavica(a)ffzg.hr QA Contact: testopia(a)bugs.koha-community.org In acquisitions, when adding items to basket from an external source there is an option to select MARC framework. No matter what we choose, the record is created in default framework. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20

[Bug 19938] New: Refactor C4::Overdues::checkoverdues
by bugzilla-daemon＠bugs.koha-community.org 26 Jan '24

26 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Bug ID: 19938 Summary: Refactor C4::Overdues::checkoverdues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: mtompset(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com While retesting a bug, I ran a prove -r -v t, which generated a lot of log noise. One such entry was: [Tue Jan 9 03:54:58 2018] starman: Use of uninitialized value $overdues_count in numeric gt (>) at /home/vagrant/kohaclone/opac/opac-main.pl line 76. The $overdues_count was set by a call to checkoverdues. Reading the code I noticed someone actually commented: # returning the count and the results is silly So, this is a refactor of the function and all the calls. It was surprisingly small. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 40