March 2019 - Koha-bugs - lists.koha-community.org

[Bug 13735] Item form in serials module doesn't respect max length set in the frameworks
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '19

22 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13735] Item form in serials module doesn't respect max length set in the frameworks
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '19

22 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #7 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #6) > With my QA hat on.. I don't think we should require a test here.. the code > is hideously integrated and a test would end up being more complicated than > the fix itself.. When it comes to refactoring this into Koha:: we will need > lots of tests to cover these routines, spreading from integrations ui tests > down to module unit tests. > > Just my opinion for the next QAer to come along. Yeah, no problem. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '19

22 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #81 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Applying: Bug 15326: Add CMS feature .git/rebase-apply/patch:191: tab in indent. -asc => [qw/parent location branchcode lang sortorder/] .git/rebase-apply/patch:241: tab in indent. my ( $self, $id ) = @_; .git/rebase-apply/patch:243: tab in indent. carp( 'Missing CMS page id parameter in Koha::Pages::page' ) unless defined $id; .git/rebase-apply/patch:245: tab in indent. # Probably want to merge these to a single query: .git/rebase-apply/patch:246: tab in indent. my $top_links = $self->_resultset()->search( warning: squelched 77 whitespace errors warning: 82 lines add whitespace errors. Using index info to reconstruct a base tree... M installer/data/mysql/kohastructure.sql M installer/data/mysql/userpermissions.sql M koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc M koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt M opac/opac-main.pl .git/rebase-apply/patch:191: tab in indent. -asc => [qw/parent location branchcode lang sortorder/] .git/rebase-apply/patch:241: tab in indent. my ( $self, $id ) = @_; .git/rebase-apply/patch:243: tab in indent. carp( 'Missing CMS page id parameter in Koha::Pages::page' ) unless defined $id; .git/rebase-apply/patch:245: tab in indent. # Probably want to merge these to a single query: .git/rebase-apply/patch:246: tab in indent. my $top_links = $self->_resultset()->search( warning: squelched 77 whitespace errors warning: 82 lines applied after fixing whitespace errors. CONFLICT (content): Merge conflict in opac/opac-main.pl CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc Patch failed at 0001 Bug 15326: Add CMS feature -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '19

21 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #168 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 86865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86865&action=ed… Bug 8000: (QA follow-up) Add email validation to system preferences This patch uses the JQuery validator plugin to add validation to preferences of class email in the system preferences page. A field containing an invalid value (even if not modified) should prevent saving. To test, confirm that when entering an invalid email address in the SendAllEmailsTo field, an error message appears and saving is prevented. Correcting the value should hide the message and let you save as normal. Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '19

21 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #167 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 86864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86864&action=ed… Bug 8000: (QA follow-up) Update the to_address in the message queue Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '19

21 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #166 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 86863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86863&action=ed… Bug 8000: (QA follow-up) Fix accidently edited sysprefs.sql file Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '19

21 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #165 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 86862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86862&action=ed… Bug 8000: (QA follow-up) Centralise Bcc too Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '19

21 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84801|0 |1 is obsolete| | Attachment #84802|0 |1 is obsolete| | Attachment #84803|0 |1 is obsolete| | Attachment #84804|0 |1 is obsolete| | Attachment #84805|0 |1 is obsolete| | --- Comment #164 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 86861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86861&action=ed… Bug 8000: Redirect all emails to SendAllEmailsTo Rebased and squashed after changes to master. Only difference from previous patches are small adjustements to conflicts in t/db_dependent/Letters.t Test plan: 1) Apply path 2) Run updatedatabase.pl 3) Clear all SendAllEmailsTo system preference 4) Send mail to a patron of your choosing, email will go to patron's email address as usual. 5) Set SendAllEmailsTo to a test email address 6) Send mail to the patron, email will be redirected to the email set in the systempreference. 7) Run prove -v t/db_dependent/Letters.t It does not affect messages in the message_queue. This patch obsoletes previous patches, because it achieves the same functionality in a much more centralized way. (4 lines of code!) Signed-off-by: Ed Veal <eveal(a)mckinneytexas.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '19

21 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13763] Renew feature does not check for the BarcodeInputFilter option
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '19

21 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick(a)bywatersolutions.com --- Comment #13 from Nick Clemens <nick(a)bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.

1 0