March 2019 - Koha-bugs - lists.koha-community.org

[Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '19

20 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea(a)gmail.com --- Comment #32 from Liz Rea <wizzyrea(a)gmail.com> --- I just tested this, and it doesn't fail in this way any more, but the feature doesn't work either - please have another look! Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22549] New: We should really leverage the power of DBIx::Class::ResultSetColumn in Koha::Objects
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '19

20 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22549 Bug ID: 22549 Summary: We should really leverage the power of DBIx::Class::ResultSetColumn in Koha::Objects Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- calling get_column on a Koha::Objects object, we currently throw away the ResultSetColumn object and instead call ->all upon it internally to return a simple array of values instead of giving us a ResultSetColumn object back. We're then forced to do calculations either in perl or be working around the lack of ResultSetColumn. I've seen cases for 'min', 'max', 'sum' and 'as_query' at the very least. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 10030] MaxFines checks against amount, not amount outstanding
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '19

20 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22547 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10030] MaxFines checks against amount, not amount outstanding
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '19

20 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22546 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15449] Move stuffs to the Koha namespace
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '19

20 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22544 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 [Bug 22544] Move C4:.NewsChannels to Koha namespace -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22493] New: DecreaseLoanHighHolds.t creates some items/patrons with set values
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '19

20 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22493 Bug ID: 22493 Summary: DecreaseLoanHighHolds.t creates some items/patrons with set values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- We have been getting some random failures here. We are setting some barcodes and cardnumbers by hand as well as deleting lots of data. We should clean this up to see if it helps. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 13763] Renew feature does not check for the BarcodeInputFilter option
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '19

19 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 Hayley Mapley <hayleymapley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #10 from Hayley Mapley <hayleymapley(a)catalyst.net.nz> --- (In reply to Bin from comment #9) > Created attachment 86745 [details] [review] > Bug 13763: Added check for filter syspref in renew.pl > > In Circulation->Renew, the renew feature does not check the system > preference itemBarcodeFilter to see whether the barcode needs to be > converted. This patch fixes this, adding a check for the system pref and > applying it accordingly to convert the barcode if it is needed. > > Test plan: > 1) In Circulation->Renew, enter a barcode that you know exists in the > catalogue but add extra spaces, breaking up the barcode. Note that this > fails with a warning that says 'No item matches this barcode' > > 2) In system Preferences, set the itemBarcodeInputFilter pref to Remove > spaces and repeat step1. Note that the result is the same as in step 1 > > 3) Apply the patch > > 4) Repeat step 1, and note that the filter removes the spaces and the > item is renewed (or gives an error that indicates it recognises the > barcode) > > Sponsored-by: Catalyst IT > Signed-off-by: Bin Wen <bin.wen(a)inlibro.com> Thanks again for testing! I'll change the status to Signed Off so it'll get picked up by the QA team :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22203] New: Holds modal no longer links to patron
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '19

19 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22203 Bug ID: 22203 Summary: Holds modal no longer links to patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: nick(a)bywatersolutions.com Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Target Milestone: --- To recreate: 1 - Place a hold for a patron 2 - Check the item in at the pickup location 3 - Note the holds modal does not link to patron -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 13763] Renew feature does not check for the BarcodeInputFilter option
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '19

19 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 Bin <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86594|0 |1 is obsolete| | --- Comment #9 from Bin <bin.wen(a)inlibro.com> --- Created attachment 86745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86745&action=ed… Bug 13763: Added check for filter syspref in renew.pl In Circulation->Renew, the renew feature does not check the system preference itemBarcodeFilter to see whether the barcode needs to be converted. This patch fixes this, adding a check for the system pref and applying it accordingly to convert the barcode if it is needed. Test plan: 1) In Circulation->Renew, enter a barcode that you know exists in the catalogue but add extra spaces, breaking up the barcode. Note that this fails with a warning that says 'No item matches this barcode' 2) In system Preferences, set the itemBarcodeInputFilter pref to Remove spaces and repeat step1. Note that the result is the same as in step 1 3) Apply the patch 4) Repeat step 1, and note that the filter removes the spaces and the item is renewed (or gives an error that indicates it recognises the barcode) Sponsored-by: Catalyst IT Signed-off-by: Bin Wen <bin.wen(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13763] Renew feature does not check for the BarcodeInputFilter option
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '19

19 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 Bin <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #8 from Bin <bin.wen(a)inlibro.com> --- Sorry, I found that I made a wrong step in my understanding. There is no problem with the patch and test plan, which worked well！ -- You are receiving this mail because: You are watching all bug changes.

1 0