March 2019 - Koha-bugs - lists.koha-community.org

[Bug 15505] Mark Hold Items 'On hold' instead of 'Available'
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '19

20 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86817|0 |1 is obsolete| | --- Comment #16 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 86821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86821&action=ed… Bug 15505: Mark Hold Items 'On hold' instead of 'Available' This patch adds a 'pending hold' column to C4::Items:GetItemsInfo to allow for displaying status of an item when it has been selected for a hold by the holdsqueue and AllowItemsOnHoldCheckout is set to 'Don't allow' To test: 00 - Set AllowItemsOnHoldCheckout to 'Allow' 01 - Place a hold on an item 02 - Build the holdsqueue (kohadevbox example below) sudo koha-shell kohadev perl misc/cronjobs/holds/build_holds_queue.pl 03 - Search for the item on the OPAC 04 - Note item shows as 'Available' in results and details 05 - Toggle AllowItemsOnHOldCheckout to 'Don't allow' 06 - Repeat search, note there is no change 06 - Apply Patch 07 - Search for the item on the OPAC 08 - Note that item now shows as 'Pending hold' 09 - Toggle AllowItemsOnHoldCheckout to Allow 10 - Note item shows as available 11 - prove -v t/db_dependent/Items.t Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15505] Mark Hold Items 'On hold' instead of 'Available'
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '19

20 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13618] Add additional template filter methods and a filter presence test to Koha
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '19

20 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22550 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 [Bug 22550] OPAC suggestion form doesn't require mandatory fields -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13763] Renew feature does not check for the BarcodeInputFilter option
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '19

20 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 --- Comment #12 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 86819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86819&action=ed… Bug 13763: (follow-up) Strip leading whitespace characters from input barcode this makes the work with barcodes from input consistant on checking out, checking in and renewing Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13763] Renew feature does not check for the BarcodeInputFilter option
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '19

20 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86745|0 |1 is obsolete| | --- Comment #11 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 86818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86818&action=ed… Bug 13763: Added check for filter syspref in renew.pl In Circulation->Renew, the renew feature does not check the system preference itemBarcodeFilter to see whether the barcode needs to be converted. This patch fixes this, adding a check for the system pref and applying it accordingly to convert the barcode if it is needed. Test plan: 1) In Circulation->Renew, enter a barcode that you know exists in the catalogue but add extra spaces, breaking up the barcode. Note that this fails with a warning that says 'No item matches this barcode' 2) In system Preferences, set the itemBarcodeInputFilter pref to Remove spaces and repeat step1. Note that the result is the same as in step 1 3) Apply the patch 4) Repeat step 1, and note that the filter removes the spaces and the item is renewed (or gives an error that indicates it recognises the barcode) Sponsored-by: Catalyst IT Signed-off-by: Bin Wen <bin.wen(a)inlibro.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15505] Mark Hold Items 'On hold' instead of 'Available'
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '19

20 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85349|0 |1 is obsolete| | --- Comment #15 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 86817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86817&action=ed… Bug 15505 - Mark Hold Items 'On hold' instead of 'Available' This patch adds a 'pending hold' column to C4::Items:GetItemsInfo to allow for displaying status of an item when it has been selected for a hold by the holdsqueue and AllowItemsOnHoldCheckout is set to 'Don't allow' To test: 00 - Set AllowItemsOnHoldCheckout to 'Allow' 01 - Place a hold on an item 02 - Build the holdsqueue (kohadevbox example below) sudo koha-shell kohadev perl misc/cronjobs/holds/build_holds_queue.pl 03 - Search for the item on the OPAC 04 - Note item shows as 'Available' in results and details 05 - Toggle AllowItemsOnHOldCheckout to 'Don't allow' 06 - Repeat search, note there is no change 06 - Apply Patch 07 - Search for the item on the OPAC 08 - Note that item now shows as 'Pending hold' 09 - Toggle AllowItemsOnHoldCheckout to Allow 10 - Note item shows as available 11 - prove -v t/db_dependent/Items.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13763] Renew feature does not check for the BarcodeInputFilter option
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '19

20 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15505] Mark Hold Items 'On hold' instead of 'Available'
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '19

20 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13763] Renew feature does not check for the BarcodeInputFilter option
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '19

20 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com QA Contact|testopia(a)bugs.koha-communit |josef.moravec(a)gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '19

20 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #115 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 86816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86816&action=ed… Bug 14576: Rebase fixes Fix test Rebase code -- You are receiving this mail because: You are watching all bug changes.

1 0