April 2019 - Koha-bugs - lists.koha-community.org

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '19

17 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '19

17 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #76 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- System preference names don't match up: Database updates add 4 different prefs: OPACnumSearchResultsPerPage numSearchResultsPerPage OPACnumSearchResultsDropdown numSearchResultsDropdown syspref.sql adds only 2: numSearchResultsPerPage OPACnumSearchResultsPerPage yaml file has: OPACnumSearchResultsDropdown numSearchResultsDropdown Code appears to use the Dropdown version. Please, when cleaning this up: Database update SQL files should be merged and moved into a .perl file - this will make the RM much happier. For later: New cookie results_per_page needs documentation on the wiki. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '19

17 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #137 from Michal Denar <black23(a)gmail.com> --- Patch look working and useful. I'll wait till follow-up for final test. Thank you. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '19

17 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Brian <bklein(a)dubuque.lib.ia.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bklein(a)dubuque.lib.ia.us --- Comment #9 from Brian <bklein(a)dubuque.lib.ia.us> --- Any updates on bug 13188? Carnegie team. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

1 0

[Bug 19225] New: Warn on About page regarding sysprefs autoMemberNum and BorrowerMandatoryField
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19225 Bug ID: 19225 Summary: Warn on About page regarding sysprefs autoMemberNum and BorrowerMandatoryField Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Display a warning on the About page if system preference automembernum is on and BorrowerMandatoryFields contains cardnumber. See Bug 18636 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636#c8 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #136 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- (In reply to Josef Moravec from comment #135) > Comment on attachment 88038 [details] [review] > Bug 15516: (follow-up) Fixing modal view and more > > Review of attachment 88038 [details] [review]: > ----------------------------------------------------------------- > > Just quick look into the follow-ups, found this: > > ::: installer/data/mysql/atomicupdate/bug_15516_-_hold_group_table.perl > @@ +3,5 @@ > > + $dbh->do(q{DROP TABLE IF EXISTS hold_group}); > > + $dbh->do(q{CREATE TABLE hold_group ( > > + hold_group_id int unsigned NOT NULL AUTO_INCREMENT, > > + PRIMARY KEY (hold_group_id) > > + ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci}); > > should be utf8mb4 I'll fix this up -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20937] New: PrintNoticesMaxLines is not effective for overdue notices with a print type specified where a patron has an email
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20937 Bug ID: 20937 Summary: PrintNoticesMaxLines is not effective for overdue notices with a print type specified where a patron has an email Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The logic in the script is: if ( ( scalar(@emails_to_use) == 0 || $nomail ) && $PrintNoticesMaxLines && $j >= $PrintNoticesMaxLines ) So if we don't pass 'nomail' and the patron has an email, the items don't get kicked out. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 22595] New: Items search is mixing inputs
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22595 Bug ID: 22595 Summary: Items search is mixing inputs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Items search is using inputs and selects from search form to create an Ajax call. In this call selects are parsed before inputs. But a custom search field can be used with authorised values and used after a regular search field. In this case the "q" param is not ordered like the "name" param. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13

[Bug 22646] New: Fix use of PrivacyPolicyURL
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22646 Bug ID: 22646 Summary: Fix use of PrivacyPolicyURL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Target Milestone: --- Bug 20819 introduced two new sysprefs: GDPR_Policy and PrivacyPolicyURL. The latter is used in a couple of places in the code: * koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-patron-consent.tt, line 44: 38 [% IF Koha.Preference('GDPR_Policy') %] ... 44 I have read the <a target="_blank" href="[% Koha.Preference('PrivacyPolicyURL') | url %]">privacy policy</a> and agree with your processing of my personal data as outlined therein. * koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt, line 906: 901 [% IF Koha.Preference('GDPR_Policy') && action != 'edit' %] ... 906 <label></label><input type="checkbox" name="borrower_gdpr_proc_consent" value="agreed"> I agree with your processing of my personal data as outlined in the <a target="_blank" href="[% PrivacyPolicyURL | url %]">privacy policy</a>. Required Two problems here: 1. The second occurence forgets to do Koha.Preference('PrivacyPolicyURL'), so no URL is included in the page 2. Neither occurence checks if PrivacyPolicyURL is defined before using it, but the description of PrivacyPolicyURL does not say that it is mandatory if GDPR_Policy is defined. So do we check if PrivacyPolicyURL is defined before displaying the link, or do we say that PrivacyPolicyURL is mandatory if GDPR_Policy is set? Personally I am under the impression that having a public privacy policy is part of being GDPR compliant, so I will submit a patch that adds a "mandatory" text to the sysprefs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 12