April 2019 - Koha-bugs - lists.koha-community.org

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78299|0 |1 is obsolete| | Attachment #78300|0 |1 is obsolete| | Attachment #78301|0 |1 is obsolete| | Attachment #78302|0 |1 is obsolete| | Attachment #79797|0 |1 is obsolete| | Attachment #81203|0 |1 is obsolete| | Attachment #88097|0 |1 is obsolete| | --- Comment #68 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 88102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88102&action=ed… Bug 14715: results per page setting for catalog search Add new select field to catalog search results pages which allows user to set number of results to be shown per page. Setting saved in cookie "results_per_page". To test: 1) Do a catalog search in the intranet and OPAC 2) Confirm that results automatically update upon selection of results per page to show 3) Test for all options (20, 40, 60, 80, 100, all) Bug 14715: syspref for results per page options Remove the "all" option. Add syspref [OPAC]numSearchResultsPerPage for specifying options for numbers of results per page including [OPAC]numSearchResults. Bug 14715: database updates Bug 14715: Fixing pagination problems Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Cab Vinton <bibliwho(a)gmail.com> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78298|0 |1 is obsolete| | --- Comment #67 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 88097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88097&action=ed… Bug 14715: results per page setting for catalog search Add new select field to catalog search results pages which allows user to set number of results to be shown per page. Setting saved in cookie "results_per_page". To test: 1) Do a catalog search in the intranet and OPAC 2) Confirm that results automatically update upon selection of results per page to show 3) Test for all options (20, 40, 60, 80, 100, all) Bug 14715: syspref for results per page options Remove the "all" option. Add syspref [OPAC]numSearchResultsPerPage for specifying options for numbers of results per page including [OPAC]numSearchResults. Bug 14715: database updates Bug 14715: Fixing pagination problems Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Cab Vinton <bibliwho(a)gmail.com> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea(a)gmail.com --- Comment #66 from Liz Rea <wizzyrea(a)gmail.com> --- I'm going to sign off on this despite these two things: FAIL installer/data/mysql/atomicupdate/bug_14715-searchresults_syspref.sql FAIL git manipulation The file has been added and deleted in the same patchset ^^ I couldn't figure out how to resolve that, someone share plz. FAIL installer/data/mysql/atomicupdate/bug_14715_-_results_per_page_dropdown_sysprefs.sql OK git manipulation OK semicolon FAIL sysprefs_order Not blocker: Sysprefs numSearchResultsDropdown is bad placed (see bug 10610) ^^ isn't a blocker so I'm not letting it block me. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea(a)gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #77 from Liz Rea <wizzyrea(a)gmail.com> --- Patch no longer applies, sorry. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18432] New: Most code comments assume male gender
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18432 Bug ID: 18432 Summary: Most code comments assume male gender Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Developer documentation Assignee: gmcharlt(a)gmail.com Reporter: ephetteplace(a)cca.edu QA Contact: testopia(a)bugs.koha-community.org Throughout the Koha codebase, the pronoun "he" is used to refer to a generic third person who could be of any gender. For instance, in C4/Suggestions.pm line #66: 'When a librarian manages the suggestion, he can set the status to "REJECTED" or "ACCEPTED".' That assumes all librarians are male. It's particularly problematic given that, in the US at least, the profession is heavily female. In other files, all borrowers are assumed to be male. In the interest of making the code base more inclusive, it'd be better to not assume a male gender. The patch—which touches *a lot* of disparate files but almost only comments—changes all instances of "he" or "him" I could find to "he or she" and "him or her" respectively. I'd also be in support of singular "they"/"their" in these situations if people prefer that. In a few cases, a non-human object was being referred to as "he", so I used "it" instead. FYI, the regex I used to find uses of the pronoun "he" and "him": - / (H|h)e (?!or she)/ - / (H|h)im (?!or her)/ I ignored "docs/history.txt" and "misc/release_notes" since those seem to refer to actual men who worked on Koha, and also the Maori translations. There were 3 "unimarc_framework_DEFAULT.sql" files also used "he" in a way that seemed to refer to a particular individual, though I'm not sure. Testing plan: - I can't really formulate a "testing plan" for this patch since it shouldn't impact actual executing code - The patch does touch strings in a few tests so at the very least these should continue to pass: M C4/SIP/t/06patron_enable.t M koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt M t/db_dependent/Circulation.t M t/db_dependent/Koha/Patrons.t M t/db_dependent/Reserves.t -- You are receiving this mail because: You are watching all bug changes.

1 31

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #267 from Séverine Queune <severine.queune(a)bulac.fr> --- Sorry Julian for the lack of reaction... CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-menu.inc Auto-merging acqui/basketgroup.pl CONFLICT (content): Merge conflict in acqui/basketgroup.pl Auto-merging acqui/basket.pl Auto-merging Koha/Acquisition/Basket.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 11708: New page for basket groups -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21949] New: Error when searching for a patron
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21949 Bug ID: 21949 Summary: Error when searching for a patron Change sponsored?: --- Product: Koha Version: 18.11 Hardware: HP OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: sergeinik(a)tut.by QA Contact: testopia(a)bugs.koha-community.org When searching for a patrons, the page hangs, and the developer tool gives the following error on line 46: /** * http://www.openjs.com/scripts/events/keyboard_shortcuts/ * Version : 2.01.B * By Binny V A * License : BSD */ shortcut = { 'all_shortcuts':{},//All the shortcuts are stored in this array 'add': function(shortcut_combination,callback,opt) { //Provide a set of default options var default_options = { 'type':'keydown', 'propagate':false, 'disable_in_input':false, 'target':document, 'keycode':false } if(!opt) opt = default_options; else { for(var dfo in default_options) { if(typeof opt[dfo] == 'undefined') opt[dfo] = default_options[dfo]; } } var ele = opt.target; if(typeof opt.target == 'string') ele = document.getElementById(opt.target); var ths = this; shortcut_combination = shortcut_combination.toLowerCase(); //The function to be called at keypress var func = function(e) { e = e || window.event; if(opt['disable_in_input']) { //Don't enable shortcut keys in Input, Textarea fields var element; if(e.target) element=e.target; else if(e.srcElement) element=e.srcElement; if(element.nodeType==3) element=element.parentNode; if(element.tagName == 'INPUT' || element.tagName == 'TEXTAREA') return; } //Find Which key is pressed if (e.keyCode) code = e.keyCode; else if (e.which) code = e.which; //This ERROR!!! var character = String.fromCharCode(code).toLowerCase(); if(code == 188) character=","; //If the user presses , when the type is onkeydown if(code == 190) character="."; //If the user presses , when the type is onkeydown var keys = shortcut_combination.split("+"); //Key Pressed - counts the number of valid keypresses - if it is same as the number of keys, the shortcut function is invoked var kp = 0; //Work around for stupid Shift key bug created by using lowercase - as a result the shift+num combination was broken var shift_nums = { "`":"~", "1":"!", "2":"@", "3":"#", "4":"$", "5":"%", "6":"^", "7":"&", "8":"*", "9":"(", "0":")", "-":"_", "=":"+", ";":":", "'":"\"", ",":"<", ".":">", "/":"?", "\\":"|" } //Special Keys - and their codes var special_keys = { 'esc':27, 'escape':27, 'tab':9, 'space':32, 'return':13, 'enter':13, 'backspace':8, 'scrolllock':145, 'scroll_lock':145, 'scroll':145, 'capslock':20, 'caps_lock':20, 'caps':20, 'numlock':144, 'num_lock':144, 'num':144, 'pause':19, 'break':19, 'insert':45, 'home':36, 'delete':46, 'end':35, 'pageup':33, 'page_up':33, 'pu':33, 'pagedown':34, 'page_down':34, 'pd':34, 'left':37, 'up':38, 'right':39, 'down':40, 'f1':112, 'f2':113, 'f3':114, 'f4':115, 'f5':116, 'f6':117, 'f7':118, 'f8':119, 'f9':120, 'f10':121, 'f11':122, 'f12':123 } var modifiers = { shift: { wanted:false, pressed:false}, ctrl : { wanted:false, pressed:false}, alt : { wanted:false, pressed:false}, meta : { wanted:false, pressed:false} //Meta is Mac specific }; if(e.ctrlKey) modifiers.ctrl.pressed = true; if(e.shiftKey) modifiers.shift.pressed = true; if(e.altKey) modifiers.alt.pressed = true; if(e.metaKey) modifiers.meta.pressed = true; for(var i=0; k=keys[i],i<keys.length; i++) { //Modifiers if(k == 'ctrl' || k == 'control') { kp++; modifiers.ctrl.wanted = true; } else if(k == 'shift') { kp++; modifiers.shift.wanted = true; } else if(k == 'alt') { kp++; modifiers.alt.wanted = true; } else if(k == 'meta') { kp++; modifiers.meta.wanted = true; } else if(k.length > 1) { //If it is a special key if(special_keys[k] == code) kp++; } else if(opt['keycode']) { if(opt['keycode'] == code) kp++; } else { //The special keys did not match if(character == k) kp++; else { if(shift_nums[character] && e.shiftKey) { //Stupid Shift key bug created by using lowercase character = shift_nums[character]; if(character == k) kp++; } } } } if(kp == keys.length && modifiers.ctrl.pressed == modifiers.ctrl.wanted && modifiers.shift.pressed == modifiers.shift.wanted && modifiers.alt.pressed == modifiers.alt.wanted && modifiers.meta.pressed == modifiers.meta.wanted) { callback(e); if(!opt['propagate']) { //Stop the event //e.cancelBubble is supported by IE - this will kill the bubbling process. e.cancelBubble = true; e.returnValue = false; //e.stopPropagation works in Firefox. if (e.stopPropagation) { e.stopPropagation(); e.preventDefault(); } return false; } } } this.all_shortcuts[shortcut_combination] = { 'callback':func, 'target':ele, 'event': opt['type'] }; //Attach the function with the event if(ele.addEventListener) ele.addEventListener(opt['type'], func, false); else if(ele.attachEvent) ele.attachEvent('on'+opt['type'], func); else ele['on'+opt['type']] = func; }, //Remove the shortcut - just specify the shortcut and I will remove the binding 'remove':function(shortcut_combination) { shortcut_combination = shortcut_combination.toLowerCase(); var binding = this.all_shortcuts[shortcut_combination]; delete(this.all_shortcuts[shortcut_combination]) if(!binding) return; var type = binding['event']; var ele = binding['target']; var callback = binding['callback']; if(ele.detachEvent) ele.detachEvent('on'+type, callback); else if(ele.removeEventListener) ele.removeEventListener(type, callback, false); else ele['on'+type] = false; } } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 14457] Integrate LIBRIS spellchecking
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick(a)bywatersolutions.com --- Comment #40 from Nick Clemens <nick(a)bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12561] Omnibus: Deprecate non-XSLT detail and result views
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Bug 12561 depends on bug 21891, which changed state. Bug 21891 Summary: Remove non-XSLT detail view in the staff client https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

1 0