April 2019 - Koha-bugs - lists.koha-community.org

[Bug 19630] New: "Hold is suspended" message appears in barcode field in holds table
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 Bug ID: 19630 Summary: "Hold is suspended" message appears in barcode field in holds table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Created attachment 69169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69169&action=ed… Suspended hold message appears in barcode field In Intranet, when we suspend a hold, the message "hold is suspended" appears in a column titled "barcode". Even when the hold is not suspended, that column doesn't show the barcode. I'm guessing it's just a wording problem... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 25

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #10 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- Test plan: Set up ------ - Apply patches - Set the useDaysMode syspref to "Calculate the due date using the calendar to push the due date to the next open matching weekday for weekly loan periods, or the next open day otherwise" - In order to test this functionality, you will need items with weekly (or multiples of) loan period (e.g. 7, 14, 21 days etc) Test 1 - One week roll forward ------------------------------ Here we test that loans and renewals roll forward one week if the expected due date is closed. - Identify the loan and renewal periods of the item you intend testing and add a temporary closure day to the calendar on the due date for issues and renewals - Issue the item => TEST: Observe the item's due date rolled forward to one week later than the expected issue due date - Renew the item => TEST: Observe the item's due date rolled forward to one week later than the expected renewal due date Test 2 - Multiple week roll forward ----------------------------------- Here we test that loans and renewals continue to roll forward if there are subsequent closures on the day of the week of the due date - Identify the loan and renewal periods of the item you intend testing and add a closure temporary day to the calendar on the due date for issues and renewals, and also to the two subsequent weeks on the same day - Issue the item => TEST: Observe the item's due date rolled forward to one week later than the lastclosure day for that day of the week - Renew the item => TEST: Observe the item's due date rolled forward to one week later than the lastclosure day for that day of the week Test 3 - Permanent closures --------------------------- Here we test that the functionality doesn't try to continue looking for an open day on the same day of the week as the expected due date if the library has a permanent closure on that day of the week, instead it rolls forward a single day - Identify the loan and renewal periods of the item you intend testing and add a recurring holiday on the day of the week of the expected due date - Issue the item => TEST: Observe that the item's due date only rolled forward a single day from the original due date as it was unable to roll forward a week or multiple weeks - Add a recurring holiday on the day of the week of the item's new due date - Renew the item => TEST: Observe that the item's due date only rolled forward a single day from the original renewal due date as it was unable to roll forward a week or multiple weeks -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10382] collection and location not returning to null when removed from course reserves
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 [Bug 22652] Editing Course reserves is broken -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #9 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- Created attachment 88059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88059&action=ed… Bug 15260: (follow-up) Fix misnamed variable This was causing the amount to push by to be incorrectly calculated -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #8 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- Created attachment 88057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88057&action=ed… Bug 15260: Fix calculation of add amount In a sequence of closed days, we should take into account the nature of each closed day as we encounter it in order to calculate the amount to add to reach the next potential closed date. We are now doing this. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #7 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- Created attachment 88056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88056&action=ed… Bug 15260: Add unit tests This patch adds unit tests of the CalcDueDate function to ensure that the useDaysMode "Dayweek" mode works as expected -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #6 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- Created attachment 88055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88055&action=ed… Bug 15260: Implement weekly rollforward This patch will, when appropriate, roll due dates forward by full weeks, rather than single days. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #5 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- Created attachment 88054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88054&action=ed… Bug 15260: Modify next/prev_open_day We require next_open_day & prev_open_day to be more flexible. We could create a separate sub, but that's not very DRY given that they'll do pretty much the same thing. So next_open_day becomes next_open_days and prev_open_day becomes prev_open_days and both functions accept an additional parameter which determines how many days they add or subtract. All calls of these two functions have been modified accordingly. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #4 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- Created attachment 88053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88053&action=ed… Bug 15260: Modify description of Dayweek option -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '19

16 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #3 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- Created attachment 88052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88052&action=ed… Bug 15260: Add new useDaysMode option "Dayweek" This patch adds a new "Dayweek" option to the useDaysMode syspref, it has the description: "the calendar to push the due date to the next open day on the same weekday". -- You are receiving this mail because: You are watching all bug changes.

1 0