April 2019 - Koha-bugs - lists.koha-community.org

[Bug 11969] Show patrons star rating on their reading history
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '19

09 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11969 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7012] Limit to available does not exclude in-transit items
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '19

09 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7012 Daniel Gaghan <daniel.gaghan(a)pueblolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.gaghan@pueblolibrary | |.org --- Comment #4 from Daniel Gaghan <daniel.gaghan(a)pueblolibrary.org> --- We at PCCLD are seeing this error on 18.05 and it's causing some headaches amongst our staff. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '19

09 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #99 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 87617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87617&action=ed… Bug 15326: (follow-up) Remove obsolete LESS file, add TT filters Previous versions of this patch set adds a LESS file to the OPAC, which is now obsolete. It should be removed. In addition, the change made to opac.less contained CSS which didn't apply to any existing markup, so it need not be added to opac.scss. The patch also adds missing Template Toolkit filters to template files. None of these changes should be visible in testing. OPAC CMS pages should function as usual. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '19

09 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #98 from Owen Leonard <oleonard(a)myacpl.org> --- One thing that I would really like to see improved: I think the navigation menu in the OPAC doesn't work the way it should. For example, this menu based on pages I was testing with: - About us - About us › Nelsonville Public Library - About us › Athens Public Library - About us › The Plains Public Library Why is "About us" repeated for each sub-page? Why aren't sub-pages displayed as a list nested inside the list containing the parent link? Based on other CMS navigation menus I would have expected this: <ul> <li>About us <ul> <li>Nelsonville Public Library</li> <li>Athens Public Library</li> <li>The Plains Public Library</li> </ul> </li> </ul> This is semantically more correct and provides more flexibility for CSS styling because you can leverage element nesting. The other thing I see which seems wrong is that if I'm looking at the parent page ("About us" in the example above) I don't see the sub-pages. I would expect them to either be shown all the time or only when viewing the parent page or its sub-pages. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '19

09 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87610|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '19

09 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #97 from Owen Leonard <oleonard(a)myacpl.org> --- I fixed template issues reported by the QA tool, but not Perl errors. I'm leaving this in 'failed QA' because of that. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '19

09 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #96 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 87610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87610&action=ed… Bug 15326: (follow-up) Remove obsolete LESS file, add TT filters Previous versions of this patch set adds a LESS file to the OPAC, which is now obsolete. It should be removed. In addition, the change made to opac.less contained CSS which didn't apply to any existing markup, so it need not be added to opac.scss. The patch also adds missing Template Toolkit filters to template files. None of these changes should be visible in testing. OPAC CMS pages should function as usual. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '19

09 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #95 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 87609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87609&action=ed… Bug 15326: (follow-up) Corrections to staff client templates This patch makes some corrections to the staff client's CMS-related templates: - Add missing Template Toolkit filters. - Remove JavaScript from tools-menu.inc. This must have crept in during a rebase. - Add navigation link highlighting to tools-menu.js instead. - Convert tools/cmspages.tt to Bootstrap grid. - Correct toolbar button class. - Move some column sorting configuration out of JS and into table markup. - Move "Select all" / "Clear all" links to the top of the table to match similar interfaces. - Change the Action menu's "Intranet" and "OPAC" links to be "View" and "View in OPAC." The OPAC view now opens a new window. To test, apply the patches and test the Pages feature in the staff client: Adding, editing, deleting, viewing. For each view, test that the page layout adjusts to various browser widths. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '19

09 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #94 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 87608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87608&action=ed… Bug 15326: (follow-up) Redindent new CMS page templates This patch is an opinionated reindent of new and changed templates related to the CMS feature. I think it would be nice for these templates to start out with good indentation. To test, apply the patch and test the CMS feature. There should be no visible change to the way it looks or the way it works. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8338] fines not cleared with dropbox mode
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '19

09 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22512 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are watching all bug changes.

1 0