April 2019 - Koha-bugs - lists.koha-community.org

[Bug 11573] change description of rental charges in account fines
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '19

09 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #33 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- This one hasn't received any love for a while and there are new reports (and patches) in it's place.. I'm going to look at the more recent efforts and see fi those resolve it. Marking as duplicate. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12166] Improve display of hold charges in patron account
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '19

09 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 Bug 12166 depends on bug 11573, which changed state. Bug 11573 Summary: change description of rental charges in account fines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11573] change description of rental charges in account fines
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '19

09 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #32 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- *** This bug has been marked as a duplicate of bug 21953 *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12166] Improve display of hold charges in patron account
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '19

09 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 --- Comment #21 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Dependencies seem a bit weird.. this patch happily applies without bug 11573. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12166] Improve display of hold charges in patron account
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '19

09 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #20 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Nice fix, no regressions and passes the QA scripts and I've added a followup for you to correct the failing test. Passing QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12166] Improve display of hold charges in patron account
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '19

09 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 --- Comment #19 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 87587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87587&action=ed… Bug 12166: (QA follow-up) Update test for description Update the relevant test to check for 'description eq title' as aposed to the old 'description eq "Reserve Charge - title"'. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12166] Improve display of hold charges in patron account
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '19

09 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87521|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 87586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87586&action=ed… Bug 12166: (follow-up) Fix sequence of columns in OPAC Type and description column headings were switched. To test: - Check the table headings of the fines table in the OPAC fines table match the content Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12166] Improve display of hold charges in patron account
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '19

09 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87520|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 87585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87585&action=ed… Bug 12166: (follow-up) Remove 'Reserve Charge' from descriptions in accountlines With the prior 'Hold fee' will be displayed in OPAC and staff, so the 'Reserve Charge' would just be an untranslatable double up of information. To test: - Make sure you create some Reserve Charges prior to applying this patch set - Verify they show in staff and OPAC account - Apply patch - Run database update - Verfy the "Rental Charge - " is gone and old and new entries match now Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12166] Improve display of hold charges in patron account
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '19

09 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87472|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 87584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87584&action=ed… Bug 12166: Improve display of Reserve charges in patron account This patch makes changes to the way hold fees are recorded and displayed in the OPAC and staff client: - No English strings should be stored in the accountline description. - The accounttype code should be used to display what kind of charge it is. To test, apply the patch and go to the staff client: - Configure a patron category to have a hold fee. - Place one or more holds for a patron in that category. - On the patron's record, view Accounting -> Make a payment - There should be a separate column for "Account type" showing "Hold fee" for the hold charges. - There should be no "Res" or "Reserve Charge" text in the description column--just the title. - Switch to the "Transactions" tab. The display should be similar. - In the OPAC, log in as a patron who has hold fees on their account. - View the "your fines" page to confirm that the information is displayed correctly there as well. - Place a hold for a patron who incurs hold charges. - Log in to the self-checkout module as that patron and check out an item which will fulfill that hold. - The correct fine information should be saved to accountlines: A "Res" type with a description consisting only of the title. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3766] Cities/Towns and Road types only on one address
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '19

09 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3766 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0