April 2019 - Koha-bugs - lists.koha-community.org

[Bug 14723] Additional delivery notes to messages
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '19

08 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87525|0 |1 is obsolete| | --- Comment #30 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 87531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87531&action=ed… Bug 14723: Additional delivery notes to messages This patch adds additional delivery notes to messages in message queue as there can be multiple reasons for a delivery to fail. Currently in message_queue we are given only two delivery statuses for messages, "sent" and "failed". When the status becomes failed, we have no idea why it fails. This feature can be useful with SMS gateway providers. Many SMS gateways inform the application the reason of SMS delivery failure. With this feature, this information can now be stored. As well as for emails, instead of simply logging failures, we can now store the reason of failure directly into the message row of message_queue. Test plan: 1. Enable EnhancedMessagingPreferences syspref 2. Find a borrower with notices at members/notices.pl 3. Observe that there is no column for Delivery notes 4. Apply patch and run the given database update 5. Repeat step 1. 6. Observe that there is now a column for Delivery notes Sponsored-by: Hypernova Oy Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3766] Cities/Towns and Road Types only on one address
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '19

08 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3766 --- Comment #6 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 87530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87530&action=ed… Bug 3766: Cities/Towns and Road Types only on one address This patch ties the alternate address and alternate contact address fields in the patron entry form to the cities and towns data. This provides a dropdown of predefined city data to these address fields. To test, apply the patch and edit a patron record. Test city selection for all three address fields: Main address, alternate address, and alternate contact. Confirm that city selection works correctly and that your changes are saved correctly. Perform these tests with all AddressFormat options: French, German, and US. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3766] Cities/Towns and Road Types only on one address
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '19

08 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3766 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 14791] Automatically attempt to resend failed notices
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '19

08 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791 Lari Taskula <lari.taskula(a)hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62622|0 |1 is obsolete| | --- Comment #13 from Lari Taskula <lari.taskula(a)hypernova.fi> --- Created attachment 87527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87527&action=ed… Bug 14791: Automatically resend SMS notices that failed due to network problems Sometimes notices keep failing due to various reasons. One common problem is network connection failures. Because of this, the notices go into 'failed' state. This is very problematic, because we have to not only monitor the failed messages but also resend them manually. The purpose of this patch is to enable more automated way of handling delivery failures. This patch enables us to handle exceptions in SMS messaging. The main idea is to throw an exception from SMS::Send driver in case of a failure. The exception will be caught by C4::SMS and from here it will be forwarded to C4::Letters, where instead of automatically setting the message into 'failed' status, we now can decide what to do with the message. As an example I have caught Koha::Exceptions::ConnectionFailed in C4::Letters::_send_message_by_sms(). When we catch the said exception, we simply leave the message in 'pending' status. This way it will be resent whenever process_message_queue.pl is executed again. sub send_sms { #.....your implementation..... # Throw an exception in case of a connection error # $connError can be for example: ($curl->{'retcode'} == 6) # cURL code 6: CURLE_COULDNT_RESOLVE_HOST if ($connError){ Koha::Exceptions::ConnectionFailed->throw(error => "Connection failed"); } } To test: 1. prove t/db_dependent/Letters.t Also testable with your own implementation of SMSSendDriver. 1. Have/create some pending sms messages into message_queue 2. Go to Patrons -> Notices 3. Observe that the your message is in pending status 4. Run misc/cronjob/process_message_queue.pl 5. Observe that the message is no longer pending 6. Add Koha::Exceptions::ConnectionFailed->throw(error => "Connection failed"); to your SMS::Send driver send_sms. 7. Set your message back to pending status 8. Run misc/cronjob/process_message_queue.pl 9. Observe that your message is back in pending status 10. Observe it also has the following delivery note: "Connection failed. Attempting to resend." Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14791] Automatically attempt to resend failed notices
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '19

08 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791 Lari Taskula <lari.taskula(a)hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13044] Deprecate old book drop mode
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '19

08 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13044 Cheryl <clackman(a)fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman(a)fargolibrary.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14723] Additional delivery notes to messages
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '19

08 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula <lari.taskula(a)hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78313|0 |1 is obsolete| | --- Comment #29 from Lari Taskula <lari.taskula(a)hypernova.fi> --- Created attachment 87525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87525&action=ed… Bug 14723: Additional delivery notes to messages This patch adds additional delivery notes to messages in message queue as there can be multiple reasons for a delivery to fail. Currently in message_queue we are given only two delivery statuses for messages, "sent" and "failed". When the status becomes failed, we have no idea why it fails. This feature can be useful with SMS gateway providers. Many SMS gateways inform the application the reason of SMS delivery failure. With this feature, this information can now be stored. As well as for emails, instead of simply logging failures, we can now store the reason of failure directly into the message row of message_queue. Test plan: 1. Enable EnhancedMessagingPreferences syspref 2. Find a borrower with notices at members/notices.pl 3. Observe that there is no column for Delivery notes 4. Apply patch and run the given database update 5. Repeat step 1. 6. Observe that there is now a column for Delivery notes Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14723] Additional delivery notes to messages
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '19

08 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula <lari.taskula(a)hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12166] Improve display of hold charges in patron account
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '19

08 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 --- Comment #15 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 87521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87521&action=ed… Bug 12166: (follow-up) Fix sequence of columns in OPAC Type and description column headings were switched. To test: - Check the table headings of the fines table in the OPAC fines table match the content Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12166] Improve display of hold charges in patron account
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '19

08 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87478|0 |1 is obsolete| | Attachment #87479|0 |1 is obsolete| | --- Comment #14 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 87520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87520&action=ed… Bug 12166: (follow-up) Remove 'Reserve Charge' from descriptions in accountlines With the prior 'Hold fee' will be displayed in OPAC and staff, so the 'Reserve Charge' would just be an untranslatable double up of information. To test: - Make sure you create some Reserve Charges prior to applying this patch set - Verify they show in staff and OPAC account - Apply patch - Run database update - Verfy the "Rental Charge - " is gone and old and new entries match now Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0