May 2019 - Koha-bugs - lists.koha-community.org

[Bug 22254] New: t/db_dependent/Koha/Patrons.t contains a DateTime math error
by bugzilla-daemon＠bugs.koha-community.org 27 May '19

27 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22254 Bug ID: 22254 Summary: t/db_dependent/Koha/Patrons.t contains a DateTime math error Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- So, one of the peculiarities of DateTime maths is that 12 plus 1 doesn't always equal 13 ;) This calls for an example (using 'limit' for end_of_month mode): 2019-01-31 + 1 month = 2019-02-28 2019-01-31 + 13 months = 2020-02-29 (this one maintains 'end of month' over the leap year) 2019-02-28 + 12 months = 2020-02-28 Koha does the third case but the test is currently setup for the second. -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts
by bugzilla-daemon＠bugs.koha-community.org 27 May '19

27 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 Bug 2505 depends on bug 20000, which changed state. Bug 20000 Summary: use Modern::Perl in installer perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20000] New: use Modern::Perl in installer perl scripts
by bugzilla-daemon＠bugs.koha-community.org 27 May '19

27 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Bug ID: 20000 Summary: use Modern::Perl in installer perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com use Modern::Perl should be used instead of use strict; use warnings; Relevant in: data/mysql/backfill_statistics.pl data/mysql/labels_upgrade.pl data/mysql/patroncards_upgrade.pl data/mysql/update22to30.pl data/mysql/updatedatabase.pl externalmodules.pl html-template-to-template-toolkit.pl install.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 38

[Bug 22989] New: Independent branches should not show duplicate patron from another library
by bugzilla-daemon＠bugs.koha-community.org 27 May '19

27 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22989 Bug ID: 22989 Summary: Independent branches should not show duplicate patron from another library Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: rbit(a)rbit.cz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Target Milestone: --- Steps to reproduce: 1) set independent branches and create two branches FOO and BAR 2) create a patron John Doe in FOO, save him 3) login as non-super librarian into BAR 3) create a patron John Doe in BAR, try to save him 4) yellow message box "Duplicate patron record?" 5) click on "view existing record" 6) a window pops-up displaying patron data from FOO library, but this is incorrect for independent branches (it breaks GDPR rules), because only John Doe from the same library can be offered to view. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 15221] SIP server always sets the alert flag when item not returned
by bugzilla-daemon＠bugs.koha-community.org 27 May '19

27 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 --- Comment #13 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- RM: Only last follow-up -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15221] SIP server always sets the alert flag when item not returned
by bugzilla-daemon＠bugs.koha-community.org 27 May '19

27 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15221] SIP server always sets the alert flag when item not returned
by bugzilla-daemon＠bugs.koha-community.org 27 May '19

27 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15221] SIP server always sets the alert flag when item not returned
by bugzilla-daemon＠bugs.koha-community.org 27 May '19

27 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15221] SIP server always sets the alert flag when item not returned
by bugzilla-daemon＠bugs.koha-community.org 27 May '19

27 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15221] SIP server always sets the alert flag when item not returned
by bugzilla-daemon＠bugs.koha-community.org 27 May '19

27 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 --- Comment #12 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 90112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90112&action=ed… Bug 15221: (QA follow-up) Fix Message.t As Jonathan reported on comment11, SIP/Message.t fails now. This is a trivial fix for that. In the first case we should just no longer expect the alert flag. In the second case it makes more sense to toggle the value of the checked_in_ok setting. Test plan: Run t/db_dependent/SIP/Message.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0