May 2019 - Koha-bugs - lists.koha-community.org

[Bug 15221] SIP server always sets the alert flag when item not returned
by bugzilla-daemon＠bugs.koha-community.org 23 May '19

23 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15221] SIP server always sets the alert flag when item not returned
by bugzilla-daemon＠bugs.koha-community.org 23 May '19

23 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 --- Comment #9 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 90015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90015&action=ed… Bug 15221: SIP server always sets the alert flag when item not returned The checked in response from the ACS always has the alert bit set to true, even when using the checked_in_ok option. This patch sets the alert bit to 0 when checked_in_ok is used and the item is checked in without a preceding checkout. To test: 0) Create patron in web interface with a cardnumber and userid of "staff" with a password that matches the account in SIPconfig.xml. Also set their branch to CPL (also matching SIPconfig.xml). 1) Create an item with a barcode of 'test' 2) Choose a patron to check out to and record their borrowernumber In one terminal: 3) cd to your git directory (e.g. /home/koha/koha) 4) perl ./C4/SIP/SIPServer.pm ~/koha-dev/etc/SIPconfig.xml In another terminal: 5) cd to your git directory (e.g. /home/koha/koha) 6) perl ./misc/sip_cli_emulator.pl -l CPL -su staff -sp <password> --port=6001 --address=localhost --item test -m checkin --patron <borrowernumber> NOTE: You need to replace <borrowernumber> with the borrowernumber from Step 2, and <password> with the password from Step 0. Before patch: koha@9ec653ab82ce:~/koha$ perl ./misc/sip_cli_emulator.pl -l CPL -su staff -sp <password> --port=6001 --address=localhost --item test -m checkin --patron <borrowernumber> Attempting socket connection to localhost:6001...connected! SEND: 9300CNstaff|COStaff1|CPCPL| READ: 941 Trying 'checkin' SEND: 09N20190521 00310320190521 003103APCPL|AOCPL|ABtest|AC<password>|BIN| READ: 101YNY20190521 003106AOCPL|ABtest|AQCPL|AJTest| After patch: koha@9ec653ab82ce:~/koha$ perl ./misc/sip_cli_emulator.pl -l CPL -su staff -sp <password> --port=6001 --address=localhost --item test -m checkin --patron <borrowernumber> Attempting socket connection to localhost:6001...connected! SEND: 9300CNstaff|CO<password>|CPCPL| READ: 941 Trying 'checkin' SEND: 09N20190521 01000020190521 010000APCPL|AOCPL|ABtest|AC<password>|BIN| READ: 101YNN20190521 010004AOCPL|ABtest|AQCPL|AJTest| Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12733] Interactive inventory tool
by bugzilla-daemon＠bugs.koha-community.org 23 May '19

23 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12733 Devinim <kohadevinim(a)devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Seeking cosponsors -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12733] Interactive inventory tool
by bugzilla-daemon＠bugs.koha-community.org 23 May '19

23 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12733 Devinim <kohadevinim(a)devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kohadevinim(a)devinim.com.tr -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13094] Make it easy to hide 'Cancel all' button on holds over report
by bugzilla-daemon＠bugs.koha-community.org 23 May '19

23 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13094 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89969|0 |1 is obsolete| | --- Comment #7 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 90008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90008&action=ed… Bug 13094: Make it easy to hide 'Cancel all' button on holds over report This patch makes some small modifications to the 'Holds awaiting pickup' report: - Fixes typo sypref - Fixes 'Home branch' to 'Home library' - Adds a span to easily hide the cancel all button with CSS To test: - Make sure you have a hold appearing on the awaiting pickup list second tab: Holds waiting over... - Verify the 'cancel all' button on top shows - Verify syspref and Home library changes mentioned above - Add #holdsover-cancel-all { display:none; } to IntrentUserCSS - Verify that the button and the text have vanished Note: If the text doesn't display next to the button, try toggling the TransferWhenCancelAllWaitingHolds system preference. Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13094] Make it easy to hide 'Cancel all' button on holds over report
by bugzilla-daemon＠bugs.koha-community.org 23 May '19

23 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13094 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15221] SIP server always sets the alert flag when item not returned
by bugzilla-daemon＠bugs.koha-community.org 23 May '19

23 May '19

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 23 May '19

23 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #20 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Victor Grousset/tuxayo from comment #19) > Hi :), I tried to test https://github.com/pianohacker/koha => branch > bz15522-withdeps > > As it is, before trying to rebase it on master. Please do not do that. See the related bug reports, I am on it already. You should focus on bugs that are before this one in the dependency tree. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15221] SIP server always sets the alert flag when item not returned
by bugzilla-daemon＠bugs.koha-community.org 22 May '19

22 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89928|0 |1 is obsolete| | --- Comment #8 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 89970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89970&action=ed… Bug 15221: SIP server always sets the alert flag when item not returned The checked in response from the ACS always has the alert bit set to true, even when using the checked_in_ok option. This patch sets the alert bit to 0 when checked_in_ok is used and the item is checked in without a preceding checkout. To test: 0) Create patron in web interface with a cardnumber and userid of "staff" with a password that matches the account in SIPconfig.xml. Also set their branch to CPL (also matching SIPconfig.xml). 1) Create an item with a barcode of 'test' 2) Choose a patron to check out to and record their borrowernumber In one terminal: 3) cd to your git directory (e.g. /home/koha/koha) 4) perl ./C4/SIP/SIPServer.pm ~/koha-dev/etc/SIPconfig.xml In another terminal: 5) cd to your git directory (e.g. /home/koha/koha) 6) perl ./misc/sip_cli_emulator.pl -l CPL -su staff -sp <password> --port=6001 --address=localhost --item test -m checkin --patron <borrowernumber> NOTE: You need to replace <borrowernumber> with the borrowernumber from Step 2, and <password> with the password from Step 0. Before patch: koha@9ec653ab82ce:~/koha$ perl ./misc/sip_cli_emulator.pl -l CPL -su staff -sp <password> --port=6001 --address=localhost --item test -m checkin --patron <borrowernumber> Attempting socket connection to localhost:6001...connected! SEND: 9300CNstaff|COStaff1|CPCPL| READ: 941 Trying 'checkin' SEND: 09N20190521 00310320190521 003103APCPL|AOCPL|ABtest|AC<password>|BIN| READ: 101YNY20190521 003106AOCPL|ABtest|AQCPL|AJTest| After patch: koha@9ec653ab82ce:~/koha$ perl ./misc/sip_cli_emulator.pl -l CPL -su staff -sp <password> --port=6001 --address=localhost --item test -m checkin --patron <borrowernumber> Attempting socket connection to localhost:6001...connected! SEND: 9300CNstaff|CO<password>|CPCPL| READ: 941 Trying 'checkin' SEND: 09N20190521 01000020190521 010000APCPL|AOCPL|ABtest|AC<password>|BIN| READ: 101YNN20190521 010004AOCPL|ABtest|AQCPL|AJTest| Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15221] SIP server always sets the alert flag when item not returned
by bugzilla-daemon＠bugs.koha-community.org 22 May '19

22 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0