June 2019 - Koha-bugs - lists.koha-community.org

[Bug 5287] Add floating toolbar to search results in OPAC
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '19

17 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90513|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 90700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90700&action=ed… Bug 5287: Add floating toolbar to search results in OPAC This patch adds the "hc-sticky" JavaScript library to the OPAC and uses it to make the search results toolbar "stick" to the top of the page as the user scrolls down. This patch also moves search results pagination into the toolbar so that pagination links are available. Font Awesome icons are added to the pagination include to replace arrow HTML entities. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staf…) - Perform a catalog search in the OPAC which will return multiple pages of results. Confirm that the toolbar "sticks" and that all controls in the toolbar work correctly. - Test at various browser widths to confirm that it adapt well to various sizes. Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5287] Add floating toolbar to search results in OPAC
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '19

17 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level)
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '19

17 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23133 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 [Bug 23133] Rename reserves.item_level_hold for reserves.item_level -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level)
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '19

17 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |nick(a)bywatersolutions.com Keywords| |additional_work_needed CC| |tomascohen(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level)
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '19

17 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 --- Comment #18 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 90677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90677&action=ed… Bug 9834: (QA follow-up) API fixes Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level)
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '19

17 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 --- Comment #17 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Comment on attachment 90611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90611 Bug 9834: Add DB changes >+ `item_level_hold` BOOLEAN NOT NULL DEFAULT 0, -- Is the hpld placed at item level Please see https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL12:_Booleans This is missing a tweak to hold.json and to the schema files. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '19

17 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #163 from David Gustafsson <glasklas(a)gmail.com> --- Also did a pod change in C4/Biblio.pm without the output so need also to do that. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '19

17 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion --- Comment #162 from David Gustafsson <glasklas(a)gmail.com> --- Fixed most of the issues, rebased and squashed into one commit as things were getting a little bit messy. There are still some things that might need fixing for example I'm not sure if the marc rule presets are translatable as they are defined as js-data. I haven't used the translation tools myself but will try to figure this out. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '19

17 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90668|0 |1 is obsolete| | --- Comment #161 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 90672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90672&action=ed… Bug 14957: Merge rules system for merging of MARC records Add a rule based system for merging MARC records to for example prevent field data from being overwritten. To test: 1. Apply this patch. 2. Log in to staff client. 3. Enable new syspref MARCMergeRules. 4. Click the new link "MARC merge rules" in the "Catalog" section of the Koha administration page. 5. Create a new rule: Module: source, Filter: *, Tag: 245, Preset: Protect. 6. Clicking "Edit" should allow you to edit corresponding rule. 7. Clicking "Delete" should remove corresponding rule after confirmation. 8. Selecting one or more rules followed by clicking "Delete selected" should remove all selected rules after confirmation. 9. Try creating a rule with tag set to "**", the other options does not matter. Verify that saving this rule produces an error message complaining about invalid tag regular expression. 10. Try creating a rule with tag set to "008" (or other control field) and set Appended: Append and Removed: Skip, the other options does not matter. Verify that saving this rule produces an error message complaining about invalid combination of actions for control field. 11. With the 245 rule in step 5 in place, edit a bibliographic record, change 245a for example (which should be Title for MARC21) and save. 12. Verify that the changes has not been saved. 13. Create a new rule: Module: source, Filter: intranet, Tag: 245, Preset: Overwrite. 14. Repeat step 12, and verify that the changes has now been saved. 15. Run tests in t/db_dependent/Biblio/MarcMergeRules.t and very that all tests pass. Sponsored-by: Halland County Library Sponsored-by: Catalyst IT Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '19

17 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90669|0 |1 is obsolete| | --- Comment #160 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 90671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90671&action=ed… Bug 14957: DO NOT PUSH Schema changes -- You are receiving this mail because: You are watching all bug changes.

1 0