August 2019 - Koha-bugs - lists.koha-community.org

[Bug 21746] New: Remove NO_LIBRARY_SET
by bugzilla-daemon＠bugs.koha-community.org 16 Jun '20

16 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Bug ID: 21746 Summary: Remove NO_LIBRARY_SET Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 20489 NO_LIBRARY_SET was used when the DB user was logged in. Since bug 20489 it's not longer possible. We could remove the code. We also have 2 TT variables: LoginBranchcode, LoginBranchname And 1 template method, Branches.GetLoggedInBranchcode. We could simplify and unify that code Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 [Bug 20489] Prevent DB user login -- You are receiving this mail because: You are watching all bug changes.

1 23

[Bug 21137] New: Remplace BORROWER_INFO and USER_INFO with logged_in_user
by bugzilla-daemon＠bugs.koha-community.org 16 Jun '20

16 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137 Bug ID: 21137 Summary: Remplace BORROWER_INFO and USER_INFO with logged_in_user Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 18403 We now have a Koha::Patron object sent to the templates, logged_in_user. It must be used everywhere patron's info are needed. BORROWER_INFO and USER_INFO can be replaced using it. See commit d2f2590c894efca417112795e05248dbd16636f5 Bug 18403: Send logged_in_user to template from C4::Auth Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are watching all bug changes.

1 27

[Bug 23151] New: Patron self modification sends null dateofbirth
by bugzilla-daemon＠bugs.koha-community.org 16 Jun '20

16 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Bug ID: 23151 Summary: Patron self modification sends null dateofbirth Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- To Test: - confirm OPACPatronDetails is set to Allow - log into opac - submit change request without changing date of birth - look at change request on staff, see that request includes removal of date of birth I've confirm this bug occurs regardless of whether or not dateofbirth is included in either PatronSelfRegistrationBorrowerMandatoryField or BorrowerUnwantedField. Bug exists in 18.11.06 but not in 18.11.05 -- You are receiving this mail because: You are watching all bug changes.

1 71

[Bug 20483] New: Allow users to delete specific borrower history entries, independent of of anonymising data
by bugzilla-daemon＠bugs.koha-community.org 16 Jun '20

16 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20483 Bug ID: 20483 Summary: Allow users to delete specific borrower history entries, independent of of anonymising data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: liz(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org Borrowers should be able to granularly delete or anonymise their own issuing histories. Possibly we should only remove what the item was, not the entire record of the checkout. For example, if someone had issued 10 books in the past, but didn't want "the three little pigs" to turn up in their history anymore, they should be able to delete this. This borrower could either show a statistic of "10 issues" with titles for 9, or we could remove the record of the issue altogether. -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 19833] New: Kill the "biblios"
by bugzilla-daemon＠bugs.koha-community.org 15 Jun '20

15 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19833 Bug ID: 19833 Summary: Kill the "biblios" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org For bibliographic record we use three string variants: - biblio - biblio record - biblliographic record According to our terminology we should always use "bibliographic record", we should modify it in all templates. https://wiki.koha-community.org/wiki/Terminology -- You are receiving this mail because: You are watching all bug changes.

1 72

[Bug 22408] New: Subscription entry form cleanup
by bugzilla-daemon＠bugs.koha-community.org 15 Jun '20

15 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Bug ID: 22408 Summary: Subscription entry form cleanup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Serials Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com Target Milestone: --- Created attachment 85629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85629&action=ed… Screenshot showing the proposed interface I would like to make a number of changes to the subscription entry form - Make the default layout single-column (like patron entry) - Switch the layout to two-column only when testing prediction pattern - Change the style of some buttons and links - Clean up some issues with capitalization and spacing - Make it clearer when form fields are read-only -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 22359] New: Improve usability of 'change calculation' (bug 11373)
by bugzilla-daemon＠bugs.koha-community.org 14 Jun '20

14 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Bug ID: 22359 Summary: Improve usability of 'change calculation' (bug 11373) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Depends on: 11373 Target Milestone: --- There has been some discussion about the usability of the change calcualation feature from bug 11373. Adding a bug to collect comments and suggestions in a central spot in hope that we will be able to improve things prior to the 19.05 release :) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 [Bug 11373] Add "change calculation" feature to the fine payment forms -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 81

[Bug 21086] New: Wrong mock of DateTime->now in tests
by bugzilla-daemon＠bugs.koha-community.org 13 Jun '20

13 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21086 Bug ID: 21086 Summary: Wrong mock of DateTime->now in tests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 20287, 19705 prove t/db_dependent/DecreaseLoanHighHolds.t t/db_dependent/DecreaseLoanHighHolds.t .. 1/17 Can't locate object method "truncate" via package "80" (perhaps you forgot to load "80"?) at /home/vagrant/kohaclone/C4/Circulation.pm line 3497. What is happening: We mock DateTime->now in the script to avoid the date comparaisons to fail on slow servers (see bug 19705). my $now_value = DateTime->now(); my $mocked_datetime = Test::MockModule->new('DateTime'); $mocked_datetime->mock( 'now', sub { return $now_value; } ); Since bug 20287, we have the following calls: Koha::Patron->store => Koha::Patron::Category->get_expiry_date which does: 221 return $date->add( months => $self->enrolmentperiod, end_of_month => 'limit' ); as enrolmentperiod is generated by t::lib::TestBuilder, it can be quite big, and so the date change from one call to the others. The failure is actually coming from the date becoming > 9999, which is not handled correctly, on purpose, by Koha::DateUtils (infinite) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19705 [Bug 19705] DecreaseLoanHighHolds.t is still failing randomly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 [Bug 20287] Move AddMember and ModMember to Koha::Patron -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 18369] New: Broken title link in UNIMARC catalog search results table
by bugzilla-daemon＠bugs.koha-community.org 13 Jun '20

13 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18369 Bug ID: 18369 Summary: Broken title link in UNIMARC catalog search results table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: synapse.ova(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com In staff client, «Search the catalog» returns a table, where biblio title has a broken link (biblionumber is absent), yet other links works good (Holds, Edit Record, Edit items, OPAC view) Steps to Reproduce: In staff client, search the catalog (Cataloging → «Search the catalog» (/cgi-bin/koha/catalogue/search.pl)) Actual Results: Title of the biblio has a link, that doesn't have biblionumber Expected Results: Title of the biblio should have a link with a proper biblionumber at the end Additional Information: Each biblio in the results table is shown by XSL transformation of MARC data. XSL (\intranet-tmpl\prog\en\xslt\UNIMARCslim2intranetResults.xsl) prepares a link, and adds a biblionumber, that it expects to get from controlfield 001. But since this field could be either empty or contain something different than biblionumber (see https://lists.katipo.co.nz/public/koha/2015-September/043652.html) it is better to pass the biblionumber to this script. This script is already receiving sysprefs (that is not according to marcxml standart), so I suggest to pass the biblionumber the same way. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11

[Bug 22969] New: fix biblionumber on 001 in UNIMARC XSLT
by bugzilla-daemon＠bugs.koha-community.org 13 Jun '20

13 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22969 Bug ID: 22969 Summary: fix biblionumber on 001 in UNIMARC XSLT Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- In UNIMARC default configuration the 001 is linked to biblio.biblionumber. In some XSLT files, 090$a is used. This is by default biblioitems.biblionumber so it usually works but it may not be the same and var biblionumber is used to create hyperlinks to record detail page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16