August 2019 - Koha-bugs - lists.koha-community.org

[Bug 22905] New: Edit suggestions - wrong branchcode behavior
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '19

21 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 Bug ID: 22905 Summary: Edit suggestions - wrong branchcode behavior Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 22368 Target Milestone: --- Because of the "Library" filter on the left of the "Suggestions management" screen, there is something wrong happening: 1. Create a suggestion from library A, login from library B 2. Go to Home › Acquisitions › Suggestions management => The suggestion does not appear - OK 3. In the filter on the left, select "all library" => The suggestion appears on the pending tab - KO 4. Select the suggestion and mark is as 'Accepted' => => The suggestion still appears on the pending tab - Failure The log says: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`suggestions`, CONSTRAINT `suggestions_ibfk_branchcode` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE SET NULL ON UPDATE CASCADE) [for Statement "UPDATE `suggestions` SET `accepteddate` = ?, `branchcode` = ?, `currency` = ?, `manageddate` = ?, `price` = ?, `reason` = ?, `suggesteddate` = ?, `total` = ? WHERE ( `suggestionid` = ? )" with ParamValues: 0='2019-05-14T15:48:18', 1="", 2="CAD", 3='2019-05-14T15:48:18', 4="0.00", 5="", 6='2019-05-14T00:00:00', 7="0.00", 8=3] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 [Bug 22368] Table suggestions lacks foreign key constraints -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 30

[Bug 22585] New: CAS login link for staff intranet is double-escaped
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '19

21 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22585 Bug ID: 22585 Summary: CAS login link for staff intranet is double-escaped Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: jrittenh(a)nd.edu QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org Target Milestone: --- Created attachment 87036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87036&action=ed… remove double-escape for CAS URL The return URL that is part of the link to CAS login is double-escaped on the staff login page. This means that %3A%2F%2F is converted to %253A%252F%252F. It appears that this is the same issue as bug 21973 but in the staff intranet template. I have attached an identical patch for the intranet auth.tt file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 21

[Bug 22546] New: MaxFine is not recorded in HEA
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '19

21 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22546 Bug ID: 22546 Summary: MaxFine is not recorded in HEA Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Websites, Mailing Lists, etc Assignee: wizzyrea(a)gmail.com Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- I'm not sure how the whitelist of prefs being sent to HEA was constructed and whether there's anything in place to maintain it :( But, I'd be really interested to see what the usage of the MaxFine preference is in the wild. The code that implements it is somewhat confusing but it's nature and appears to take into account non-fine amounts which I would not have expected. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 23446] New: Fix display issue with serials navigation
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '19

18 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23446 Bug ID: 23446 Summary: Fix display issue with serials navigation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: katrin.fischer(a)bsz-bw.de Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org The serial navigation shows a little stangely on the serial subscription detail page, with one of the menu items having a different display height than the other items. -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 22602] New: OverDrive circulation integration is broken when user is referred to Koha from another site
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '19

17 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 Bug ID: 22602 Summary: OverDrive circulation integration is broken when user is referred to Koha from another site Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- To recreate: 1 - Have a working OverDrive account and setup 2 - Put a link to your koha site on another site and follow the link to open Koha in a new tab.window 3 - Do an overdrive search 4 - Note that copies listed as available are correct, however, all items only have a place hold button The issue is in the code below - if we came from an outside site we cannot access p and we 'return' which never instantiates checkout_popup which is needed for creating the checkout buttons later 87 var checkout_popup = null; 88 $( document ).ready(function() { 89 var p = window.opener; 90 if (p) { 91 try { cb = p.refresh_overdrive_account_details;} 92 catch(err){ return; } //Catch error if opener is not accessible 93 if (cb) { 94 cb(); 95 } else { 96 p.location.reload(); 97 } 98 window.close(); 99 } 100 checkout_popup = $("#overdrive-checkout"); 101 $("#overdrive-login-form").submit(function(e){ 102 e.preventDefault(); 103 $("#overdrive-login").modal('hide'); 104 var ODpassword = $("input[name='ODpassword']").val(); 105 login( ODpassword ); 106 }); 107 }); -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 18710] New: Wrong subfield modified in batch item modification
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '19

17 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18710 Bug ID: 18710 Summary: Wrong subfield modified in batch item modification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: gmcharlt(a)gmail.com Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org In Tools > Batch item modification, one can modify or delete a subfield. When deleting a subfield et modifying another, the wrong subfield gets modified. -- You are receiving this mail because: You are watching all bug changes.

1 35

[Bug 23526] New: Shibboleth login url with query has double encoded '?' %3F
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '19

17 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526 Bug ID: 23526 Summary: Shibboleth login url with query has double encoded '?' %3F Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org In login_shib_url we place an encoded '?' into the login url: 65 if ( $query->query_string() ) { 66 $param = $param . '%3F' . $query->query_string(); 67 } Then in the templates we filter that using the URL filter: <p>If you have a Shibboleth account, please <a href="[% shibbolethLoginUrl | url %]">click here to login</a>.</p> The URL filter turns the % into %25 and the string comes out as https://anykoha.bywatersolutions.com/Shibboleth.sso/Login?target=https://an… This returns a 4040 on successful login -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 11

[Bug 21058] New: Missing class for results_summary spans
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '19

17 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 Bug ID: 21058 Summary: Missing class for results_summary spans Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: david.bourgault(a)inlibro.com Reporter: david.bourgault(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org Some results_summary spans have other CSS class which can be annoying when doing CSS customization. -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 23004] New: Missing authtype filter in auth_finder.pl
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '19

17 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23004 Bug ID: 23004 Summary: Missing authtype filter in auth_finder.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com Target Milestone: --- In cataloguing, the use of tag editor opens authorities finder with a limit on specific authorities type. This limit is missing with Elasticsearch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 23

[Bug 22929] New: Enabling the GDPR_Policy will affect libraries using the SCO module in Koha
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '19

17 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22929 Bug ID: 22929 Summary: Enabling the GDPR_Policy will affect libraries using the SCO module in Koha Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Self checkout Assignee: koha-bugs(a)lists.koha-community.org Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- With the introduction of the sys pref GDPR Policy in 18.11, having this enabled seems to affect the SCO module in Koha- if the library is also using AutoSelfCheckAllowed. If they library as the system preference AutoSelfCheckAllowed set to ALLOW, the consent of GDPR seems to get tangled up in this process. The self-check URL will get directed to /cgi-bin/koha/opac-patron-consent.pl and seem to be stuck. The consent form never appears, and this login will not be successful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16