August 2019 - Koha-bugs - lists.koha-community.org

[Bug 22768] New: Basic MARC editor tab keyboard navigation broekn
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '19

13 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22768 Bug ID: 22768 Summary: Basic MARC editor tab keyboard navigation broekn Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org, testopia(a)bugs.koha-community.org Depends on: 22045 Blocks: 22399 Target Milestone: --- Dobrica's comment from Bug 22045: This bug broke keyboard shortcuts because of following change: --- a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js +++ b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js @@ -31,7 +31,7 @@ $.fn.tabIndex = function () { return $(this).parent().children('div').index(this); }; $.fn.selectTabByID = function (tabID) { - $(this).tabs("option", "active", $(tabID).tabIndex()); + $(this).tabs("option", "active", $( "#" + tabID ).tabIndex()); }; $(document).ready(function() { without modification to calling which also prefix tabID with #, thus creating invalid ##tabID Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 [Bug 22045] Cataloging UX enhancement - Improve access to tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 [Bug 22399] Improve responsive behavior of the basic marc editor -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 23159] New: Reindent addbiblio.tt
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '19

13 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 Bug ID: 23159 Summary: Reindent addbiblio.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 22399 Target Milestone: --- I would like to reindent cataloging/addbiblio.tt: Remove tabs, correct indentation, add some comments to clarify the structure. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 [Bug 22399] Improve responsive behavior of the basic marc editor -- You are receiving this mail because: You are watching all bug changes.

1 28

[Bug 11642] Improve Batch patron deletion and anonymization GUI to make consequences clearer
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '19

13 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642 Lucas Gass <lucas(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas(a)bywatersolutions.com --- Comment #26 from Lucas Gass <lucas(a)bywatersolutions.com> --- backported to 18.11.x for 18.11.09 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '19

13 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #183 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 92183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92183&action=ed… Bug 14570: (QA follow-up) Consistency displaying the list of guarantors Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '19

13 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #182 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 92182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92182&action=ed… Bug 14570: Remove wrong parameter in add_guarantor call This patch just removes an unused parameter. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '19

13 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #181 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 92181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92181&action=ed… Bug 14570: Add error handling to Koha::Patron::Relationship->store This patch adds checks on the values for the 'relationship'. This is done to avoid future problems when migrating relationships from the plain text syspref into (why not) a proper table. And to preserve consistency. There's also catching on possible broken constraints and throwing a new exception Tests are added for both the new exceptions and the changes to Koha::Patron::Relationship. To test: - Apply this patches - Run: $ kshell k$ prove t/Koha/Exceptions.t \ t/db_dependent/Koha/Patron.t \ t/db_dependent/Koha/Patron/Relationship.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '19

13 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #180 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 92180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92180&action=ed… Bug 14570: Add a UNIQUE constraint on guarantor_id+guarantee_id Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '19

13 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92163|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '19

13 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92162|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '19

13 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92161|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0