August 2019 - Koha-bugs - lists.koha-community.org

[Bug 11677] Limit to Only items currently available for loan or reference not working
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '19

13 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92144|0 |1 is obsolete| | --- Comment #31 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 92176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92176&action=ed… Bug 11677: Use zebra not-onloan-count index for availability limit This uses the work from bug 18098 to use the count of not-onloan items to determine availability. It keeps the allrecords,AlwaysMatches='' portion of the query so it still catches records with the tested indexed missing. These shouldn't exist except in the case of missing data, but kept for future use as well as it has no negative impact and minimizes the change made. Note that availability in this sense means not check out and not lost. Transfers, holds, and not for loan statuses should probably have indexes built in the same way as bug 18098 (there are related FIXMEs in the code) This updates the export_records file used for testing - adding three records with a not-onloan-count (999$x) of 1, but marking the item on the third record lost to prevent its return To test: 1 - make sure SearchEngine pref is set to 'Zebra' 2 - Do a search on the OPAC that returns some records 3 - Find a record in those results with more than one 1 item, and checkout 1 leaving 1 (or more) available 4 - Find another record with only 1 item, check that item out 5 - Limit opac search to available items - both records disappear 6 - Apply patch 7 - Restart all the things 8 - Repeat search 9 - First record should show, but no second 10 - Mark other items of first record as lost, return items on second record 11 - Repeat search, first record should not be in results, second should 12 - prove -v t/db_dependent/Search.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11677] Limit to Only items currently available for loan or reference not working
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '19

13 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13552] Add debar option to batch patron modification
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '19

13 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552 --- Comment #13 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13552] Add debar option to batch patron modification
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '19

13 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11677] Limit to Only items currently available for loan or reference not working
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '19

13 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 --- Comment #30 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Tomás Cohen Arazi from comment #29) > (In reply to Katrin Fischer from comment #28) > > Do we have 3 alternate patches here now? > > We have discussed it with Nick, and both our patches return the same > results. That's because lost won't be NULL (itemlost is defined as NOT NULL) > and so there will always be the lost index on records. The same applies to > the not-onloan-count index, which is generated on indexing. Way to test: I forgot to mention that the lost index CAN be absent on a record, when it has no items. But that means it has no items available so it is ok :-D -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11677] Limit to Only items currently available for loan or reference not working
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '19

13 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92154|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11677] Limit to Only items currently available for loan or reference not working
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '19

13 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34431|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11677] Limit to Only items currently available for loan or reference not working
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '19

13 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen(a)gmail.com |nick(a)bywatersolutions.com QA Contact|testopia(a)bugs.koha-communit |tomascohen(a)gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11677] Limit to Only items currently available for loan or reference not working
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '19

13 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED --- Comment #29 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Katrin Fischer from comment #28) > Do we have 3 alternate patches here now? We have discussed it with Nick, and both our patches return the same results. That's because lost won't be NULL (itemlost is defined as NOT NULL) and so there will always be the lost index on records. The same applies to the not-onloan-count index, which is generated on indexing. Way to test: kohadev-koha@180acd7da540:/kohadevbox/koha$ yaz-client unix://var/run/koha/kohadev/bibliosocket Connecting...OK. Sent initrequest. Connection accepted by v3 target. ID : 81 Name : Zebra Information Server/GFS/YAZ Version: 4.2.30 98864b44c654645bc16b2c54f822dc2e45a93031 Options: search present delSet triggerResourceCtrl scan sort extendedServices namedResultSets Elapsed: 0.004222 Z> base biblios Z> querytype ccl2rpn Z> set_cclfile /etc/koha/zebradb/ccl.properties Z> f ( (not-onloan-count,st-numeric,ge = 1) and (lost,st-numeric=0) ) Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 411, setno 1 SearchResult-1: term=1 cnt=411, term=0 cnt=411 records returned: 0 Elapsed: 0.003008 Z> f ( (allrecords,AlwaysMatches='') and (not-onloan-count,st-numeric,ge = 1) and (lost,st-numeric=0) ) Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 411, setno 2 SearchResult-1: term= cnt=436, term=1 cnt=411, term=0 cnt=411 records returned: 0 Elapsed: 0.000761 Z> He's working on fixing the tests ATM. I will obsolete mine and Olli's. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11989] Holds Queue Scheduling
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '19

13 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11989 Sally Healey <sally.healey(a)cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

1 0