August 2019 - Koha-bugs - lists.koha-community.org

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '19

12 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #179 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 92163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92163&action=ed… Bug 14570: (QA follow-up) Consistency displaying the list of guarantors Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '19

12 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #178 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 92162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92162&action=ed… Bug 14570: Remove wrong parameter in add_guarantor call This patch just removes an unused parameter. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '19

12 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #177 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 92161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92161&action=ed… Bug 14570: Add error handling to Koha::Patron->add_guarantor This patch adds checks on the values for the 'relationship'. This is done to avoid future problems when migrating relationships from the plain text syspref into (why not) a proper table. And to preserve consistency. Tests are added for both the new exceptions and the changes to Koha::Patron. To test: - Apply this patches - Run: $ kshell k$ prove t/Koha/Exceptions.t \ t/db_dependent/Koha/Patron.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '19

12 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #176 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 92158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92158&action=ed… Bug 14570: (QA follow-up) Fix issues in Guarantor context -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '19

12 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #175 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Tomás Cohen Arazi from comment #170) > Guarantor context > - I still find it confusing that 'Add child' only shows for 'adult' > categories, so 'board' cannot have a guarantee? This is something already in > Koha, not this bug's responsibility. but worth mentioning. Yep, that's outside the scope of this bug. I think there is another report for that. If not, there should be! > - Shouldn't we rename 'Add child' into 'Add guarantee'? I know this bug is > just about changing a 1-1 relationship into 1-n, but worth considering, even > as a follow-up bug. Related to the previous comment. I think that's simple enough to accomplish in this bug report with a followup. > - 'Cancel' should just be 'Delete', as it shows for already existing > relations, not just the ones being added (a change that can be cancelled). > Maybe have 'Delete' for the current relations, and 'cancel/delete' for the > ones being added. Changed in followup to "Remove" to match the other update from "Delete" to "Remove". -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '19

12 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #174 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Tomás Cohen Arazi from comment #171) > Maybe add > - Koha::Guarantee(s) > - Koha::Guarantor(s) > which provide a ->patron method. Forget about this one, I agree with Jonathan we should simplify this a lot. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '19

12 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #173 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 92157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92157&action=ed… Bug 14570: (QA follow-up) Fix issues in Guarantee context -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21024] New: JS error on search result breaks JS functionalities
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '19

12 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024 Bug ID: 21024 Summary: JS error on search result breaks JS functionalities Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: Staff Client Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Caused by bug 20864, some JS functions defined in commons.js are called by search.pl The JS error is: ReferenceError: resetSearchContext is not defined It breaks add to basket, list, etc. -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 20864] New: Only set bibs_selected cookie when BrowseResultSelection is activated
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '19

12 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 Bug ID: 20864 Summary: Only set bibs_selected cookie when BrowseResultSelection is activated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org The bibs_selected cookie stores the biblionumbers of entries selected in a search result list. At the moment the cookies appears to always be set, even if BrowseResultSelection is set to disabled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 19

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '19

12 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #172 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Tomás Cohen Arazi from comment #170) > Guarantee context > - 'Search' should be 'fa-plus Add' for adding a guarantor. Fixed in followup! > - There's no way to remove a guarantor You need to check the "Remove" checkbox and save the patron ( I renamed it from Delete in this upcoming followup ). > - A guarantor can be added multiple times to the same guarantee (is that a > feature?) Fixed in followup! > - There's no way to set the relationship It can be set at the time you add a guarantor. To edit it you just remove and re-add the same guarantor > - Labels seem to be wrong: 'Organization #' and 'Organization name' Fixed in followup! -- You are receiving this mail because: You are watching all bug changes.

1 0