September 2019 - Koha-bugs - lists.koha-community.org

[Bug 23685] New: Exporting report may consume unlimited memory
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '25

23 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Bug ID: 23685 Summary: Exporting report may consume unlimited memory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: paul(a)flo.org QA Contact: testopia(a)bugs.koha-community.org In guided_reports.pl, when exporting report results ($phase eq 'Export') all rows of data are fetched and then converted to the desired format. This may consume an unlimited amount of memory; when report results are particularly large, it may consume all available memory, leading to timed-out HTTP requests, crashes, and potentially data loss. (We have experienced Zebra index corruption as a result.) In master, reports/guided_reports.pl supports three export types -- tab-delimited, CSV, or *.ods. In each case, all data are loaded into memory and held there before any output is produced: 891 $sql = get_prepped_report( $sql, \@param_names, \@sql_params ); 892 my ($sth, $q_errors) = execute_query($sql); ... 895 if ($format eq 'tab') { 896 $type = 'application/octet-stream'; 897 $content .= join("\t", header_cell_values($sth)) . "\n"; 898 $content = Encode::decode('UTF-8', $content); 899 while (my $row = $sth->fetchrow_arrayref()) { 900 $content .= join("\t", @$row) . "\n"; 901 } 902 } else { 903 my $delimiter = C4::Context->preference('delimiter') || ','; 904 if ( $format eq 'csv' ) { ... 914 while (my $row = $sth->fetchrow_arrayref()) { 915 if ($csv->combine(@$row)) { 916 $content .= $csv->string() . "\n"; 917 } else { 918 push @$q_errors, { combine => $csv->error_diag() } ; 919 } 920 } 921 } 922 elsif ( $format eq 'ods' ) { ... 932 # Other line in Unicode 933 my $sql_rows = $sth->fetchall_arrayref(); 934 foreach my $sql_row ( @$sql_rows ) { 935 my @content_row; 936 foreach my $sql_cell ( @$sql_row ) { 937 push @content_row, Encode::encode( 'UTF8', $sql_cell ); 938 } 939 push @$ods_content, \@content_row; 940 } 941 942 # Process 943 generate_ods($ods_filepath, $ods_content); 944 945 # Output 946 binmode(STDOUT); 947 open $ods_fh, '<', $ods_filepath; 948 $content .= $_ while <$ods_fh>; 949 unlink $ods_filepath; 950 } The *.ods case is particularly problematic, because before any data is sent back to the user's browser, *three* copies of the full results are sitting in memory simultaneously -- @$sql_row, @$ods_content, and $content. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 78

[Bug 21469] New: Add useControlNumberIdentifier preference to allow (003)001 constructions in $w links.
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '25

12 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469 Bug ID: 21469 Summary: Add useControlNumberIdentifier preference to allow (003)001 constructions in $w links. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Whilst working through bug 11175 I was reminded of our inconsistent use of useControlNumber and it's lack of accounting for 003 fields. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 41

[Bug 17217] New: Allow to reserve first available item from a group of titles (OPAC)
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '25

10 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17217 Bug ID: 17217 Summary: Allow to reserve first available item from a group of titles (OPAC) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: julian.maurice(a)biblibre.com Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Depends on: 15516 This bug follows bug 15516. This is the OPAC part Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 [Bug 15516] Allow to reserve first available item from a group of titles -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 23547] New: Add column configuration to course reserves table in the OPAC
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '25

07 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23547 Bug ID: 23547 Summary: Add column configuration to course reserves table in the OPAC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org It would be nice if it was easy to hide columns from the course reserves table in the OPAC (example: hide the Link column because it doesn't contain full text links reliably). -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 18986] New: High Hold Items with Decreased Loan Period Can' t Be Checked-Out with Self-Check
by bugzilla-daemon＠bugs.koha-community.org 03 Jul '25

03 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18986 Bug ID: 18986 Summary: High Hold Items with Decreased Loan Period Can't Be Checked-Out with Self-Check Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: koha-bugs(a)lists.koha-community.org Reporter: cslone(a)camdencountylibrary.org QA Contact: testopia(a)bugs.koha-community.org Scenario: A patron has an item with a high number of holds ready for pickup. They come to their library get the item and use the SCO to try to borrow it. When they scan the item they are given the message: Item cannot be checked out. Sorry, this item cannot be checked out at this station. Please see a member of the library staff. Additionally, if they don’t notice the message and scan another item, they are returned their account summary/the check-out screen with neither item checked out to the patron. At best this creates a scenario where there's an inconvenient extra step that the patron has to take in order to get their item. At worst, it can lead to the patron inadvertently taking two items with them that have not been checked-out. For the item that is on hold this can lead to further confusion when the it is returned (Koha will indicate that the item must go back on the hold shelf for the patron that just returned it) or when holds are cleared from the shelf (the item will be listed there but won’t be found). To replicate: 1.) In system preferences, go to Circulation preferences->Holds Policy. 2.) There are five preferences grouped together for decreaseLoanHighHolds, make sure to set the first drop down to Enable and enter the reduced loan period and the number of holds that will trigger the reduction (you can configure the other options as desired). 3.) Place a hold on an item with a patron you can use at self-check and place enough additional holds on the item with other accounts in order to trigger the decreased loan period according to your preferences. 4.) Check-in an item from the record with the holds and confirm the hold for the patron. 5.) Log into self-check with this patron and attempt to check-out the item. 6.) You will be taken to the error message. 7.) Scan the barcode again, you'll be returned to the SCO screen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 20905] New: Warn from Search.t
by bugzilla-daemon＠bugs.koha-community.org 03 Jul '25

03 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20905 Bug ID: 20905 Summary: Warn from Search.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org Test passes but look at this warn from getRecords: ok 67 - presence of a transit does not block hold request action (bug 10741) ERROR DECODING RECORD - Tag "50%" is not a valid tag. at /usr/share/perl5/MARC /File/USMARC.pm line 223. : 00295nam a22001217a 45000030004000000050017000040080041000211000018000622450 0570008050%001100137942001200148999001300160OSt20111207151138.0111207t xxu||||| |||| 00| 0 eng d aGanser, Helen aA record containing a punctuation character as a tag aa note 2ddccBK c214d214 at /usr/share/koha/devclone/C4/ Search.pm line 683. ok 68 - search for ti:punctuation returned expected number of records A few lines later in the test, a warning_like also looks for this error. -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 18303] New: Release team omnibus
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '25

01 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18303 Bug ID: 18303 Summary: Release team omnibus Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: nengard(a)gmail.com Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 29

[Bug 16559] New: [%% ... %%] should not be picked for translation
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '25

27 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16559 Bug ID: 16559 Summary: [%% ... %%] should not be picked for translation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr Examples in Koha 16.05: %s [%% INCLUDE "openlibrary-readapi.inc" bib = { normalized_isbn => normalized_isbn, lccn => lccn, normalized_oclc => normalized_oclc } %%] %s [%% UNLESS hidden.defined('phone') && hidden.defined('phonepro') && hidden.defined('mobile') && hidden.defined('email') && hidden.defined('emailpro') && hidden.defined('fax') %%] In Pootle, a search for [%% has 40 results -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 19523] New: Koha:: Cache changes not passed to all plack workers with in-memory caching.
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '25

27 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19523 Bug ID: 19523 Summary: Koha::Cache changes not passed to all plack workers with in-memory caching. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org REPRODUCE: - $KOHA_CONF shouldn't have any <memcached_* -definitions. This triggers in-memory cache usage. - plack workers is atleast 2 - Change some easily visible syspref, such as 'languages'. The syspref change applies only to the worker thread where the change was made. Other worker threads keep using the old syspref. - Observer that 50% of time the old syspref is used. Other times the new syspref is used. - Reduce plack workers to 1. Observe no issues with syspref change taking effect. Using memcached solves this problem. It is still useful to fix it for those who don't want to use memcached. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 21670] New: t/db_dependent/Plugins.t is failing randomly on Jenkins (U18)
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '25

24 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21670 Bug ID: 21670 Summary: t/db_dependent/Plugins.t is failing randomly on Jenkins (U18) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org On run #72, Koha_Master_U18 failed: koha_1 | Could not unlink /tmp/xRRc7ht/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm.pm: No such file or directory at /kohadevbox/koha/Koha/Plugins/Handler.pm line 105. koha_1 | koha_1 | # Failed test 'Koha::Plugins::Handler::delete works correctly.' koha_1 | # at t/db_dependent/Plugins.t line 127. koha_1 | # Looks like you failed 1 test of 39. koha_1 | [15:24:05] t/db_dependent/Plugins.t ................................................ koha_1 | Dubious, test returned 1 (wstat 256, 0x100) koha_1 | Failed 1/39 subtests We requested another run and it passes (#73), same node (Docker_3) -- You are receiving this mail because: You are watching all bug changes.

1 25