January 2020 - Koha-bugs - lists.koha-community.org

[Bug 24514] New: Holds Awaiting Pickup sorting by title before surname
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '20

18 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24514 Bug ID: 24514 Summary: Holds Awaiting Pickup sorting by title before surname Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Bug 24024 fixed an error causing Holds Awaiting Pickup to sort by firstname rather than firstname. However, it's now sorting by title, then surname, then firstname. To test: - generate and capture a hold for a patron named "Mr. A A" - generate and capture a hold for a patron named "A A" - generste and capture a hold for patron named "Mr. B B" - generste and capture a hold for patron named "B B" - go to holds awaiting pickup - sort by patron name ascending - holds sort Mr. A, Mr. B, A, B - sort by patron name descending - holds sort B, A, Mr. B, Mr. A -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 18933] New: Unable to set SMS number in OPAC messaging preferences to empty
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '20

18 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18933 Bug ID: 18933 Summary: Unable to set SMS number in OPAC messaging preferences to empty Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org This is inconsistent with the Staff Client side, where the SMS number can be set to empty. Also I think that since this is borrower information, it should be their choice whether they provide this info or not and should have the ability to remove it -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 24388] New: Unless test in acqui/lateorders.tt
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '20

18 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388 Bug ID: 24388 Summary: Unless test in acqui/lateorders.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 24162 The budget_lock is never set (and has never been): [% UNLESS lateorder.budget_lock %] <input type="submit" class="btn btn-default" value="Claim order" /> [% END %] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162 [Bug 24162] Late orders improvements - display new columns -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 24208] New: Remove change calculation for writeoffs
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '20

18 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Bug ID: 24208 Summary: Remove change calculation for writeoffs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: maryse.simard(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org Bug 11373 added change calculation to the payment page. This doesn't work very well when using the "Writeoff selected" button: - The "Amount paid" and "Change to give" fields don't make much sense in the case of writeoffs. - The amount for a partial writeoff has to be entered in the "Amount paid" field instead of the one labeled "Writeoff amount" just underneath. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 24516] New: Column Configuration does not hide Return Date
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '20

18 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516 Bug ID: 24516 Summary: Column Configuration does not hide Return Date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com There are two tables within the Patron module (in column configuration) that work with the Accounting portion of Koha. "Pay Fines" and "Account Fines" - both of these tables present the user with hiding a specific column found in these areas within the Accounting screens, however, attempting to hide "Return Date" in either/both of these tables does not work. To recreate:t 1. Go to Column Configuration. 2. Choose Patrons 3. Choose either Pay Fines or Account Fines table 4. Hide Return Date 5. Save 6. Check on patron's screen - boraccount.pl or pay.pl depending on which or both tables you attempted to hide the return date- see that the return date is still appearing. I have filed another bug similar to this 24515 dealing with these same tables. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 24515] New: Column Configuration for pay-fines-table does not hide Account Type properly
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '20

18 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515 Bug ID: 24515 Summary: Column Configuration for pay-fines-table does not hide Account Type properly Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com In the Patron set of the Column Configuration under Pay-Fines-Table, checking to hide the "account type" field does not hide the "Account Type" in pay.pl. If "Account Type" and "Description" are both chosen, it will hide the "account type" in pay.pl but not the "description". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 24389] New: Claiming an order can display an invalid successful message
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '20

18 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24389 Bug ID: 24389 Summary: Claiming an order can display an invalid successful message Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org If the vendor does not have a valid contact (like no email), a successful message is displayed ("Email has been sent.") whereas nothing was done! -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 18230] New: Generate Koha::Patron:: Modification verification_token in ->new
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '20

18 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18230 Bug ID: 18230 Summary: Generate Koha::Patron::Modification verification_token in ->new Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: lari.taskula(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org Currently verification_token is generated outside of the class. Move this logic into Koha::Patron::Modification->new. -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 17424] New: REST API: Preference to control access to own objects without permission
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '20

18 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17424 Bug ID: 17424 Summary: REST API: Preference to control access to own objects without permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs(a)lists.koha-community.org Reporter: lari.taskula(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org Introduce a preference to enable/disable access to own objects for patron's without required permissions. Bug 14868 added "allow-owner" parameter that allows owner of the object to perform operations on themselves even if they do not have required permissions to otherwise do so (e.g. get own patron data or renew your own checkouts even if you don't have borrowers/circulating permissions). This means patrons can perform basic OPAC operations via REST API. However, there should be an option to disable this functionality; as Katrin pointed out in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895#c43 , > I can imagine both happening: > - libraries wanting to shut down any OPAC account functionality, but still > be able to renew in staff, so the circulation conditions are set up this > way. In this case, there should be a way to lock the API (opacuserlogin > might be a way) > - libraries shutting down the OPAC, because they use something else like an > external discovery layer. In this case they'd still want to use the API, but > might turn off the OPAC as far as possible. I propose a system preference for enabling/disabling access to own objects in REST API. This way libraries can disable opacuserlogin and any OPAC API functionality with the new preference. In the second case, libraries can disable opacuserlogin but still allow OPAC functionality via REST API. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 17479] New: REST API: Save information on owner access
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '20

18 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17479 Bug ID: 17479 Summary: REST API: Save information on owner access Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs(a)lists.koha-community.org Reporter: lari.taskula(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org There are two ways of accessing a resource via REST API; either: - you have the required permission - you do not have the permission but you are owner of the object, e.g. you want to GET your own patron information In many cases we want to perform additional operations if the user is accessing his own object. Usually this additional operation is checking a system preference. Example: Patron wants to update his own patron information via REST API. We have to check OPACPatronDetails system preference for this. If it is on, we should forward the changes for approval from a librarian. Currently, in controller, we can check this opac-like access by checking that the user does not have permissions and that the patron he is accessing is himself. This would require another haspermission() call. Instead, we could set a flag into $c->stash in Koha/REST/V1.pm in the case of ownership access. After this, in controller, we only need to check $c->stash for this flag. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 22