November 2020 - Koha-bugs - lists.koha-community.org

[Bug 25695] New: Missing logging of $@ in onboarding.pl after eval block
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25695 Bug ID: 25695 Summary: Missing logging of $@ in onboarding.pl after eval block Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: slavashishkin(a)gmail.com Reporter: slavashishkin(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, nugged(a)gmail.com, stalkernoid(a)gmail.com There is a forgotten warning in the second eval block just after the same eval block which has warning. This makes the error reason not logged. The solution is to add exactly the same ‘warn $@’ in consecutive eval block. -- You are receiving this mail because: You are watching all bug changes.

1 21

[Bug 25993] New: SIP2 server logs polluted with warnings about uninitialized value $key
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25993 Bug ID: 25993 Summary: SIP2 server logs polluted with warnings about uninitialized value $key Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: joonas.kylmala(a)helsinki.fi QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com, kyle(a)bywatersolutions.com Depends on: 20954 Changes from bug 20954 introduced the following warning in SIP2 server logs: > Use of uninitialized value $key in index at /kohadevbox/koha/C4/SIP/Sip/MsgType.pm line 337, <STDIN> line 2. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20954 [Bug 20954] Add ability to set syspref overrides in SIP as we can in Apache -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 6

[Bug 26590] New: Koha::Patron::is_valid_age gives warning about $low variable's numeric comparison
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26590 Bug ID: 26590 Summary: Koha::Patron::is_valid_age gives warning about $low variable's numeric comparison Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: joonas.kylmala(a)helsinki.fi QA Contact: testopia(a)bugs.koha-community.org I get the following warning message in plack-error.log: > Use of uninitialized value $low in numeric lt (<) at /usr/share/koha/lib/Koha/Patron.pm line 1109. This seems to happen because in /cgi-bin/koha/admin/categories.pl you can set "Age required" field to be empty and then in the is_valid_age subroutine in Patron.pm we compare patroncategory->dateofbirthrequired to numeric value and empty string or undef is not numeric. We should either add input validation to categories.pl or convert dateofbirthrequired to numeric value. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 27010] New: Warnings produced by Elasticsearch QueryBuilder.pm
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27010 Bug ID: 27010 Summary: Warnings produced by Elasticsearch QueryBuilder.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: joonas.kylmala(a)helsinki.fi In Koha/SearchEngine/Elasticsearch/QueryBuilder.pm we get following warnings: > [WARN] Use of uninitialized value $f in hash element at /usr/share/koha/lib/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 605. > [WARN] Use of uninitialized value $d in hash element at /usr/share/koha/lib/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 605. This seems to be due to _convert_sort_fields() not checking whether my ( $f, $d ) get initialized by the regex before using them in the map function: > 601 grep { $_->{field} } map { > 602 my ( $f, $d ) = /(.+)_(.+)/; > 603 { > 604 field => $sort_field_convert{$f}, > 605 direction => $sort_order_convert{$d} > 606 } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 27011] New: Warnings in returns.pl
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27011 Bug ID: 27011 Summary: Warnings in returns.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: joonas.kylmala(a)helsinki.fi QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When you check-in some books you get the following warnings to error logs: > [WARN] Use of uninitialized value in concatenation (.) or string at /usr/share/koha/intranet/cgi-bin/circ/returns.pl line 164. > [WARN] Use of uninitialized value in concatenation (.) or string at /usr/share/koha/intranet/cgi-bin/circ/returns.pl line 402. This seems to be due to treating the patron fields as non-null values: > 164 my $name = $patron ? $patron->surname . ", " . $patron->title . " " . $patron->firstname : ''; The DB schema allows NULL values (and I think that is okay) so we should check for every one of these whether the value is defined or not before using it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 25

[Bug 23349] New: Merge records from a search result (catalog/search.pl)
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Bug ID: 23349 Summary: Merge records from a search result (catalog/search.pl) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: marjorie.barry-vila(a)collecto.ca QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Hi, It would be interesting to be able to merge records from a list of results (catalogue/search.pl). The search results in cataloguing/addbooks.pl, where you can merge records, does not filter by document type or other status. Regards Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 29

[Bug 25128] New: Date sorting on claims returned table doesn't work
by bugzilla-daemon＠bugs.koha-community.org 16 May '22

16 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25128 Bug ID: 25128 Summary: Date sorting on claims returned table doesn't work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Depends on: 14697 The date columns in the claim returns table don't sort correctly. There is also a display issue, see bug 25023. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 [Bug 14697] Extend and enhance "Claims returned" lost status -- You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 26378] New: Show SerialIssueDisplayCount syspref values in subscription-add.pl
by bugzilla-daemon＠bugs.koha-community.org 12 May '22

12 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26378 Bug ID: 26378 Summary: Show SerialIssueDisplayCount syspref values in subscription-add.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com When setting up a new subscription, one can set values for "Number of issues to display to staff" and "Number of issues to display to the public." If you don't set these in a specific subscription, then they fall back to the values in the system preferences StaffSerialIssueDisplayCount and OPACSerialIssueDisplayCount, respectively. It'd be good to add a note along the lines of "If unset, will default to the value in StaffSerialIssueDisplayCount (X)," where X is the value from the syspref. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 25705] New: Viewing all serials issues should not require serials permissions
by bugzilla-daemon＠bugs.koha-community.org 12 May '22

12 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25705 Bug ID: 25705 Summary: Viewing all serials issues should not require serials permissions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com On the "/cgi-bin/koha/opac-detail.pl?biblionumber=X" page, there is a link "More Details" (/cgi-bin/koha/opac-serial-issues.pl?biblionumber=X), which shows the "Full subscription history" (ie received issues) for a subscription for a bib record. The Staff Client does not have an equivalent. The "/cgi-bin/koha/catalogue/detail.pl?biblionumber=X" page has a "Subscription details" (/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=X) link, but that requires full Serials permissions. Plus, it's not really equivalent. The closest equivalent is "/cgi-bin/koha/serials/serials-collection.pl?subscriptionid=X", but it also requires full Serials module permissions. It does not make sense that an OPAC user can see more data than a Staff Client user. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 5

[Bug 20103] New: Remove Readonly::XS
by bugzilla-daemon＠bugs.koha-community.org 12 May '22

12 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103 Bug ID: 20103 Summary: Remove Readonly::XS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: mtompset(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com >From the Readonly CPAN page: "Install this module, but do not use it. ... Programs that you write do not need to know whether Readonly::XS is installed or not. They should just "use Readonly" and let Readonly worry about whether or not it can use XS. If the Readonly::XS is present, Readonly will be faster. If not, it won't. Either way, it will still work, and your code will not have to change." This removes the Readonly::XS from the PerlDependencies. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 26