November 2020 - Koha-bugs - lists.koha-community.org

[Bug 27034] New: $c->objects->search shouldn't use path parameters
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27034 Bug ID: 27034 Summary: $c->objects->search shouldn't use path parameters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com The objects.search Mojolicious helper incorrectly adds path parameters to the query for filtering. This works, trivially for plat routes like: GET /patrons/:patron_id or for routes that really have links like (fictional example): GET /patrons/:patron_id/holds In the latter, we already know there's a link borrowers<->reserves so searching holds and filtering by the borrowernumber will work. About this there are two things to consider: - That's not how we are coding, we are actually picking the patron_id manually and using object methods to access the resultset: my $patron = Koha::Patrons->find( $c->validation->param('patron_id') ); ... my $holds_rs = $patron->holds; my $holds = $c->objects->search({ resultset => $holds_rs }); - If we have more tricky examples like: GET /holds/:hold_id/pickup_locations it is obvious that hold_id doesn't make any sense for Koha::Libraries, so filtering on it actually causes an exception. One option is to manually remove the problematic path parameters in the controller: my $hold_id = $c->validation->param('hold_id'); my $hold = Koha::Holds->find( $hold_id ); delete $c->validation->output->{'hold_id'}; my $pickup_locations_rs = $hold->pickup_locations; my $pickup_locations = $c->objects->search( $pickup_locations_rs ); My feeling is that we should be following the current pattern, and not really use the path parameters in objects.search. If we later need some handling in the generic objects->search helper, we can reintroduce it, but we need a real use case, which cannot be found in the codebase yet. It all points towards not needing them there, and just getting in the middle with no gain (just the opposite). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 23

[Bug 24810] New: French SQL files for "news" contain "Welcome into Koha 3!"
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24810 Bug ID: 24810 Summary: French SQL files for "news" contain "Welcome into Koha 3!" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com installer/data/mysql/fr-CA/facultatif/sample_news.sql installer/data/mysql/fr-FR/2-Optionel/sample_news.sql -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 24811] New: French SQL files for "news" contain broken link to the wiki
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24811 Bug ID: 24811 Summary: French SQL files for "news" contain broken link to the wiki Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com installer/data/mysql/fr-CA/facultatif/sample_news.sql installer/data/mysql/fr-FR/2-Optionel/sample_news.sql http://wiki.koha-community.org/doku.php?id=en:development:git_usage returns 404 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 26578] New: OverDrive results can return false positives when searches contain CCL syntax
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26578 Bug ID: 26578 Summary: OverDrive results can return false positives when searches contain CCL syntax Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org This problem is from the ':' and '=' signs, along with field codes, that can be passed to overdrive when forming queries or clicking links. Depending on the overdrive catalog, these can match records causing inaccurate results To recreate: 1 - Have OverDrive enabled and configured 2 - set UseAuthoritiesForTracings to "Don't use" 3 - Search in the catalog for a record 4 - From the details page for a record click on an author link 5 - Note the query in catalog is like 'au:"Whitford, Bradley."' 6 - Some overdrive catalogs will return records matching 'au:' -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 26634] New: Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Bug ID: 26634 Summary: Hold rules applied incorrectly when All Libraries rules are more specific than branch rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com To recreate: - At the All Libraries level, create a circ rule for a specific patron category and a specific item type that only allows 1 hold - At the branch-specific level for Branch A, create an All/All rule that allows 2 holds - confirm ReservesControll is set to patron's library - find a patron from Branch A of the category for which you made your rule - find two bibs with items of the itype got which you made your rule - place a hold on one bib. success! - try to place a hold on the second bib. you're told you cannot because the patron is only allowed 1 hold We should be enforcing the All/All rule for Branch A. If we put in a rule for the category and itype for Branch A, that rule will be enforced and we'll be allowed a second hold. In GetHoldRule, we tell get_effective_rules to return those rules ordered by 'categorycode', 'itemtype', 'branchcode.' We should just let get_effective_rule handle that ordering on its own. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 36

[Bug 26755] New: Make the guarantor search popup taller
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26755 Bug ID: 26755 Summary: Make the guarantor search popup taller Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: barbara.johnson(a)bedfordtx.gov QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Created attachment 112042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112042&action=e… Current popup window When searching for a guarantor to add to a guarantee you can't see the search results in the the popup search window (guarantor_search.pl) without scrolling. Although the popup window shouldn't be too tall it would be helpful to display at least the first one or two entries which could eliminate extra scrolling and allow staff to select the record more efficiently. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 27047] New: Purchase suggestions can not search
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27047 Bug ID: 27047 Summary: Purchase suggestions can not search Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: apirak(a)punsarn.asia QA Contact: testopia(a)bugs.koha-community.org test plan: [1] Log in to Opac [2] Go to your purchase suggestions menu [3] Create purchase suggestions Ex. "title: harry potter" [4] Go to purchase suggestions menu [5] Type "harry potter" In <search for> field [6] The search result is not show only "harry potter" but show all purchase suggestions list. -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 20702] New: Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20702 Bug ID: 20702 Summary: Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org As a follow-up of bug 20697 restricting the call to GetAnalyticsCount when the preference is enabled, and resolving an associated Zebra error. GetHostItemsInfo is part of the easy analytics feature from bug 5528. We can either bind all calls of this sub to the preference, or return an empty list when the pref is disabled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 26

[Bug 24222] New: Simplify interface for adding/changing mappings
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24222 Bug ID: 24222 Summary: Simplify interface for adding/changing mappings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: mkstephens(a)lancasterseminary.edu All search fields are in a single group and are not marked as being strictly for authorities or bibliographic records. On the search engine configuration page, when adding mappings to either the bibliographic records tab or the authorities tab, all search fields are available from the drop down menu at the bottom of the page. It would be really nice if there was a way to distinguish between the two groups of search fields so that these drop down menus would only show the fields for that record type. An alternative might be to reconfigure the way this page displays. Show the tables in a collapsed view based on search field. Expand a search field to see its mappings along with an empty field with "+ Add". This solution would allow a user to add mappings under the appropriate search field without having to manually select the field from a drop down.This would also make it easier to double-check to make sure you're entering the correct mapping since you'd be entering it in context, instead of at the bottom of a long list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 24894] New: Allow configuration of search dropdowns
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24894 Bug ID: 24894 Summary: Allow configuration of search dropdowns Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Currently, we can customize the indices included in the basic and advances search dropdowns via jQuery. It'd be great to have some more user-friendly interface for this. It might make sense to tie it into the Elastic search engine config page, or to make it its own system preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4