November 2020 - Koha-bugs - lists.koha-community.org

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '20

03 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #123 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- I didn't realize the follow-ups here removed those git merge conflict resolution hints. It would still probably be better if the conflicts were solved in the patches they happen. If I review the patch "Test improvements + check maxreserves" it contains merge resolution and test improvements, so two things, git commits should do just one thing. Also "Bug 11999: (QA follow-up)" doesn't say what it does. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '20

03 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |joonas.kylmala(a)helsinki.fi --- Comment #122 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- The attached patch contains git merge conflict resolution hints. Also, if I understand correctly maxreserves is already checked in some other places in some other way, it would be really good idea to have a patch then to convert those calls to just use CanBookBeReserved(). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '20

03 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #20 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Cook from comment #17) > Actually, we have a customization that does something like this patch, and > it actually causes the problem to be worse. > > If you set the idx element value to '', the idx select elements don't get > sent, but the empty q input elements do. So you wind up with a mismatched > number of parameters. This isn't true *if* you provide an option in the select list with a value of ''. So adding that option element in the list would help, if we want to use the Javascript in the patches. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '20

03 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #19 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Cook from comment #18) > And if people are worried about ugly URLs, then I think they should open a > new bug report to remove unused search boxes in advanced search from the DOM > so they don't get submitted with the HTML form. Alternatively, we could only show 1 search box on the advanced search page, and make people add more search boxes as needed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '20

03 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #18 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Jonathan Druart from comment #16) > If we have the change from bug 25548, this issue will get fixed. I agree. Bug 25548 would resolve Bug 7607. And if people are worried about ugly URLs, then I think they should open a new bug report to remove unused search boxes in advanced search from the DOM so they don't get submitted with the HTML form. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '20

03 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au Status|BLOCKED |Failed QA --- Comment #17 from David Cook <dcook(a)prosentient.com.au> --- Actually, we have a customization that does something like this patch, and it actually causes the problem to be worse. If you set the idx element value to '', the idx select elements don't get sent, but the empty q input elements do. So you wind up with a mismatched number of parameters. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 26683] New: Fix Modules::RequireFilenameMatchesPackage Perl Critic Violations
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '20

02 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683 Bug ID: 26683 Summary: Fix Modules::RequireFilenameMatchesPackage Perl Critic Violations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org Both ./C4/Barcodes/ValueBuilder.pm and ./Koha/Z3950Responder/RPN.pm violate the Perl Critic policy of Modules::RequireFilenameMatchesPackage. You can read more about it at https://metacpan.org/pod/Perl::Critic::Policy::Modules::RequireFilenameMatc… The failures look like this: FAIL C4/Barcodes/ValueBuilder.pm FAIL critic # Modules::RequireFilenameMatchesPackage: Got 1 violation(s). FAIL Koha/Z3950Responder/RPN.pm FAIL critic # Modules::RequireFilenameMatchesPackage: Got 1 violation(s). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 10

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '20

02 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112873|0 |1 is obsolete| | --- Comment #121 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- Created attachment 112874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112874&action=e… Bug 11999: (QA follow-up) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '20

02 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #120 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- Thanks david :) Patch did no longer apply because one of my other patch actually got into master, hurray! \o/ Re-posted all patches. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '20

02 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #119 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- Created attachment 112873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112873&action=e… Bug 11999: (QA follow-up) -- You are receiving this mail because: You are watching all bug changes.

1 0