November 2020 - Koha-bugs - lists.koha-community.org

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '20

02 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #118 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- Created attachment 112872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112872&action=e… Bug 11999: Test improvements + check maxreserves improve t/db_dependent/Reserves.t to make tests pass on UNIMARC installation -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '20

02 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111687|0 |1 is obsolete| | Attachment #111688|0 |1 is obsolete| | Attachment #111689|0 |1 is obsolete| | --- Comment #117 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- Created attachment 112871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112871&action=e… Bug 11999: Add maxreserves check in CanBookBeReserved and CanItemBeReserved - Check if borrower has reached the maximum number of holds allowed (syspref maxreserves) The goal of this patch is to do these checks also when using ILS-DI services HoldTitle and HoldItem Test plan: ---------- Before patch: 1/ Set syspref maxreserves to 1 2/ Place some holds through ILS-DI and note that you can place more than 1 hold for a borrower Apply the patch 3/ Place some holds through ILS-DI, you shouldn't be able to place more than 1 hold for a borrower 4/ Try to place holds on staff interface and OPAC. The behaviour must be identical than before the patch. Maxreserves and alreadyreserved works on ILSDI Maxreserves works also on staff and opac Already reserves works also on staff and opac tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using koha_ut db) Signed-off-by: Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> Signed-off-by: Alex Arnaud <alex.arnaud(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '20

02 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 26901] New: Add ability to stop transfer slips to print if TrapHoldsOnOrder is set to Don't Trap
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '20

02 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26901 Bug ID: 26901 Summary: Add ability to stop transfer slips to print if TrapHoldsOnOrder is set to Don't Trap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com With the introduction of the new system preference, TrapHoldsOnOrder, if a library sets this to "Don't Trap", they also would probably not want to get an alert to transfer the items. As libraries are continuing to quarantine their books, they are generally keeping them in the one library until the quarantine is over. However, clicking ignore with each transfer / hold slip for this workflow is a bit much. It would be nice to allow for a library to turn this off - as Koha is allowing with this other system preference. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '20

02 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #116 from David Nind <david(a)davidnind.com> --- Patches no longer apply 8-( -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20782] New: EDI: Clicking the 'Invoice' link on the 'EDI Messages' page does not take you directly to the corresponding invoice.
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '20

02 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20782 Bug ID: 20782 Summary: EDI: Clicking the 'Invoice' link on the 'EDI Messages' page does not take you directly to the corresponding invoice. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org This link used to take you to the right place, but has broken in recent releases. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 22

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '20

02 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #90 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Joonas Kylmälä from comment #89) > (In reply to Nick Clemens from comment #82) > > Hi Joonas, > > > > I obsoleted yours and added a new patch to fully add ES support here, let me > > know if that works for you > > Of course it works for me! You're awesome, thanks :) > > I tested the Elasticsearch implementation and I noticed slight difference > there: with Elasticsearch only the first 100 component part records are > returned meanwhile with Zebra all the component part records are returned. > Maybe a follow-up for this would be needed? Koha/SearchEngine/Elasticsearch/Search.pm 298 =item C<$max_results> 299 300 The max number of results to return. The default is 100 (because unlimited 301 is a pretty terrible thing to do.) Probably this should be a syspref? For Zebra we don't hardcode a limit, but maybe we should not return everything and it would be better to have one syspref to control both> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '20

02 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #89 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- (In reply to Nick Clemens from comment #82) > Hi Joonas, > > I obsoleted yours and added a new patch to fully add ES support here, let me > know if that works for you Of course it works for me! You're awesome, thanks :) I tested the Elasticsearch implementation and I noticed slight difference there: with Elasticsearch only the first 100 component part records are returned meanwhile with Zebra all the component part records are returned. Maybe a follow-up for this would be needed? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '20

02 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112851|0 |1 is obsolete| | --- Comment #88 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 112857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112857&action=e… Bug 11175: Add Elasticsearch support Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '20

02 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112847|0 |1 is obsolete| | --- Comment #87 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 112856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112856&action=e… Bug 11175: (follow-up) Relocate and reword ShowComponentRecords syspref description The syspref is not only affecting staff interface so moving it to Cataloguing section. Added also notes about UNIMARC and Elasticsearch not being supported. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0