November 2020 - Koha-bugs - lists.koha-community.org

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '20

02 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112841|0 |1 is obsolete| | --- Comment #86 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 112855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112855&action=e… Bug 11175: (follow-up) Add tests Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '20

02 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112840|0 |1 is obsolete| | --- Comment #85 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 112854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112854&action=e… Bug 11175: (follow-up) Return empty array if no components Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '20

02 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112839|0 |1 is obsolete| | --- Comment #84 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 112853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112853&action=e… Bug 11175: (follow-up) Don't return explicitly undef This would create in list context an list of one element that is undef, which we don't want, we want empty list if there are no components. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '20

02 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112838|0 |1 is obsolete| | --- Comment #83 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 112852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112852&action=e… Bug 11175: Show record component parts in the detail view Shows the component records of a host, on the hosts detail view in staff client or OPAC, with clickable links to the component records. The host does not require linking entries to the components, but components do require a link to the host record via 773$w. Adds a new search index, Control-number-identifier (aka cni), which indexes the 003 controlfield. Adds 'Yet Another System Preference', ShowComponentRecords, which can be used to turn this feature on or off in staff client and/or OPAC, and defaults to off. When looking up the component part records, the code searches for records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001' or, if the 003 is not defined in the Host, 773$w=Host001. Does not use easyanalytics or useControlNumber. Only for MARC21 biblios - UNIMARC has not been updated. staff-global.css and opac.css have not been recreated, so you need to use sass to recreate those from staff-global.scss and opac.scss Test plan: 0) Apply patch 1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML (This file is an attachment on the bug) 2) rebuild the zebra biblio index 3) Search for "easy piano" in staff client, and go to the biblio detail page. You should not see anything different in the record detail page. 4) Do the same on OPAC. 5) Change the ShowComponentRecords syspref appropriately and check the record detail page in staff client and OPAC. You should see a list of component part records. Rebased-by: Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '20

02 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '20

02 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #82 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Joonas Kylmälä from comment #77) > Created attachment 112846 [details] [review] > Bug 11175: (follow-up) Use uppercase AND and OR words in search query > > Elasticsearch only understands uppercase query operators. Hi Joonas, I obsoleted yours and added a new patch to fully add ES support here, let me know if that works for you -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '20

02 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112846|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '20

02 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #81 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 112851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112851&action=e… Bug 11175: Add Elasticsearch support -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '20

02 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #80 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- (In reply to Katrin Fischer from comment #70) > Hi Joonas, > > finally found some time to take a closer look: > > 1) System preference > - I think staff interface is not a good tab choise, I'd put it under > "Cataloguing" or "Search". I went with Cataloguing. > - As this currently doesn't work for UNIMARC or Elasticsearch, we should add > a hint about this in the pref so people know what to expect. Added this info to description. > - And maybe "does not require UseControlNumber".? I don't understand what you mean here. > - Change staff client to staff interface (see terminology list) Done. > 3) I am still slightly worried about what will happen when there are several > hundred of analytical records found. This would be very commonly the case > for our law and special libraries that do extensive analytical cataloguing > for serials. And all the analyticals are linked to the serials (there are no > volume or issue records as per the rules of our union catalog) so it gets > quite a lot. Could you think of a strategy for those? > > Maybe we could define a number for a "cutoff" and display a link for "Show > more". Ideal would be to show the newest x linked records. I added 325 component part records and it loaded as far as I could tell the same speed as without any component part records, so there is no noticeable slow down here, the algorithm for this looks linear. The current approach seems OK to me, no need for paging because the HTML links generated here are very light weight. I'm thinking this is again ready for sign-off. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 26842] New: SIP should allow bib level hols
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '20

02 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26842 Bug ID: 26842 Summary: SIP should allow bib level hols Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com Koha's SIP server was engineered to allow for item level holds down to and including C4::SIP::ILS::add_hold which accepts both an item id ( in the form of a barcode, SIP field AJ ), or a title id ( i.e. biblionumber, SIP field AJ ). add_hold is passed the barcode, *or* the biblionumber if a barcode was not passed in. All code after this point presumes that the value passed was a barcode. This should be corrected so that record level holds can be placed via SIP in Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2