February 2020 - Koha-bugs - lists.koha-community.org

[Bug 24696] New: We should output completion times in the updatedatabase output.
by bugzilla-daemon＠bugs.koha-community.org 15 Dec '20

15 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24696 Bug ID: 24696 Summary: We should output completion times in the updatedatabase output. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Updatedatabase reports a line for each update, but there's no time added so it's hard to track down which update was responsible for a very long-running upgrade if you're not actually watching the upgrade. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 27

[Bug 24741] New: Recent creation of unique index on library_groups erroneously removes rows
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24741 Bug ID: 24741 Summary: Recent creation of unique index on library_groups erroneously removes rows Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: stefan.berndtsson(a)ub.gu.se QA Contact: testopia(a)bugs.koha-community.org Bug 21674 introduces a new unique index on library_groups. Before this is done, removal of duplicate entries is done. This check for duplicates is wrong and removes non-duplicate entries as well. The query being executed is: DELETE FROM library_groups WHERE id NOT IN ( SELECT MIN(id) FROM ( SELECT * FROM library_groups ) AS lg WHERE parent_id IS NOT NULL GROUP BY parent_id, branchcode ) AND parent_id IS NOT NULL; To test: Use Administration/Library groups, add two group on the same level. Add a library or two in each of them, then run the above query. The second of the two groups, including all its libraries will now be removed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 23433] New: Make consistent use of patron-title.inc in hold confirmation dialogs
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Bug ID: 23433 Summary: Make consistent use of patron-title.inc in hold confirmation dialogs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 23399 We have inconsistent use of patron-title.inc in returns.tt. Sometimes it is used and sometimes it isn't. Where it was added it seems to have reversed the display of patron surname and first name: Previously last, first; now first last. All uses of patron-title.inc in this situation should be consistent. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23399 [Bug 23399] Reindent returns.tt -- You are receiving this mail because: You are watching all bug changes.

1 29

[Bug 21674] New: Data integrity not enforced for library groups
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674 Bug ID: 21674 Summary: Data integrity not enforced for library groups Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 15707 You can create hierarchical groups of libraries you are not allowed to add several times the same library to a given group/subgroup. The libraries that are part of the group is not displayed on the interface, to prevent the user to select it. However this restriction is only done template-side, the controller and module does not handle it. To recreate the problem: - Go to Home › Administration › Library groups - Add a group - Add a library - reload the page several times => The same library appears several times in the group Note that we should also replace the "Add" and "Remove" links with buttons. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 [Bug 15707] Add ability to define hierarchical groups of libraries -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 30

[Bug 17374] New: Make use of fields from syspref ' DefaultPatronSearchFields' in patron search fields dropdown
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Bug ID: 17374 Summary: Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Bug 14874 introduced syspref 'DefaultPatronSearchFields' to define what fields should be used in default patron search. It would be nice see the fields in the search fields drop down as well. At the moment the are hard coded to: Surname,Email,Borrower number,Username,Phone number,Street Address,Date of birth,Sort field 1,Sort field 2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 77

[Bug 21010] New: Add a script to search for data inconsistencies
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21010 Bug ID: 21010 Summary: Add a script to search for data inconsistencies Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 23871] New: data inconsistencies - check title exists
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23871 Bug ID: 23871 Summary: data inconsistencies - check title exists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz In biblio records, a field must be linked to biblio.title. 200$a in UNIMARC, 100$a MARC21 (and other). If this field is undefined, some pages like checkouts table can fail. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15

[Bug 23084] New: Replace grep {^$var$} with grep {$var eq $_}
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Bug ID: 23084 Summary: Replace grep {^$var$} with grep {$var eq $_} Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- See bug 23006 and bug 22941. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 39

[Bug 17268] New: Advanced cataloging editor - rancor - macros are lost when browser storage cleared
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Bug ID: 17268 Summary: Advanced cataloging editor - rancor - macros are lost when browser storage cleared Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt(a)gmail.com Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl In development macros were stored in the browser to allow different users to have their own. Unfortunately this means macros are lost when browser storage is cleared. Should have a more robust method for retaining these. -- You are receiving this mail because: You are watching all bug changes.

1 129

[Bug 24185] New: 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '20

14 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Bug ID: 24185 Summary: 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: nugged(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl When "reserve/request.pl -> C4/Reserves.pm::IsAvailableForItemLevelRequest" called many times with hundred of items and "on shelf holds" parameter set to "If all unavailable" for these items+patron, it goes very slow. This happens because in subloop there are re-checking if all other item unavailable so it is O(n^2) and it re-checks each time a lot of the same info for each item with repeating DB/data requests, these three: - GetBranchItemRule (per item type) - IsItemOnHoldAndFound (per item) - notforloan (per item) Proposed fix: I created patch to have in-variable cache in upper-level subroutine before entering the first "items" loop and passing that hash reference down into subs to cache these three values by keys per-item and per-item-type. It is simplest way to make it fast without re-thinking pretty complicated whole algorithm and business logic, and, when tested by speed it gave big improvement in execution time. How to reproduce: 1) on fresh installed kohadevbox create/import one book, record that biblionumber for later use it in down below, 2) add 100 items for that book for some library, 3) find some patron, that patron's card number we will use as a borrower down below to open holds page, 4) check for the rule or set up single circulation rule in admin "/cgi-bin/koha/admin/smart-rules.pl", so that rule will match above book items/libary/patron, check that rule to have non-zero number of holds (total, daily, count) allowed, and, IMPORTANT: set up "On shelf holds allowed" to "If all unavailable", ("item level holds" doesn't matter). 5) open "Home > Catalog > THAT_BOOK > Place a hold on THAT_BOOK" page ("holds" tab), and enter patron code in the search field, or you can create direct link by yourself, for example in my case it was: /cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=23529000686353 6) it should be pretty long page generation time. I tested on my computer in VirtualBox for this page generation times, (stats below is for many runs and smallest value taken from similar in a repetition), last one block eith times with that in-var-cache solution I am proposing: "On shelf holds allowed" != "If all unavailable": for 100 items: 5 seconds, for 200 items: 10 seconds, for 300 items: 11 seconds, "On shelf holds allowed" == "If all unavailable": for 100 items: 50 seconds, for 200 items: 3.1 minutes, for 300 items: 7.0 minutes, "On shelf holds allowed" == "If all unavailable" with cache: for 100 items: 7 seconds, for 200 items: 20 seconds, for 300 items: 38 seconds, -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 55