February 2020 - Koha-bugs - lists.koha-community.org

[Bug 14647] Make the file name extension dynamic on exporting records
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98633|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 99289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99289&action=ed… Bug 14647: (follow-up) Fix script not detecting XML output format Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14647] Make the file name extension dynamic on exporting records
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98632|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 99288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99288&action=ed… Bug 14647: (follow-up) Changes to script This patch adds the necessary changes to the script so that the filename extensions works for exporting authorities. To test: 1) Attempt to export with all filetypes for biblios and authorities 2) Confirm the extension for the exported file (after clicking the Export button) is correct for each one Sponsored-by: Catalyst IT Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14647] Make the file name extension dynamic on exporting records
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98631|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 99287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99287&action=ed… Bug 14647: Make the file name extension dynamic on exporting records Test - 1. go to cgi-bin/koha/tools/export.pl 2. Check that both tabs ("Export bibliographic records & Rxport authority records") do the following 3. In Output format 4. When changing "File format" from dropdown it update "file name" 5. Still works with user inputted names Works as expected. Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14647] Make the file name extension dynamic on exporting records
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12722] bulkmarcimport.pl: Should we move the old 001 to 035 ?
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12722 Heather <heather_hernandez(a)nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez(a)nps.gov --- Comment #11 from Heather <heather_hernandez(a)nps.gov> --- Could there be some way to choose this or not (e.g., syspref)? We are an OCLC library, and retain the OCLC record number in the 001 when importing authorities as our primary key; we match and replace authority records on the 010 field (Library of Congress Control Number). We (and perhaps other OCLC users) would definitely not want the OCLC number data moved out of the 001 field and into the 035 upon import. (The 001 also contains the OCLC record number in our bibs.) Could the desired moving of 001 data to 035 be accomplished with the new MARC modification templates capabilities upon record import? (So then maybe this enhancement isn't needed?) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14567] Browse interface for OPAC
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #61 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Notes: - Pref appears on Search/OpenUrl - I think move up by one: Features - Test plan and commit message needs a little update: * Run yarn build --view opac * Mention OpacBrowseSearch system preference ... ? - Capitalization: Really Fuzzy As the QA queue is really full right now, I will leave the follow-ups to the devs right now. But they should be quick and I will come back asap! Improvement ideas (separate bugs): - Show number of records for each list entry - It would be cool if you could move up and down list entries with the arrow keys, making it quick move between entries and see linked records -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14567] Browse interface for OPAC
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #60 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- False positive ;) FAIL spelling Sheat ==> Sheath, sheet, cheat Testing further... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13881] Add desk management
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 --- Comment #35 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Also missing tests! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13881] Add desk management
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #34 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Nicolas, starting with QA review here: 1) QA test tools Possibly a false positive: FAIL Koha/Desk.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 FAIL Koha/Desks.pm FAIL pod coverage POD is missing for 'object_class' Possibly a false positive: FAIL Koha/Schema/Result/Desk.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 FAIL koha-tmpl/intranet-tmpl/prog/en/includes/desks-admin-search.inc FAIL filters missing_filter at line 3 (<h1 id="logo"><a href="/cgi-bin/koha/mainpage.pl">[% LibraryName %]</a></h1>) missing_filter at line 7 ( <form action="[% script_name %]" method="post">) missing_filter at line 8 ( <input class="head-searchbox" type="text" name="desk_name" value="[% searchfield %]" size="40" />) FAIL forbidden patterns forbidden pattern: tab char (line 5) forbidden pattern: tab char (line 7) forbidden pattern: tab char (line 9) forbidden pattern: tab char (line 10) forbidden pattern: tab char (line 11) forbidden pattern: tab char (line 15) forbidden pattern: tab char (line 17) forbidden pattern: tab char (line 18) forbidden pattern: tab char (line 21) forbidden pattern: tab char (line 22) forbidden pattern: tab char (line 23) forbidden pattern: tab char (line 24) forbidden pattern: tab char (line 28) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/desks.tt FAIL filters missing_filter at line 79 ( <option value="[% branch.branchcode %]" selected="selected">[% branch.branchname %]</option>) missing_filter at line 79 ( <option value="[% branch.branchcode %]" selected="selected">[% branch.branchname %]</option>) missing_filter at line 81 ( <option value="[% branch.branchcode %]">[% branch.branchname %]</option>) missing_filter at line 81 ( <option value="[% branch.branchcode %]">[% branch.branchname %]</option>) 2) Quick code review admin/desks.pl Are the copyright statements correct? +# Copyright 2006 SAN OUEST-PROVENCE et Paul POULAIN +# Copyright 2015 Koha Development Team Leftover debugging code: +use Data::Dumper; The new page requires a new permission: manage_desks + flagsrequired => { parameters => 'manage_desks' }, But the new permission is not properly added. It looks like maybe you were planning to use manage_libraries here instead? Check: koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Owen, can you please check? FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt OK filters FAIL forbidden patterns forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 1347) OK git manipulation OK js_in_body OK spelling OK tt_valid OK valid_template -- You are receiving this mail because: You are watching all bug changes.

1 0