February 2020 - Koha-bugs - lists.koha-community.org

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #110 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Maryse, small failure in the QA script: 1) QA script FAIL installer/data/mysql/atomicupdate/bug_12446-EnableAdultGarantee.sql FAIL git manipulation The file has been added and deleted in the same patchset FAIL installer/data/mysql/kohastructure.sql OK boolean_vs_tinyint OK charset_collate OK git manipulation FAIL tinyint_has_boolean_flag The new column categories.canbeguarantee is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/Category.pm), see the SQL12 coding guideline The first could be fixed by squashing the patches in question, but should only be done if they got the same author/tester lines. 2) Quick code review Looks good so far, will continue testing with the follow-ups (switch back to signed-off) Note: I feel that GuarantorFields and "Shows guarantees' fines in the guarantor's page" should have been separate features/bugs - they add even more code to check and work through and make this this harder to test and harder to advertise/document. The bug title/description is actually not what this patch does, but is what will show up in release notes. - Too late now I guess, but I think it's part of the reason this has not been moving as fast as hoped for. :( -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #30 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Johanna, can you please rebase? Small thing: <li><a id="printcheckinslip" href="#">Print checked-in today -slip</a></li> I think I'd just label that as 'Print checkin slip' -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24054 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24054 [Bug 24054] Typo in ClaimReturnedWarningThreshold system preference -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #115 from Nick Clemens <nick(a)bywatersolutions.com> --- Overall this works and I agree, it is a much desired functionality. Test plan missing step: Must enable BiblioAddsAuthorities Blockers: When creating a new record the popup does not close / links not added automatically The record is saved an picked up if I relink sub AddAuthorityFromHeading - can this just be an option for AddAuthority? I don't understand why it is in C4/Biblio.pm - it checks the heading for things like 'series_added_entry' - i cannot identify where in the code these are being set sub GetRecordValue - added but not used? Change to POD in Linker.pm doesn't seem to have corresponding code change? Why a change to default linker behavior? -if ( $behavior eq 'default' && $#{$authorities} == 0 ) { +if ( $behavior eq 'default' && $#{$authorities} >= 0 ) { automatic_linker.pl - duplicates a lot of code from C4/Biblio->BiblioAutoLink - we should rather pass verbose option through that sub - should this be in svc? I am a bit confused about new param biblioindex vs index, we only ever seem to pass index, unless I missed something here Without edit authorities permission I get a warning that I cannot use the 'Link authorities automatically' button - I shouldn't see it if I can't use it As has been noted, test coverage is needed for changes to modules Other improvement, could be on new bug: 1 - This doesn't work with the advanced cataloging editor - code should be made flexible enough that can be done 2 - If links are changed they become green - if button clicked again they are not green - may not be obvious that I still need to save changes - i think a second run should preserve what was changed since the record was opened/created. 3 - The notice about links should show the headings that were linked/not-linked otherwise it can be confusing which individual 650 had an issue - colors are nice but we should no rely only on colors for accessibility 4 - The js uses hardcoded styles for colors - can this be made css so the js just adds a class, would allow easier override by users -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #122 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 --- Comment #23 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #114 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- It also appears that the new sub AddAuthorityFromHeading() should go at least to C4/AuthoritiesMarc.pm because it has nothing to do with biblio(?). It would be even better if it was in a Koha object since C4 namespace is being deprecated. -- You are receiving this mail because: You are watching all bug changes.

1 0