February 2020 - Koha-bugs - lists.koha-community.org

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #96 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Aleisha, can you please take a look at David'd comment#95? I also got a lot of fails with the QA tools for missing filters :( FAIL koha-tmpl/intranet-tmpl/prog/en/includes/page-numbers.inc FAIL filters missing_filter at line 4 ( <li><a class="nav" href="/cgi-bin/koha/catalogue/search.pl?[% query_cgi | $raw %][% limit_cgi | $raw %][% IF ( sort_by ) %]&sort_by=[% sort_by |url %][% END %][% IF results_per_page %]&count=[% results_per_page %][% END %]"> First</a></li>) missing_filter at line 6 ( <li><a class="nav" href="/cgi-bin/koha/catalogue/search.pl?[% query_cgi | $raw %][% limit_cgi | $raw %]&offset=[% previous_page_offset | html %][% IF ( sort_by ) %]&sort_by=[% sort_by |url %][% END %][% IF results_per_page %]&count=[% results_per_page %][% END %]"> Previous</a></li>) missing_filter at line 12 ( <li><a class="nav" href="/cgi-bin/koha/catalogue/search.pl?[% query_cgi | $raw %][% limit_cgi | $raw %]&offset=[% PAGE_NUMBER.offset | html %][% IF ( sort_by ) %]&sort_by=[% sort_by |url %][% END %][% IF results_per_page %]&count=[% results_per_page %][% END %]">[% PAGE_NUMBER.pg | html %]</a></li>) missing_filter at line 16 ( <li><a class="nav" href="/cgi-bin/koha/catalogue/search.pl?[% query_cgi | $raw %][% limit_cgi | $raw %]&offset=[% next_page_offset | html %][% IF ( sort_by ) %]&sort_by=[% sort_by |url %][% END %][% IF results_per_page %]&count=[% results_per_page %][% END %]">Next </a></li>) missing_filter at line 17 ( <li><a class="nav" href="/cgi-bin/koha/catalogue/search.pl?[% query_cgi | $raw %][% limit_cgi | $raw %]&offset=[% last_page_offset | html %][% IF ( sort_by ) %]&sort_by=[% sort_by |url %][% END %][% IF results_per_page %]&count=[% results_per_page %][% END %]">Last </a></li>) OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt FAIL filters missing_filter at line 274 ( Results per page: [% results_per_page %] ) missing_filter at line 281 ( [% END %] Library default: [% Koha.Preference('numSearchResults') %]) OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc FAIL filters wrong_html_filter at line 6 ( <li class="page-first"><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi | $raw %][% limit_cgi | $raw %][% IF ( sort_by ) %]&sort_by=[% sort_by | uri %][% END %][% IF results_per_page %]&count=[% results_per_page %][% END %]"> First</a></li>) missing_filter at line 6 ( <li class="page-first"><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi | $raw %][% limit_cgi | $raw %][% IF ( sort_by ) %]&sort_by=[% sort_by | uri %][% END %][% IF results_per_page %]&count=[% results_per_page %][% END %]"> First</a></li>) wrong_html_filter at line 7 ( <li class="page-prev"><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi | $raw %][% limit_cgi | $raw %]&offset=[% previous_page_offset | uri %][% IF ( sort_by ) %]&sort_by=[% sort_by | uri %][% END %][% IF results_per_page %]&count=[% results_per_page %][% END %]"> Previous</a></li>) missing_filter at line 7 ( <li class="page-prev"><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi | $raw %][% limit_cgi | $raw %]&offset=[% previous_page_offset | uri %][% IF ( sort_by ) %]&sort_by=[% sort_by | uri %][% END %][% IF results_per_page %]&count=[% results_per_page %][% END %]"> Previous</a></li>) wrong_html_filter at line 13 ( <li class="page-num"><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi | $raw %][% limit_cgi | $raw %]&offset=[% PAGE_NUMBER.offset | uri %][% IF ( sort_by ) %]&sort_by=[% sort_by | uri %][% END %][% IF results_per_page %]&count=[% results_per_page %][% END %]">[% PAGE_NUMBER.pg | html %]</a></li>) missing_filter at line 13 ( <li class="page-num"><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi | $raw %][% limit_cgi | $raw %]&offset=[% PAGE_NUMBER.offset | uri %][% IF ( sort_by ) %]&sort_by=[% sort_by | uri %][% END %][% IF results_per_page %]&count=[% results_per_page %][% END %]">[% PAGE_NUMBER.pg | html %]</a></li>) wrong_html_filter at line 17 ( <li class="page-next"><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi | $raw %][% limit_cgi | $raw %]&offset=[% next_page_offset | uri %][% IF ( sort_by ) %]&sort_by=[% sort_by | uri %][% END %][% IF results_per_page %]&count=[% results_per_page %][% END %]">Next </a></li>) missing_filter at line 17 ( <li class="page-next"><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi | $raw %][% limit_cgi | $raw %]&offset=[% next_page_offset | uri %][% IF ( sort_by ) %]&sort_by=[% sort_by | uri %][% END %][% IF results_per_page %]&count=[% results_per_page %][% END %]">Next </a></li>) wrong_html_filter at line 18 ( <li class="page-last"><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi | $raw %][% limit_cgi | $raw %]&offset=[% last_page_offset | uri %][% IF ( sort_by ) %]&sort_by=[% sort_by | uri %][% END %][% IF results_per_page %]&count=[% results_per_page %][% END %]">Last </a></li>) missing_filter at line 18 ( <li class="page-last"><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi | $raw %][% limit_cgi | $raw %]&offset=[% last_page_offset | uri %][% IF ( sort_by ) %]&sort_by=[% sort_by | uri %][% END %][% IF results_per_page %]&count=[% results_per_page %][% END %]">Last </a></li>) OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt FAIL filters missing_filter at line 172 ( <option value="[% Koha.Preference('OPACnumSearchResults') %]" selected="selected">Library default: [% Koha.Preference('OPACnumSearchResults') %]</option>) missing_filter at line 172 ( <option value="[% Koha.Preference('OPACnumSearchResults') %]" selected="selected">Library default: [% Koha.Preference('OPACnumSearchResults') %]</option>) missing_filter at line 174 ( <option value="[% Koha.Preference('OPACnumSearchResults') %]">Library default: [% Koha.Preference('OPACnumSearchResults') %]</option>) missing_filter at line 174 ( <option value="[% Koha.Preference('OPACnumSearchResults') %]">Library default: [% Koha.Preference('OPACnumSearchResults') %]</option>) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14647] Make the file name extension dynamic on exporting records
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 --- Comment #20 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 99290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99290&action=ed… Bug 14647: Make spelling in file format pull downs match While bibliographic had XML and MARC, authorities had xml and marc in the pull down. This just makes both the same. To test: - Look at the pull downs on both tabs and verify they are now using the same spelling Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14647] Make the file name extension dynamic on exporting records
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98633|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 99289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99289&action=ed… Bug 14647: (follow-up) Fix script not detecting XML output format Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14647] Make the file name extension dynamic on exporting records
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98632|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 99288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99288&action=ed… Bug 14647: (follow-up) Changes to script This patch adds the necessary changes to the script so that the filename extensions works for exporting authorities. To test: 1) Attempt to export with all filetypes for biblios and authorities 2) Confirm the extension for the exported file (after clicking the Export button) is correct for each one Sponsored-by: Catalyst IT Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14647] Make the file name extension dynamic on exporting records
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98631|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 99287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99287&action=ed… Bug 14647: Make the file name extension dynamic on exporting records Test - 1. go to cgi-bin/koha/tools/export.pl 2. Check that both tabs ("Export bibliographic records & Rxport authority records") do the following 3. In Output format 4. When changing "File format" from dropdown it update "file name" 5. Still works with user inputted names Works as expected. Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14647] Make the file name extension dynamic on exporting records
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12722] bulkmarcimport.pl: Should we move the old 001 to 035 ?
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12722 Heather <heather_hernandez(a)nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez(a)nps.gov --- Comment #11 from Heather <heather_hernandez(a)nps.gov> --- Could there be some way to choose this or not (e.g., syspref)? We are an OCLC library, and retain the OCLC record number in the 001 when importing authorities as our primary key; we match and replace authority records on the 010 field (Library of Congress Control Number). We (and perhaps other OCLC users) would definitely not want the OCLC number data moved out of the 001 field and into the 035 upon import. (The 001 also contains the OCLC record number in our bibs.) Could the desired moving of 001 data to 035 be accomplished with the new MARC modification templates capabilities upon record import? (So then maybe this enhancement isn't needed?) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14567] Browse interface for OPAC
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #61 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Notes: - Pref appears on Search/OpenUrl - I think move up by one: Features - Test plan and commit message needs a little update: * Run yarn build --view opac * Mention OpacBrowseSearch system preference ... ? - Capitalization: Really Fuzzy As the QA queue is really full right now, I will leave the follow-ups to the devs right now. But they should be quick and I will come back asap! Improvement ideas (separate bugs): - Show number of records for each list entry - It would be cool if you could move up and down list entries with the arrow keys, making it quick move between entries and see linked records -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14567] Browse interface for OPAC
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #60 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- False positive ;) FAIL spelling Sheat ==> Sheath, sheet, cheat Testing further... -- You are receiving this mail because: You are watching all bug changes.

1 0