February 2020 - Koha-bugs - lists.koha-community.org

[Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 --- Comment #23 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #114 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- It also appears that the new sub AddAuthorityFromHeading() should go at least to C4/AuthoritiesMarc.pm because it has nothing to do with biblio(?). It would be even better if it was in a Koha object since C4 namespace is being deprecated. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala(a)helsinki.fi Status|Signed Off |Failed QA --- Comment #113 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- I think it would have been beneficial to split this patch (as cait also suggested in the bug report) since there seems to be at least two logical changes. This would also increase the chances people have the time to sign-off and QA the patches. This is not a comprehensive review but I noticed this introduces new subroutine GetRecordValue which is a) not used at all b) doesn't appear to be functional since the DB table it uses doesn't exists. Also MARC::Field module is used without importing it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #14 from Owen Leonard <oleonard(a)myacpl.org> --- (In reply to Jonathan Druart from comment #10) > Request URL:http://catalogue.kohadev.org/opac-tmpl/bootstrap/images/z.png > Also, the style looks weird (I did yarn build --view opac): My follow-up should correct these mistakes. > And the popup does not display for the non XSLT view (new search is launched > instead). I don't see this problem. I believe the popup displays in all cases where it did previously, which excepts the "magnifying glass" link which links directly to an authority search. Can you re-test? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #13 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 99250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99250&action=ed… Bug 13327: (follow-up) Correct CSS and XSL errors This patch adds back the CSS changes which seem to have been lost in a rebase somewhere. The patch also corrects a bad copy/paste in the XSL file which led to a 404 error. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Bouzid Fergani <bouzid.fergani(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #112 from Bouzid Fergani <bouzid.fergani(a)inlibro.com> --- Hi Kat, The patch it's apply correctly now. Thanks. Bouzid. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '20

19 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Bouzid Fergani <bouzid.fergani(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98572|0 |1 is obsolete| | --- Comment #111 from Bouzid Fergani <bouzid.fergani(a)inlibro.com> --- Created attachment 99249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99249&action=ed… Bug 11299: Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. add authority type in the form to create the missing authority. when authority was found, the 600$9 field have the authid. Testing scenario (Creating an authority record for a failed automatic link) : * In you system preferences, deactivate the "AutoCreateAuthorities" preference. * Go to the biblio record creation form to create a new biblio record. (koha/cataloguing/addbiblio.pl) * Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." * Add random informations in field 600$a of the biblio record. * Click the "Link authorities automatically" button. * if matching authority was found, The message box should now show "600 - A matching authority was found in the local database". * if no matching authority was found, the message box should now show "600 - No matching authority found.". For this scenario, we want the authority match to have failed. * The 600$9 field should now be red and icons should have appeared next to it. Click on the "create authority" icon. * A popup will appear, containing a form to create the missing authority. The form should be pre-filled, a the informations in the 600$a field of the biblio should be in the 100$a field of this new authority record. * Fill in the form and click the "Save" button * The 600$9 field in the biblio record should now be back to normal and have the authid of the authority record that was just created. * Click the "Link authorities automatically" button again. The message box should now show "No authority link was changed.". Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> https://bugs.koha-community.org/show_bug.cgi?id=12299 Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0