February 2020 - Koha-bugs - lists.koha-community.org

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #25 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Thanks Katrin I'll work on fixing those. The staff side follow-up was already in my plan: (In reply to Aleisha Amohia from comment #11) > After this feature is passed: > - i would like to add a staff-side feature where staff can see the > problem reports and mark them as 'read'. i'll work on that once this > gets through :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #24 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Aleisha, starting with review and QA tools here: 1) Can you check if this is a real one or a false positive? FAIL Koha/ProblemReport.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 2) Please fix filters: FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reportproblem.tt FAIL filters missing_filter at line 3 (<title>[% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog &rsaquo; Report a Problem</title>) missing_filter at line 31 ( <div class="alert alert-info">Your problem report has been sent to the [% IF ( recipient == 'admin' ) %]Koha Administrator[% ELSE %][% recipient %][% END %].</div>) missing_filter at line 56 ( <input type="hidden" name="place" id="place" value="[% probpage %]">) missing_filter at line 61 ( <input type="hidden" name="user" id="user" value="[% username %]" class="span3">) missing_filter at line 65 ( <input type="text" name="subject" id="subject" value="[% subject %]" class="span3">) 3) Database update You got: + $dbh->do(q{ DROP TABLE IF EXISTS `problem_reports` }); I think this could be destructive in some cases. I think checking for existence of the table is better: 20126 if ( !TableExists('return_claims') ) { 4) Capitalization catalog &rsaquo; Report a Problem</title> Koha Administrator 5) print $input->redirect("/cgi-bin/koha/opac-reportproblem?norecipients=1.pl"); Looks like a typo with the .pl at the end? 6) Translatatability I these go in the email to the library/admin, but won't be translatable: + $problemreport->{code} = 'PROBLEM_REPORT'; + $problemreport->{content} .= "\nUsername: $username"; + $problemreport->{content} .= "\nProblem page: $place"; Using a notice template would be the most elegant way to make those translatable. I think with https://bugs.koha-community.org/bugzilla3/showdependencytree.cgi?id=15395&h… you can not yet add strings to .pl fils in a translatable way. If I understand correctly the only way to access the reports for now would be a report? It might be nice (new bug!) to have this on the dashoard and visible in staff or even the patron account :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3137] Add sys pref to collapse areas of the patron add by default
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #16 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I've switched the sequence of patches when applying, but still get a conflict: Apply? [(y)es, (n)o, (i)nteractive] i Applying: Bug 3137: HideFieldsPatronAddForm syspref Applying: Bug 21156: (RM follow-up) Add missing filters Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 21156: (RM follow-up) Add missing filters The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21156-RM-follow-up-Add-missing-filters-BipPBa.patch Can you please rebase? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 15352] Use URLLinkText instead of URL for item links
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah(a)gmail.com --- Comment #24 from Lisette Scheer <lisetteslatah(a)gmail.com> --- (In reply to Katrin Fischer from comment #21) > I think I'd have preferred it as it also allows to keep the current > behaviour (least surprise/no change on update) I think I'm with Cait on this one, especially since items aren't currently effected by the sys pref that effect records. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don't work as expected
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #39 from John Sterbenz <jsterben(a)umich.edu> --- This is a new issue to me (as of yesterday) on the 18.11 series on 18.04 LTS. This process had worked for years prior (all the way back to 2016 / 3.22 on 14.04)--now every load I try fails. I did upgrade my production server to 18.04 in preparation for installation of the 19.05 series--that is the only difference (in terms of anything I've directly initiated) between success and failure, yet the comments here indicate this has been an issue for nearly 5 years and reported (at least here) as recently as a few months ago. Prod was already running the 18.11 series--it was only the OS I upgraded. Thanks to VM snapshots, I took my dev server back to 17.11 on 16.04 and everything worked again, but that doesn't do me any good for production. This is the only way we load records--and do so to the tune of 260K-300K records a month (in files of 20K records). Most of these records are overlaid--perhaps only 1-2% are new records. We are at a standstill until this is resolved or I identify some sort of workaround. I have not yet tried anything like a smaller file size since this was just discovered yesterday by my staff in the course of regular work. I note the mention of Plack (without having read the entire comment thread yet to see if this is relevant/related or not) and have not turned that off for this instance to see if that will matter. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15352] Use URLLinkText instead of URL for item links
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 --- Comment #23 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I'd like a separate pref, but maybe we should get some more opinions (Owen and me are like 1:1 so far :) ), before we create more work for you. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8595] Link to 'host item' confusing
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595 --- Comment #7 from Elaine Bradtke <eb(a)efdss.org> --- In answer to Katrin - We don't link to the item number in 773 (the item number is $o in our records) We use the record control number instead. 773 0# - HOST ITEM ENTRY o Other item identifier 17188 w Record control number LS01459 t Title [Political pamphlets from 1820] 'Item' here is from MARC - http://www.loc.gov/marc/bibliographic/bd773.html but I don't think it necessarily means the same as 'item record'. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8595] Link to 'host item' confusing
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|link to 'host item' |Link to 'host item' |confusing |confusing -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8595] link to 'host item' confusing
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eb(a)efdss.org, | |katrin.fischer(a)bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Are we sure that item is not correct? When I click on "Link to host item" I am asked to enter an item barcode - not a record number. As far as I know the 773 created contains a subfield with the itemnumber and the host item is displayed on all analytical records linked to it. I think this is actually item based. Adding Elaine - I know her library is using this feature. -- You are receiving this mail because: You are watching all bug changes.

1 0