February 2020 - Koha-bugs - lists.koha-community.org

[Bug 15352] Use URLLinkText instead of URL for item links
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 --- Comment #22 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- My initial patches introduced a new syspref. Should I submit a follow up to this bug or make a new bug? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #78 from Lisette Scheer <lisetteslatah(a)gmail.com> --- Created attachment 99215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99215&action=ed… Bug 15522: (follow-up) Handle deprecated rules Previous use of inArray was wrong. Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99207|0 |1 is obsolete| | --- Comment #77 from Lisette Scheer <lisetteslatah(a)gmail.com> --- Created attachment 99214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99214&action=ed… Bug 15522: New interface for updated circulation rules Test plan: 1) Make sure all dependencies are applied, and that their DB upgrades have been applied. 2) Build JS (see previous patches for HOWTO). 3) Load .../cgi-bin/koha/admin/policy.pl . 4) Try changing an existing rule (one with a textbox or dropdown). Hit "Save rules", ensure that your changes are saved. 5) Until changes are saved, all cells that are changed or affected by your changes should be highlighted in yellow. 6) Same as above, but deleting a rule by hitting the "x" next to it. 7) Add rows and columns using the "Choose rule..." and "Choose category/item type..." dropdowns. 8) Add rules by clicking the pencil in a currently unset rule cell. Ensure changes are saved. 9) Hit "Cleanup rules"; all redundant rules should be removed. As this only removes rules that are the same as the defaults, this should not change any effective rules. 10) Use the filters at the top right ("Circulation", "Holds" and "Fines") to filter the kinds of rules that are shown. 11) Ensure that any desired library can be shown, including (if selected) all at the same time. JD edits: Removed the changes to filtered categories, will be done in a follow-up Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99208|0 |1 is obsolete| | --- Comment #76 from Lisette Scheer <lisetteslatah(a)gmail.com> --- Created attachment 99213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99213&action=ed… Bug 15522: Add JS build pipeline This is not directly testable, but can be either used through the Makefile: $ make js-build (This will automatically install all dependencies.) Or by manually installing yarn: $ sudo apt install nodejs npm $ sudo npm install -g yarn $ yarn install $ yarn build (There is also `make js-watch` and `yarn watch`, which automatically recompile when files are changed.) JD note: the make rule does not work Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99148|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #75 from Lisette Scheer <lisetteslatah(a)gmail.com> --- Created attachment 99211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99211&action=ed… Bug 15522: Add API for circulation rules Test plan: 1) Run t/db_dependent/api/v1/circ_rules.t . Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99210|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99157|0 |1 is obsolete| | Attachment #99209|0 |1 is obsolete| | --- Comment #74 from Lisette Scheer <lisetteslatah(a)gmail.com> --- Created attachment 99210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99210&action=ed… Bug 15522: Add API for circulation rules Test plan: 1) Run t/db_dependent/api/v1/circ_rules.t . Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99199|0 |1 is obsolete| | --- Comment #73 from Lisette Scheer <lisetteslatah(a)gmail.com> --- Created attachment 99209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99209&action=ed… Bug 15522: Add API for circulation rules Test plan: 1) Run t/db_dependent/api/v1/circ_rules.t . Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99149|0 |1 is obsolete| | --- Comment #72 from Lisette Scheer <lisetteslatah(a)gmail.com> --- Created attachment 99208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99208&action=ed… Bug 15522: Add JS build pipeline This is not directly testable, but can be either used through the Makefile: $ make js-build (This will automatically install all dependencies.) Or by manually installing yarn: $ sudo apt install nodejs npm $ sudo npm install -g yarn $ yarn install $ yarn build (There is also `make js-watch` and `yarn watch`, which automatically recompile when files are changed.) JD note: the make rule does not work Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.

1 0