February 2020 - Koha-bugs - lists.koha-community.org

[Bug 6815] Capture member photo via webcam
by bugzilla-daemon＠bugs.koha-community.org 14 Feb '20

14 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91335|0 |1 is obsolete| | --- Comment #34 from Lisette Scheer <lisetteslatah(a)gmail.com> --- Created attachment 99016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99016&action=ed… Bug 6815: Detect Webcam to show or not button It's hard to test on a laptop with a webcam built it. So, please attempt with: The system preference patronimage set to allow. And in any given patron detail page, see if the 'Take' button appears/disappears with a refresh while plugging and unplugging a webcam. Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6815] Capture member photo via webcam
by bugzilla-daemon＠bugs.koha-community.org 14 Feb '20

14 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6815] Capture member photo via webcam
by bugzilla-daemon＠bugs.koha-community.org 14 Feb '20

14 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91303|0 |1 is obsolete| | --- Comment #33 from Lisette Scheer <lisetteslatah(a)gmail.com> --- Created attachment 99015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99015&action=ed… Bug 6815: Add a 'Take Patron Image' ability This does not just click in place, which would be nice. But it does take the picture, download to a file, and then let's the user use the existing upload functionality to add the photo. If wording or formating is ugly, feel free to tweak. TEST PLAN --------- 1) the 'patronimages' system preference in Patrons system preferences must be set to 'Allow'. 2) apply the patch 3) go to any patron 4) click the 'Take' button. -- it is in the text area on the right, and not the hover over the image area. Adding here would require CSS changes, which are now difficult and ugly to do. -- new tab should open. If you have a working webcam, you should see it playing 'live'. 5) click the "Take the Patron's Picture" button -- this should download a photo SamplePhoto.jpg or some variation of that. 6) close this tab, and click the 'Edit' or 'Add' button for the patron image. 7) click 'Choose File' and choose the file that was created 8) click 'Upload' -- the webcam photo should now be used. 9) run koha qa test tools Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
by bugzilla-daemon＠bugs.koha-community.org 14 Feb '20

14 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 --- Comment #21 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 99006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99006&action=ed… Bug 6508: (follow-up) Remove dependency on jquery for check in templates Should work as before with the test plan from the second patch. But removes the added jQuery display control code in favor of checking if fines is set on template level. For several patrons with and without fines and with credits: - Check the Fines & Charges only display when there is something to see Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
by bugzilla-daemon＠bugs.koha-community.org 14 Feb '20

14 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 --- Comment #20 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 99005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99005&action=ed… Bug 6508: (follow-up) Change layout of price and hide tab if no fines With this patch, the tab will not show if there are no fines. I've also changed how the fines look in the tab header to look more like the OPAC fines tab. Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
by bugzilla-daemon＠bugs.koha-community.org 14 Feb '20

14 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98972|0 |1 is obsolete| | Attachment #98973|0 |1 is obsolete| | Attachment #98974|0 |1 is obsolete| | --- Comment #19 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 99004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99004&action=ed… Bug 6508: Add balance to `Fines & Charges` tab Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
by bugzilla-daemon＠bugs.koha-community.org 14 Feb '20

14 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
by bugzilla-daemon＠bugs.koha-community.org 14 Feb '20

14 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98939|0 |1 is obsolete| | --- Comment #9 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 99002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99002&action=ed… Bug 13327: OPACPopupAuthorsSearch doesn't work with XSLT views This patch reimplements the OPACPopupAuthorsSearch feature so that it will work in the XSLT view. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staf…) - View the detail page for a bibliographic record in the OPAC. Test under the following conditions: - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay empty - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay empty In each of these cases, test the detail page's listing of additional authors/contributors and subjects. Test records which have both multiple contributors or subjects and which have only one author or subject. When OPACPopupAuthorsSearch is turned on, verify that the author/subject selection modal appears and that your selections are correctly combined to build a search string. Note that OPACPopupAuthorsSearch feature has a problem with terms containing parentheses. The issue predates this patch. Also note that the QA tools will give a false positive about Bootstrap button styles. This rule only applies to the staff client. Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
by bugzilla-daemon＠bugs.koha-community.org 14 Feb '20

14 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5087] Option to not show CSV profiles in OPAC
by bugzilla-daemon＠bugs.koha-community.org 14 Feb '20

14 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard <oleonard(a)myacpl.org> --- I get this warning from the QA tool: FAIL installer/data/mysql/kohastructure.sql OK boolean_vs_tinyint OK charset_collate OK git manipulation FAIL tinyint_has_boolean_flag The new column export_format.opac_option is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/ExportFormat.pm), see the SQL12 coding guideline -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0