March 2020 - Koha-bugs - lists.koha-community.org

[Bug 24463] New: Consistent accessor-relationship naming for basket_group in Basket.pm
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463 Bug ID: 24463 Summary: Consistent accessor-relationship naming for basket_group in Basket.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org We agreed there needs to be consistency. This will be a blocker for dealing with related data from the API (prefetching, filternig, etC). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 22025] New: Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for /usr/share/koha/bin/import_patrons.pl
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22025 Bug ID: 22025 Summary: Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for /usr/share/koha/bin/import_patrons.pl Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: mjnkml(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz Target Milestone: --- When running: > sudo koha-shell -v -c "/usr/share/koha/bin/import_patrons.pl --file /home/kohasync/incomingfile/borrowers.csv --matchpoint userid --confirm --overwrite --verbose" our_instance_name We get a bunch of: > Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle> line 490. per import row. When I add some say STDERR lines just before it, I get: > Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1019, <$handle> line 490. > OLD: 0, NEW: , COL: lost > > Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1019, <$handle> line 490. > OLD: 0, NEW: , COL: privacy_guarantor_checkouts > > Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1019, <$handle> line 490. > OLD: 0, NEW: , COL: lost > None of those fields (privacy_guarantor_checkouts, lost, etc.) are included in the CSV import. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 23

[Bug 24436] New: Record if a transfer was triggered by a 'reserve'
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436 Bug ID: 24436 Summary: Record if a transfer was triggered by a 'reserve' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, koha-bugs(a)lists.koha-community.org, kyle.m.hall(a)gmail.com, testopia(a)bugs.koha-community.org Depends on: 24297, 24299 Blocks: 4234, 23092 Using the new 'trigger' field in branchtransfers to record if a transfer was added by a reserve. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297 [Bug 24297] Record if a transfer was triggered 'manually' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299 [Bug 24299] Record if a transfer was triggered by 'rotating collections' -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.

1 21

[Bug 24830] New: dbic_merge_prefetch is not handling recursive cases correctly
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24830 Bug ID: 24830 Summary: dbic_merge_prefetch is not handling recursive cases correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org In the context of bug 20212, I noticed that requesting to embed basket and basket.basket_group yields no basket is prefetch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 22

[Bug 24726] New: overdue_notices.pl should use Koha::Library->get_effective_email
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24726 Bug ID: 24726 Summary: overdue_notices.pl should use Koha::Library->get_effective_email Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: katrin.fischer(a)bsz-bw.de, testopia(a)bugs.koha-community.org Depends on: 22823 Bug 22823 introduced a consistent method for obtaining the inbound email address of a library branch, we should use that method to obtain the correct address for use with the overdues functionality when a patron email is not found. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823 [Bug 22823] Koha::Library needs a method for obtaining the inbound email address -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 24723] New: EmailPurchaseSuggestions should use Koha::Library->get_effective_email when set to 'BranchEmailAddress'
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24723 Bug ID: 24723 Summary: EmailPurchaseSuggestions should use Koha::Library->get_effective_email when set to 'BranchEmailAddress' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: katrin.fischer(a)bsz-bw.de, testopia(a)bugs.koha-community.org Depends on: 22823 Bug 22823 introduced a consistent method for obtaining the inbound email address of a library branch, we should use that method to obtain the correct address for use with the EmailPurchaseSuggestions functionality when it is set to 'BranchEmailAddress'. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823 [Bug 22823] Koha::Library needs a method for obtaining the inbound email address -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 24721] New: emailLibrarianWhenHoldIsPlaced should use Koha::Library->get_effective_email
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24721 Bug ID: 24721 Summary: emailLibrarianWhenHoldIsPlaced should use Koha::Library->get_effective_email Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 22823 Bug 22823 introduced a consistent method for obtaining the inbound email address of a library branch, we should use that method to obtain the correct address for use with the emailLibrarianWhenHoldIsPlaced functionality. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823 [Bug 22823] Koha::Library needs a method for obtaining the inbound email address -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15

[Bug 24774] New: Specify 2 space indentation for JSON files in .editorconfig
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24774 Bug ID: 24774 Summary: Specify 2 space indentation for JSON files in .editorconfig Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Developer documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: lari.taskula(a)hypernova.fi QA Contact: testopia(a)bugs.koha-community.org >From Bug 12545 >> It'd be usefull to have a .editorconfig [1] file, that enforces some of our >> coding guidelines, in the source tree top level. >> >> Those developers that have their editors configured to honour the file, will >> benefit. Those that wouldn't use it, won't get bothered by the addition. So, a >> harmless addition that would benefit those that are interested. >> >> There are plugins for several major editors: >> - Emacs >> - Vim >> - SublimeText >> - and so on... >> >> [1] http://editorconfig.org/ Editors using .editorconfig by default set 4 space indentation in JSON files although we have typically been using 2 spaces. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 10

[Bug 24818] New: Accountline creation dates should be datetimes
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24818 Bug ID: 24818 Summary: Accountline creation dates should be datetimes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: martin.renvoize(a)ptfs-europe.com Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org The resolution of the 'date' field in accountlines is just a date. It should be helpful if it were a full timestamp and also nice if it were maintained by the database rather than a DEFAULT NULL -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 22821] New: Patron notes about item email notification fallback order is incorrect
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Bug ID: 22821 Summary: Patron notes about item email notification fallback order is incorrect Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- In bug 19496 a fallback order for the email addresses (both to and from) was added. This fallback order appears to be incorrect per my understanding of the system preferences. > my $to_address = $branch->branchemail || $branch->branchreplyto || C4::Context->ReplytoDefault || C4::Context->preference('KohaAdminEmailAddress'); My understanding is that branchemail is used for the 'from' address in emails from the branch, however it may not be an address which is accessible by the librarians (as to be allowed through spam filters for most popular email service the 'from' address domain has to match the domain of the sender server).. as such 'reply-to' address was added to allow for a library to send 'from' a proper domain but have 'replies' go to an email address they control. > my $from_address = $patron->email || $patron->emailpro || $patron->B_email; We cannot spoof send emails from the patrons email address for the same reasons as outlined above. The email must come from the koha system but may happily contain the above fallback in the reply-to header to achieve what I believe is wanted. -- You are receiving this mail because: You are watching all bug changes.

1 55