March 2020 - Koha-bugs - lists.koha-community.org

[Bug 24723] New: EmailPurchaseSuggestions should use Koha::Library->get_effective_email when set to 'BranchEmailAddress'
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24723 Bug ID: 24723 Summary: EmailPurchaseSuggestions should use Koha::Library->get_effective_email when set to 'BranchEmailAddress' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: katrin.fischer(a)bsz-bw.de, testopia(a)bugs.koha-community.org Depends on: 22823 Bug 22823 introduced a consistent method for obtaining the inbound email address of a library branch, we should use that method to obtain the correct address for use with the EmailPurchaseSuggestions functionality when it is set to 'BranchEmailAddress'. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823 [Bug 22823] Koha::Library needs a method for obtaining the inbound email address -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 24721] New: emailLibrarianWhenHoldIsPlaced should use Koha::Library->get_effective_email
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24721 Bug ID: 24721 Summary: emailLibrarianWhenHoldIsPlaced should use Koha::Library->get_effective_email Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 22823 Bug 22823 introduced a consistent method for obtaining the inbound email address of a library branch, we should use that method to obtain the correct address for use with the emailLibrarianWhenHoldIsPlaced functionality. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823 [Bug 22823] Koha::Library needs a method for obtaining the inbound email address -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15

[Bug 24774] New: Specify 2 space indentation for JSON files in .editorconfig
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24774 Bug ID: 24774 Summary: Specify 2 space indentation for JSON files in .editorconfig Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Developer documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: lari.taskula(a)hypernova.fi QA Contact: testopia(a)bugs.koha-community.org >From Bug 12545 >> It'd be usefull to have a .editorconfig [1] file, that enforces some of our >> coding guidelines, in the source tree top level. >> >> Those developers that have their editors configured to honour the file, will >> benefit. Those that wouldn't use it, won't get bothered by the addition. So, a >> harmless addition that would benefit those that are interested. >> >> There are plugins for several major editors: >> - Emacs >> - Vim >> - SublimeText >> - and so on... >> >> [1] http://editorconfig.org/ Editors using .editorconfig by default set 4 space indentation in JSON files although we have typically been using 2 spaces. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 10

[Bug 24818] New: Accountline creation dates should be datetimes
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24818 Bug ID: 24818 Summary: Accountline creation dates should be datetimes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: martin.renvoize(a)ptfs-europe.com Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org The resolution of the 'date' field in accountlines is just a date. It should be helpful if it were a full timestamp and also nice if it were maintained by the database rather than a DEFAULT NULL -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 22821] New: Patron notes about item email notification fallback order is incorrect
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Bug ID: 22821 Summary: Patron notes about item email notification fallback order is incorrect Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- In bug 19496 a fallback order for the email addresses (both to and from) was added. This fallback order appears to be incorrect per my understanding of the system preferences. > my $to_address = $branch->branchemail || $branch->branchreplyto || C4::Context->ReplytoDefault || C4::Context->preference('KohaAdminEmailAddress'); My understanding is that branchemail is used for the 'from' address in emails from the branch, however it may not be an address which is accessible by the librarians (as to be allowed through spam filters for most popular email service the 'from' address domain has to match the domain of the sender server).. as such 'reply-to' address was added to allow for a library to send 'from' a proper domain but have 'replies' go to an email address they control. > my $from_address = $patron->email || $patron->emailpro || $patron->B_email; We cannot spoof send emails from the patrons email address for the same reasons as outlined above. The email must come from the koha system but may happily contain the above fallback in the reply-to header to achieve what I believe is wanted. -- You are receiving this mail because: You are watching all bug changes.

1 55

[Bug 24495] New: Reword change collection feature
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495 Bug ID: 24495 Summary: Reword change collection feature Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org We've had several libraries contact us with confusion over the new change collection feature. Apparently the wording on "Amount paid" and "Collect from patron" is not broadly intuitive. Opening this to consider alternate wording. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 29

[Bug 24662] New: Remove global variables MSG_* from datatables.inc
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 Bug ID: 24662 Summary: Remove global variables MSG_* from datatables.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: julian.maurice(a)biblibre.com Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr Now that bug 21156 is pushed, we don't need to have global variables in .inc or .tt files for translation in .js file. We can simply declare our translatable strings where they are used. -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 24661] New: Inclusion of locale-related javascript files is broken
by bugzilla-daemon＠bugs.koha-community.org 03 Apr '20

03 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 Bug ID: 24661 Summary: Inclusion of locale-related javascript files is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: julian.maurice(a)biblibre.com Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr Depends on: 21156 Bug 21156 adds 2 js files (Gettext.js, i18n.js) + 1 generated js file (locale_data.js). On master, their URL are broken and the files are not loaded. Steps to reproduce: 1. Checkout master 2. Open Firefox/Chrome devtools, network tab, and go to any page in the staff interface (except the main page) 3. You should see 3 404 errors for the files mentioned above. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes.

1 37

[Bug 17421] New: Missing dependency on CGI::Emulate::PSGI
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17421 Bug ID: 17421 Summary: Missing dependency on CGI::Emulate::PSGI Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt(a)gmail.com Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org I just tried to do a plackup (the Plack utility not plackup.sh) and got an error that CGI::Emulate::PSGI wasn't installed. I'm thinking we should add that to Koha's Perl dependencies. Looking at Debian (https://packages.debian.org/sid/perl/libplack-perl) it looks like the package is recommended but not required. Actually, I don't notice it in https://github.com/Koha-Community/Koha/blob/master/debian/control either... I'm using Plack v1.0037 whereas Jessie is at v1.0033-1... It's required by Plack::App::WrapCGI, which uses it in v1.0033: https://metacpan.org/source/MIYAGAWA/Plack-1.0033/lib/Plack/App/WrapCGI.pm -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 24593] New: Rewrite MARC21 optional data to YAML
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593 Bug ID: 24593 Summary: Rewrite MARC21 optional data to YAML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: bgkriegel(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr A complete rewrite of MARC21 optional instalation files from SQL to YAML is presented, one patch for each file, the result could be squashed. The goal is to allow the translation of the installation files -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 21