March 2020 - Koha-bugs - lists.koha-community.org

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24999 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24999 [Bug 24999] Date not correctly formatted in claims table -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24765 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765 [Bug 24765] Updated on date in Claims returned starts off as 12/31/1969 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13881] Add desk management
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #50 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Upgrade to 19.12.00.054 done [07:00:32]: Bug 13881 - Add desk management DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'A' at line 2 [for Statement " ALTER TABLE suggestions ADD CONSTRAINT `suggestions_ibfk_lastmodificationby` FOREIGN KEY (`lastmodificationby`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE A "] at installer/data/mysql/updatedatabase.pl line 21300. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #117 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Lari, the remote branch needs to be used to testing. The patches were not up-to-date on purpose, new rules have been added to the table, and need to be added to the interface, did you deal with them? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #116 from Lari Taskula <lari.taskula(a)hypernova.fi> --- Comment on attachment 101934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101934 Bug 15522: Add API for circulation rules Review of attachment 101934: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=155…) ----------------------------------------------------------------- ::: api/v1/swagger/paths/circulation-rules.json @@ +28,5 @@ > + "schema": { > + "$ref": "../definitions.json#/error" > + } > + } > + } No permissions required for GET? @@ +40,5 @@ > + ], > + "parameters": [{ > + "name": "body", > + "in": "body", > + "description": "A JSON object containing rules to set; null for a rule_value means to delete the rule", I think this wrong functionality for POST method that is supposed to create resources. Also, by definition POST is not idempotent, but here it seems to be. (If I understand the API correctly, here making the same request twice is the same as making it only once, right?) It should then be PUT. But PUT requires the whole object as a parameter. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula <lari.taskula(a)hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101946|0 |1 is obsolete| | --- Comment #115 from Lari Taskula <lari.taskula(a)hypernova.fi> --- Created attachment 101947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101947&action=e… Bug 15522: (follow-up) Fix 400 errors in circ_rules.t Commit "Bug 15522: Fix permission name manage_circ_rules_from_any_libraries" renames a permission by one that negates the previous. However the commit above incorrectly negates more than is supposed to. The test wants to check whether unauthorized and restricted user can store circulation rules. The libriarian is restricted (to their homebranch) when they are circ rules authorized (by "manage_circ_rules" permission) but do not have permission "manage_circ_rules_from_any_libraries". To test: 1. prove t/db_dependent/api/v1/circ_rules.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #114 from Lari Taskula <lari.taskula(a)hypernova.fi> --- Created attachment 101946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101946&action=e… Bug 15522: (follow-up) Fix 400 errors in circ_rules.t Commit "Bug 15522: Fix permission name manage_circ_rules_from_any_libraries" renames a permission by one that negates the previous. However the commit above incorrectly negates more than is supposed to. The test wants to check whether unauthorized and restricted user can store circulation rules. The libriarian is restricted (to their homebranch) when they are circ rules authorized (by "manage_circ_rules" permission) but do not have permission "manage_circ_rules_from_any_libraries". To test: 1. prove t/db_dependent/api/v1/circ_rules.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #113 from Lari Taskula <lari.taskula(a)hypernova.fi> --- Created attachment 101945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101945&action=e… Bug 15522: (follow-up) Add missing http return codes to api spec -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #112 from Lari Taskula <lari.taskula(a)hypernova.fi> --- Created attachment 101944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101944&action=e… Bug 15522: (follow-up) Fix circulation rules interface title inconsistency Follow-up to "Bug 15522: Remove old circulation rules interface" Instead of: "Circulation, fines and holds rules", use "Circulation, fines, and holds rules" for consistency Latter form already used in commit Bug 15522: New interface for updated circulation rules as follows koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc:37: <li><a href="/cgi-bin/koha/admin/policy.pl">Circulation, fines, and holds rules</a></li> koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt:88: <dt><a href="/cgi-bin/koha/admin/policy.pl">Circulation, fines, and holds rules</a></dt> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula <lari.taskula(a)hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101927|0 |1 is obsolete| | --- Comment #111 from Lari Taskula <lari.taskula(a)hypernova.fi> --- Created attachment 101943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101943&action=e… Bug 15522: (follow-up) Handle deprecated rules Previous use of inArray was wrong. Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> Signed-off-by: Lari Taskula <lari.taskula(a)hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0