March 2020 - Koha-bugs - lists.koha-community.org

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #100 from Lari Taskula <lari.taskula(a)hypernova.fi> --- (In reply to Lari Taskula from comment #98) > (In reply to Lisette Scheer from comment #62) > > (In reply to Jonathan Druart from comment #51) > > > Created attachment 99148 [details] [review] [review] [review] > > > Bug 15522: Add API for circulation rules > > > > > > Test plan: > > > 1) Run t/db_dependent/api/v1/circ_rules.t . > > > > kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove > > t/db_dependent/api/v1/circ_rules.t > > t/db_dependent/api/v1/circ_rules.t .. 1/5 > > # Failed test '403 Forbidden' > > # at t/db_dependent/api/v1/circ_rules.t line 128. > > # got: '400' > > # expected: '403' > > # Looks like you failed 1 test of 2. > > t/db_dependent/api/v1/circ_rules.t .. 3/5 > > # Failed test 'set_rules | unauthorized' > > # at t/db_dependent/api/v1/circ_rules.t line 132. > > > > # Failed test '200 OK' > > # at t/db_dependent/api/v1/circ_rules.t line 212. > > # got: '403' > > # expected: '200' > > # Looks like you failed 1 test of 6. > > > > # Failed test 'set_rules | restricted' > > # at t/db_dependent/api/v1/circ_rules.t line 223. > > # Looks like you failed 2 tests of 5. > > t/db_dependent/api/v1/circ_rules.t .. Dubious, test returned 2 (wstat 512, > > 0x200) > > Failed 2/5 subtests > > > > Test Summary Report > > ------------------- > > t/db_dependent/api/v1/circ_rules.t (Wstat: 512 Tests: 5 Failed: 2) > > Failed tests: 3, 5 > > Non-zero exit status: 2 > > Files=1, Tests=5, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.86 cusr 0.23 > > csys = 3.11 CPU) > > Result: FAIL > > > > I got this message when I tried to do this step in my devbox. Everything > > else worked great for me. > > I confirm this error. Will provide a patch to fix it. Already fixed by "Bug 15522: Fix permission name manage_circ_rules_from_any_libraries", maybe squash this patch to the first one. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #99 from Lari Taskula <lari.taskula(a)hypernova.fi> --- Comment on attachment 101920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101920 Bug 15522: New interface for updated circulation rules Review of attachment 101920: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=155…) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/js/src/admin/policy/app.js @@ +75,5 @@ > + </div>; > + } > + > + componentDidMount() { > + $( this.toolbarElem ).fixFloat(); Test plan step 3 fails, my browser (both FF and Chromium) console says: TypeError: $(...).fixFloat is not a functionapp.js:79:30 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #98 from Lari Taskula <lari.taskula(a)hypernova.fi> --- (In reply to Lisette Scheer from comment #62) > (In reply to Jonathan Druart from comment #51) > > Created attachment 99148 [details] [review] [review] > > Bug 15522: Add API for circulation rules > > > > Test plan: > > 1) Run t/db_dependent/api/v1/circ_rules.t . > > kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove > t/db_dependent/api/v1/circ_rules.t > t/db_dependent/api/v1/circ_rules.t .. 1/5 > # Failed test '403 Forbidden' > # at t/db_dependent/api/v1/circ_rules.t line 128. > # got: '400' > # expected: '403' > # Looks like you failed 1 test of 2. > t/db_dependent/api/v1/circ_rules.t .. 3/5 > # Failed test 'set_rules | unauthorized' > # at t/db_dependent/api/v1/circ_rules.t line 132. > > # Failed test '200 OK' > # at t/db_dependent/api/v1/circ_rules.t line 212. > # got: '403' > # expected: '200' > # Looks like you failed 1 test of 6. > > # Failed test 'set_rules | restricted' > # at t/db_dependent/api/v1/circ_rules.t line 223. > # Looks like you failed 2 tests of 5. > t/db_dependent/api/v1/circ_rules.t .. Dubious, test returned 2 (wstat 512, > 0x200) > Failed 2/5 subtests > > Test Summary Report > ------------------- > t/db_dependent/api/v1/circ_rules.t (Wstat: 512 Tests: 5 Failed: 2) > Failed tests: 3, 5 > Non-zero exit status: 2 > Files=1, Tests=5, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.86 cusr 0.23 > csys = 3.11 CPU) > Result: FAIL > > I got this message when I tried to do this step in my devbox. Everything > else worked great for me. I confirm this error. Will provide a patch to fix it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #97 from Lari Taskula <lari.taskula(a)hypernova.fi> --- (In reply to Lari Taskula from comment #87) > Created attachment 101919 [details] [review] > Bug 15522: Add JS build pipeline > > This is not directly testable, but can be either used through the > Makefile: > > $ make js-build > > (This will automatically install all dependencies.) > > Or by manually installing yarn: > > $ sudo apt install nodejs npm > $ sudo npm install -g yarn > $ yarn install > $ yarn build > > (There is also `make js-watch` and `yarn watch`, which automatically > recompile when files are changed.) > > JD note: the make rule does not work > > Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> I had issues with this on Ubuntu 18.04, especially the step "yarn build". koha@koha:~/Koha$ yarn build yarn run v1.22.4 $ node_modules/.bin/gulp build You are missing required Node modules; run `npm install`. I did some digging and found a more detailed message: ReferenceError: primordials is not defined It worked when I explicitly chose to install node version 10. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula <lari.taskula(a)hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula(a)hypernova.fi --- Comment #96 from Lari Taskula <lari.taskula(a)hypernova.fi> --- Fixed patch order, obsoleted duplicates, rebased on master. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula <lari.taskula(a)hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99215|0 |1 is obsolete| | --- Comment #95 from Lari Taskula <lari.taskula(a)hypernova.fi> --- Created attachment 101927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101927&action=e… Bug 15522: (follow-up) Handle deprecated rules Previous use of inArray was wrong. Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula <lari.taskula(a)hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99201|0 |1 is obsolete| | --- Comment #94 from Lari Taskula <lari.taskula(a)hypernova.fi> --- Created attachment 101926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101926&action=e… Bug 15522: Handle deprecated rules For upgraded installs. Also add a log in the console if it happens. Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula <lari.taskula(a)hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99202|0 |1 is obsolete| | --- Comment #93 from Lari Taskula <lari.taskula(a)hypernova.fi> --- Created attachment 101925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101925&action=e… Bug 15522: Replace the obsoleted fixFloat occurrence to use Sticky Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula <lari.taskula(a)hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99203|0 |1 is obsolete| | --- Comment #92 from Lari Taskula <lari.taskula(a)hypernova.fi> --- Created attachment 101924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101924&action=e… Bud 15522: Restore categories filtering Mimicking what is done for Branches Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula <lari.taskula(a)hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99204|0 |1 is obsolete| | --- Comment #91 from Lari Taskula <lari.taskula(a)hypernova.fi> --- Created attachment 101923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101923&action=e… Bug 15522: Fix permission name manage_circ_rules_from_any_libraries On 15520 followups have been provided to not use a negative permission. Note that two api tests are failing (get 400). I would like some help to investigate here why 400 is returned instead of 403. Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.

1 0