March 2020 - Koha-bugs - lists.koha-community.org

[Bug 13345] Choose the format when sending a basket/list by email
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100886|0 |1 is obsolete| | --- Comment #26 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 101998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101998&action=e… Bug 13345: Allow patrons to choose format on sending basket/list by email It is already possible to download a basket(cart) or a list using different format. But by email, only iso2709 is possible. This patch adds the ability to select a format for the file attached to the email when sending the basket/list content. Test plan: 1/ At the OPAC, add some records to your basket and send it by email using different formats (RIS, BibTeX, MARC and the CSV profiles defined). 2/ At the OPAC, add some records to a list and send it by email using the different formats. 3/ Redo step 1 at the intranet 4/ Redo step 2 at the intranet Note that subtitles are not displayed in all these cases. Note for QA: This patch refactors 3 main things: 1/ Template side: the dropdown list to select the format is now in an include file (indeed, this list is used in 4 templates, this will make easier further changes). The include files are named 'download-export-available-formats.inc', feel free to suggest something better. The are used in: [opac-]sendbasket.tt, [opac-]sendshelf.tt, [opac-]downloadbasket.tt and [opac-]downloadshelf.tt. 2/ Build records data and the records file This job was done in 4 scripts: - opac/opac-sendbasket.pl - opac/opac-sendshelf.pl - basket/sendbasket.pl - virtualshelves/sendshelf.pl Now it's done in C4::Biblio::BuildBiblioDataForExport and tests are provided in t/db_dependent/Biblio/BuildBiblioDataForExport.t Not that a similar job is done in [opac-]downloadcart.pl and [opac-]downloadshelf.pl 3/ Build the subject and body of the email sent Same as before, the job was done at the same places. Now it's done in Koha::Email->fill_body_for_sending (feel free to suggestion a better name) and tests are provided in t/Koha_Email.t Sponsored-by: Mines Paristech Signed-off-by: Nicole C. Engard <nengard(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23404] New: Circulation::TooMany error on itemtype when at biblio level
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23404 Bug ID: 23404 Summary: Circulation::TooMany error on itemtype when at biblio level Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Circulation::TooMany gets itemtype from $item var beeing a Koha::Item unblessed. When itemtype is at biblio level, calling $item->{'itemtype'} is wrong. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 23

[Bug 7902] Adding Function to Check for Existence of Tables
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7902 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24994 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24999 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24999 [Bug 24999] Date not correctly formatted in claims table -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24765 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765 [Bug 24765] Updated on date in Claims returned starts off as 12/31/1969 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13881] Add desk management
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #50 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Upgrade to 19.12.00.054 done [07:00:32]: Bug 13881 - Add desk management DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'A' at line 2 [for Statement " ALTER TABLE suggestions ADD CONSTRAINT `suggestions_ibfk_lastmodificationby` FOREIGN KEY (`lastmodificationby`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE A "] at installer/data/mysql/updatedatabase.pl line 21300. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #117 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Lari, the remote branch needs to be used to testing. The patches were not up-to-date on purpose, new rules have been added to the table, and need to be added to the interface, did you deal with them? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #116 from Lari Taskula <lari.taskula(a)hypernova.fi> --- Comment on attachment 101934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101934 Bug 15522: Add API for circulation rules Review of attachment 101934: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=155…) ----------------------------------------------------------------- ::: api/v1/swagger/paths/circulation-rules.json @@ +28,5 @@ > + "schema": { > + "$ref": "../definitions.json#/error" > + } > + } > + } No permissions required for GET? @@ +40,5 @@ > + ], > + "parameters": [{ > + "name": "body", > + "in": "body", > + "description": "A JSON object containing rules to set; null for a rule_value means to delete the rule", I think this wrong functionality for POST method that is supposed to create resources. Also, by definition POST is not idempotent, but here it seems to be. (If I understand the API correctly, here making the same request twice is the same as making it only once, right?) It should then be PUT. But PUT requires the whole object as a parameter. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula <lari.taskula(a)hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101946|0 |1 is obsolete| | --- Comment #115 from Lari Taskula <lari.taskula(a)hypernova.fi> --- Created attachment 101947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101947&action=e… Bug 15522: (follow-up) Fix 400 errors in circ_rules.t Commit "Bug 15522: Fix permission name manage_circ_rules_from_any_libraries" renames a permission by one that negates the previous. However the commit above incorrectly negates more than is supposed to. The test wants to check whether unauthorized and restricted user can store circulation rules. The libriarian is restricted (to their homebranch) when they are circ rules authorized (by "manage_circ_rules" permission) but do not have permission "manage_circ_rules_from_any_libraries". To test: 1. prove t/db_dependent/api/v1/circ_rules.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '20

27 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #114 from Lari Taskula <lari.taskula(a)hypernova.fi> --- Created attachment 101946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101946&action=e… Bug 15522: (follow-up) Fix 400 errors in circ_rules.t Commit "Bug 15522: Fix permission name manage_circ_rules_from_any_libraries" renames a permission by one that negates the previous. However the commit above incorrectly negates more than is supposed to. The test wants to check whether unauthorized and restricted user can store circulation rules. The libriarian is restricted (to their homebranch) when they are circ rules authorized (by "manage_circ_rules" permission) but do not have permission "manage_circ_rules_from_any_libraries". To test: 1. prove t/db_dependent/api/v1/circ_rules.t -- You are receiving this mail because: You are watching all bug changes.

1 0