April 2020 - Koha-bugs - lists.koha-community.org

[Bug 20101] New: Cronjob automatic_item_modification_by_age.pl does not log run in action logs
by bugzilla-daemon＠bugs.koha-community.org 14 May '20

14 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Bug ID: 20101 Summary: Cronjob automatic_item_modification_by_age.pl does not log run in action logs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz C4::Log::cronlogaction() was never implemented in automatic_item_modification_by_age.pl. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 29

[Bug 25007] New: Script to deal with Amazon images in detail.tt causes problem
by bugzilla-daemon＠bugs.koha-community.org 14 May '20

14 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 Bug ID: 25007 Summary: Script to deal with Amazon images in detail.tt causes problem Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com In detail.tt there is a verify_images() function. It checks to see if images from Amazon are 1px X 1px, if they are it removes the image but also updates the bootstrap class from col-xs-9 to col-xs-12. We build the Amazon cover images like this: <img src="https://images-na.ssl-images-amazon.com/images/P/[% normalized_isbn | html %].01.MZZZZZZZ.jpg" alt="" /> Any record without a ISBN ends up looking like this: https://images-na.ssl-images-amazon.com/images/P/.01.MZZZZZZZ.jpg Which turns out to be a 1px X 1px image. If you also have local images on it then forces the image down and into a weird place. TO RECREATE: -Have Amazon images turned on and local images too. -Have a record with a local cover image -Make sure the record has no ISBN in 020 field. -Load detail page of that record and see that the local cover images is not on the right hand side like it should be but forced underneath 'catalogue_detail_biblio' in an odd spot. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 42

[Bug 22468] New: Standardize on labeling ccode table columns as Collection
by bugzilla-daemon＠bugs.koha-community.org 14 May '20

14 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22468 Bug ID: 22468 Summary: Standardize on labeling ccode table columns as Collection Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 8775 Target Milestone: --- Currently the templates are split: Some label table columns with items.ccode as "Collection," some as "Collection code." Since we display the description rather than the code itself we should use "Collection" everywhere. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 [Bug 8775] Add collection code to lost report -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 25120] New: In system preference editor first tab is now Accounting and not Acquisitions
by bugzilla-daemon＠bugs.koha-community.org 14 May '20

14 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25120 Bug ID: 25120 Summary: In system preference editor first tab is now Accounting and not Acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org When going to the system preferences editor, on the left side the first tab used to be highlighted/preselected. This was Acquisitions, but is now Accounting. So we need to change things. -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 22734] New: Fund not marked as mandatory when ordering from a staged file
by bugzilla-daemon＠bugs.koha-community.org 14 May '20

14 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 Bug ID: 22734 Summary: Fund not marked as mandatory when ordering from a staged file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: severine.queune(a)bulac.fr QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Created attachment 88267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88267&action=ed… 'Fund' should be in red When adding a new order from a staged file, "Fund" label should be in red as it's a mandatory field. As you can see on attachment, not selecting a fund is correctly blocked. Should the word 'Required' be added at the right of the 2 fields 'Quantity' and 'Fund' to have the same display as we have adding an order directly in a basket ? -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 25040] New: Problematic current_timestamp syntax generated by DBIx::Class::Schema::Loader
by bugzilla-daemon＠bugs.koha-community.org 14 May '20

14 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25040 Bug ID: 25040 Summary: Problematic current_timestamp syntax generated by DBIx::Class::Schema::Loader Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Caught by the changes made to Koha::Object->store by bug 23463 (especially 9c383aa286fee5a29c6f084873f2eb6644bad64f) 154 elsif ( not defined $self->$col 155 && $columns_info->{$col}->{datetime_undef_if_invalid} ) 156 { 157 # timestamp 158 $self->_result()->set_column($col => $columns_info->{$col}->{default_value}); 159 } If a timestamp not null column does not have a value when store is called, the default value is set. The expected default value is \"current_timestamp"(`git grep current_timestamp Koha/Schema/Result`) but for some reasons DBIx::Class::Schema::Loader sometimes generates "current_timestamp()" (certainly depending on versions of DBIx::Class::Schema::Loader and DBMS MySQL vs MariaDB) It ends up with an error on insert/update: DBD::mysql::st execute failed: Incorrect datetime value: 'current_timestamp()' -- You are receiving this mail because: You are watching all bug changes.

1 35

[Bug 25053] New: PatronSelfRegistrationExpireTemporaryAccountsDelay system preference is unclear
by bugzilla-daemon＠bugs.koha-community.org 14 May '20

14 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25053 Bug ID: 25053 Summary: PatronSelfRegistrationExpireTemporaryAccountsDelay system preference is unclear Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com We've got two methods for automatically deleting self-reg patrons. The first deletes any patron who is still in the self-reg category more than X days past account creation. The second deletes any self-reg patron who has not verified their account via email with X days of account creation. The syspref PatronSelfRegistrationExpireTemporaryAccountsDelay deals with that first deletion method. It gets used in C4::Members::DeleteExpiredOpacRegistrations if the --del-exp-selfreg flag is set in cleanup_database.pl. This sub does not check whether or not the patron has verified via the verification email. As such, it's confusing that the syspref text says "Delete patrons registered via the OPAC, but not yet verified after X days." I suggest changing this wording to "Delete patrons still in the category indicated by PatronSelfRegistrationDefaultCategory X days after account creation." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11

[Bug 25008] New: Koha::RecordProcessor->options doesn't refresh the filters
by bugzilla-daemon＠bugs.koha-community.org 14 May '20

14 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008 Bug ID: 25008 Summary: Koha::RecordProcessor->options doesn't refresh the filters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org On testing something in opac-showmarc.pl I noticed it wasn't applying the ViewPolicy filter! And it seems the way the record processor is used is to blame. I plan to submit a fix for opac-showmarc.pl but thought it was worth filing a bug against Koha::RecordProcessor. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 34

[Bug 25038] New: OPAC reading history checkouts and on-site tabs not working
by bugzilla-daemon＠bugs.koha-community.org 13 May '20

13 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25038 Bug ID: 25038 Summary: OPAC reading history checkouts and on-site tabs not working Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: lari.taskula(a)hypernova.fi QA Contact: testopia(a)bugs.koha-community.org OPAC reading history table has three tabs for different checkout types: All, Checkouts, On-site checkouts. However, all of your checkouts are visible every tab regardless of checkout type. To reproduce: 1. Enable OnSiteCheckouts system preference 2. Perform two checkouts: one normal checkout, one on-site checkout 3. Go to OPAC /cgi-bin/koha/opac-readingrecord.pl 4. Observe your checkouts all are visible in every tab (All, Checkouts, On-site checkouts) -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 24966] New: Fix calls to maybe_add where method call does not return a value
by bugzilla-daemon＠bugs.koha-community.org 13 May '20

13 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24966 Bug ID: 24966 Summary: Fix calls to maybe_add where method call does not return a value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com For reasons unknown to me, a call like: -- $resp .= maybe_add( FID_CALL_NUMBER, $item->call_number, $server ); -- will not work as expected if the item has no callnumber. One would expect the parameters to the subroutine to be: 'CY', under, and a SIPServer object. What is actually received is: 'CY', and a SIPServer object. We ingest the parameters like so: -- sub maybe_add { my ($fid, $value, $server) = @_; -- So, what happens is $value is populated with the server object! This can cause bad output like this: -- OUTPUT MSG: '101YNN20200324 063701AOBPL|AB32503201584185|AQBPL|AJCat /|CK001|CRn|CSJ 636.8 CLU|CYC4::SIP::SIPServer=HASH(0x1ea0e58)|DAC4::SIP::SIPServer=HASH(0x1ea0e58)|'--- I do not know why this is happening, but there are a couple solutions: 1) Move the $server parameter to be the first parameter of the subroutine call 2) Check the value of $value and swap $value and $server if it is the server object. I will write a patch implementing the latter solution, as it is a two line change, versus a many line change for the former. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 33