April 2020 - Koha-bugs - lists.koha-community.org

[Bug 25176] New: Styling problem with checkout form
by bugzilla-daemon＠bugs.koha-community.org 14 May '20

14 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25176 Bug ID: 25176 Summary: Styling problem with checkout form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 22999 Created attachment 103145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103145&action=e… Screenshot of the problem Bug 22999 caused a styling problem with the checkout form. The barcode from and the message about the last checked-out item are no longer the same width. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 [Bug 22999] Switch two-column templates to Bootstrap grid: Circulation -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 24800] New: Koha does incomplete checkin when no return date is provided
by bugzilla-daemon＠bugs.koha-community.org 14 May '20

14 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24800 Bug ID: 24800 Summary: Koha does incomplete checkin when no return date is provided Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com, kyle(a)bywatersolutions.com, martin.renvoize(a)ptfs-europe.com We found that when a checkin is requested by the self check without a return date, Koha will check the item in, but fails to send a checkin response and crashes and create inconsistent/invalid data: - It will remove the issue from the patron account and move to old_issues. BUT: - the old_issues.returndate will be an invalid date: 0000-00-00 - there is no return recorded in action_logs - there is no reutrn recorded in statistics - The reading history will show an empty return date. We found this in the context of an 'cancel checkout' feature in a lot of libraries using hardware and software by one of the big international RFID providers. We identified several 100 of those over a period of 1.5 years. What happens? - Self check requests checkout - Koha responds that item was checked out - Self check tries to desensitize - Item has been removed from the self check already! - Self check requests checkin with cancel flag set to Y and return date empty - Koha doesn't respond, but dies This all happens within a second or less. >From the logs: Sip::MsgType::_initialize('Checkin', 'N20200303 151300 APXXXX|AOXXXX|ABb00000057|ACxxxxxx|BIY', 'CA18A18', '37', ...) Mar 3 15:13:00 xxxx xxxx[16798]: new ILS::Item('b00000057'): found with title 'Irrlicht und Feuer :' Mar 3 15:13:00 xxxx xxxx[16798]: raw_transport: shutting down Note the BIY in the Checkin request. In some older 3M documentation I found the following explanation about the cancel functionality: "Checkin, Message 09 Cancel (Y or N) This field is set to N when a normal checkin of materials is being requested. This field shoudl be set to Y when a previous Checkout message failed. It is possible for a checkout command to fail. This problem occurs when a patron removes the item from the 3M selfCheck system creadle after it has been checked out by the ACS software but before the item has been desensitized by the 3M selfCheck system. If this happens, the 3M SelfCheck system would cancel the Checkout by sending a Checkin message with the cancel field set to Y. The ACS software can also use this feld process the checkin differently (for example don't count it in the Checkin statistics and possibly decrement the Checkout statistics, also) ... Return date In current applications this field is not used." The last bit is strange as other documentation I found clearly list it as a required field in the Checking message: Some possible solutions: 1) Deny checkin, keep the item on the account. - We don't support cancel checkout. - The patron might have items on their account, that they have left in the library. 2) Check-in item and use server time for return date - The patron might leave with an item not checkout out, especially if the library has no gates. - We wil have entries of this happening in like a split second, which will help diagnose the problem. 3) Implement the cancel checkin - This would probably be the hardest to do - we'd need to set some kind of flag that it was a cancelled checkout to indicate that there might have been an issue on the self check machine (maybe 2) + note in the logs?) It would be interesting if someone can tell if they also had issues with this and what they think the best solution would be. Koha SIP2 crashing and making incomplete database entries doesn't appear the right behaviour atm. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 33

[Bug 25069] New: AddressFormat="fr" behavior is broken
by bugzilla-daemon＠bugs.koha-community.org 14 May '20

14 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25069 Bug ID: 25069 Summary: AddressFormat="fr" behavior is broken Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Patrons Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Depends on: 13618, 18110 Something went wrong during a rebase of bug 13618 commit dcd1f5d48c758aee17b6c6f069c6146b42efe117 Bug 13618: Add html filters to all the variables Several changes related to AddressFormat are wrong: - [% IF Koha.Preference( 'AddressFormat' ) %] - [% INCLUDE "member-main-address-style-${ Koha.Preference( 'AddressFormat' ) }.inc" %] - [% ELSE %] - [% INCLUDE 'member-main-address-style-us.inc' %] - [% END %] + [% SWITCH Koha.Preference( 'AddressFormat' ) %] + [% CASE 'de' %] + [% INCLUDE 'member-main-address-style-de.inc' %] + [% CASE # us %] + [% INCLUDE 'member-main-address-style-us.inc' %] + [% END %] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110 [Bug 18110] Adds FR to the syspref AddressFormat -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 20101] New: Cronjob automatic_item_modification_by_age.pl does not log run in action logs
by bugzilla-daemon＠bugs.koha-community.org 14 May '20

14 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Bug ID: 20101 Summary: Cronjob automatic_item_modification_by_age.pl does not log run in action logs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz C4::Log::cronlogaction() was never implemented in automatic_item_modification_by_age.pl. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 29

[Bug 25007] New: Script to deal with Amazon images in detail.tt causes problem
by bugzilla-daemon＠bugs.koha-community.org 14 May '20

14 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 Bug ID: 25007 Summary: Script to deal with Amazon images in detail.tt causes problem Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com In detail.tt there is a verify_images() function. It checks to see if images from Amazon are 1px X 1px, if they are it removes the image but also updates the bootstrap class from col-xs-9 to col-xs-12. We build the Amazon cover images like this: <img src="https://images-na.ssl-images-amazon.com/images/P/[% normalized_isbn | html %].01.MZZZZZZZ.jpg" alt="" /> Any record without a ISBN ends up looking like this: https://images-na.ssl-images-amazon.com/images/P/.01.MZZZZZZZ.jpg Which turns out to be a 1px X 1px image. If you also have local images on it then forces the image down and into a weird place. TO RECREATE: -Have Amazon images turned on and local images too. -Have a record with a local cover image -Make sure the record has no ISBN in 020 field. -Load detail page of that record and see that the local cover images is not on the right hand side like it should be but forced underneath 'catalogue_detail_biblio' in an odd spot. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 42

[Bug 22468] New: Standardize on labeling ccode table columns as Collection
by bugzilla-daemon＠bugs.koha-community.org 14 May '20

14 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22468 Bug ID: 22468 Summary: Standardize on labeling ccode table columns as Collection Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 8775 Target Milestone: --- Currently the templates are split: Some label table columns with items.ccode as "Collection," some as "Collection code." Since we display the description rather than the code itself we should use "Collection" everywhere. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 [Bug 8775] Add collection code to lost report -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 25120] New: In system preference editor first tab is now Accounting and not Acquisitions
by bugzilla-daemon＠bugs.koha-community.org 14 May '20

14 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25120 Bug ID: 25120 Summary: In system preference editor first tab is now Accounting and not Acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org When going to the system preferences editor, on the left side the first tab used to be highlighted/preselected. This was Acquisitions, but is now Accounting. So we need to change things. -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 22734] New: Fund not marked as mandatory when ordering from a staged file
by bugzilla-daemon＠bugs.koha-community.org 14 May '20

14 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 Bug ID: 22734 Summary: Fund not marked as mandatory when ordering from a staged file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: severine.queune(a)bulac.fr QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Created attachment 88267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88267&action=ed… 'Fund' should be in red When adding a new order from a staged file, "Fund" label should be in red as it's a mandatory field. As you can see on attachment, not selecting a fund is correctly blocked. Should the word 'Required' be added at the right of the 2 fields 'Quantity' and 'Fund' to have the same display as we have adding an order directly in a basket ? -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 25040] New: Problematic current_timestamp syntax generated by DBIx::Class::Schema::Loader
by bugzilla-daemon＠bugs.koha-community.org 14 May '20

14 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25040 Bug ID: 25040 Summary: Problematic current_timestamp syntax generated by DBIx::Class::Schema::Loader Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Caught by the changes made to Koha::Object->store by bug 23463 (especially 9c383aa286fee5a29c6f084873f2eb6644bad64f) 154 elsif ( not defined $self->$col 155 && $columns_info->{$col}->{datetime_undef_if_invalid} ) 156 { 157 # timestamp 158 $self->_result()->set_column($col => $columns_info->{$col}->{default_value}); 159 } If a timestamp not null column does not have a value when store is called, the default value is set. The expected default value is \"current_timestamp"(`git grep current_timestamp Koha/Schema/Result`) but for some reasons DBIx::Class::Schema::Loader sometimes generates "current_timestamp()" (certainly depending on versions of DBIx::Class::Schema::Loader and DBMS MySQL vs MariaDB) It ends up with an error on insert/update: DBD::mysql::st execute failed: Incorrect datetime value: 'current_timestamp()' -- You are receiving this mail because: You are watching all bug changes.

1 35

[Bug 25053] New: PatronSelfRegistrationExpireTemporaryAccountsDelay system preference is unclear
by bugzilla-daemon＠bugs.koha-community.org 13 May '20

13 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25053 Bug ID: 25053 Summary: PatronSelfRegistrationExpireTemporaryAccountsDelay system preference is unclear Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com We've got two methods for automatically deleting self-reg patrons. The first deletes any patron who is still in the self-reg category more than X days past account creation. The second deletes any self-reg patron who has not verified their account via email with X days of account creation. The syspref PatronSelfRegistrationExpireTemporaryAccountsDelay deals with that first deletion method. It gets used in C4::Members::DeleteExpiredOpacRegistrations if the --del-exp-selfreg flag is set in cleanup_database.pl. This sub does not check whether or not the patron has verified via the verification email. As such, it's confusing that the syspref text says "Delete patrons registered via the OPAC, but not yet verified after X days." I suggest changing this wording to "Delete patrons still in the category indicated by PatronSelfRegistrationDefaultCategory X days after account creation." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11