April 2020 - Koha-bugs - lists.koha-community.org

[Bug 24487] build_query_params helper builds path parameter with matching criteria
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24487 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98166|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 103144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103144&action=e… Bug 24487: Add 2 more tests And make sure tests pass if there is no patron with borrowernumber=10 in DB. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Ammended test description Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24487] build_query_params helper builds path parameter with matching criteria
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24487 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98165|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 103143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103143&action=e… Bug 24487: Don't apply matching criteria to path parameters This patch separates query parameters from path parameters, and uses exact matching for the later. To test: 1. Apply this patch 2. prove t/Koha/REST/Plugin/Query.t t/db_dependent/Koha/REST/Plugin/Objects.t SUCCESS => tests ok 3. Sign off Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24487] build_query_params helper builds path parameter with matching criteria
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24487 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103105|0 |1 is obsolete| | Attachment #103106|0 |1 is obsolete| | Attachment #103107|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 103142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103142&action=e… Bug 24487: Regresion test This patch introduces a regresion test where a path parameter is combined with 'contains' match criteria To test: 1. apply this patch 2. prove t/db_dependent/Koha/REST/Plugin/Objects.t Test should fail at this point. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt(a)gmail.com |jonathan.druart(a)bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518 --- Comment #5 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 103130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103130&action=e… Bug 13518: Delete patron's modifications along with the patron The table borrower_modifications has no FK constraint on the borrowernumber and will remain untouched when the patron is deleted. If the borrowernumber doesn't exist in the database, the modification entry is no longer visible in Koha. The problem is that this table is used for the borrower modifications and the self-registration features. So far borrowernumber is the PK (int(11) NOT NULL DEFAULT '0'), for the self-registration feature we can have borrowernumber that is not defined (0 is used) Ideally we would like to have borrowernumber a DEFAULT NULL, and use NULL for self-reg, but then we will loose the PK (PK cannot be NULL). As we cannot keep the correct constraints at DB level anyway, we will need to handle consistency at code-level. Test plan: Create a new patron Do some modification at the OPAC Delete the patron Confirm that the modifications as been removed (directly in DB) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #65 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Victor Grousset/tuxayo from comment #64) > > => delete of item from B4 is *not* blocked - there is a hold but it is not found > > I don't get it. No sign of something not being found. > > I have this: https://pic.infini.fr/RLxIM2cL/eYdtLmXE.png (temporary hosting > for 90 days) So it's not blocked, which is expected. > > 4/ Repeat 1 > > => The deletion has been effective! > > Is that the expected result? > > https://pic.infini.fr/WaQVV1Gg/rTGE1oG3.png (temporary hosting for 90 days) "Has been effective", so you should be on the next screen, not the confirmation screen. > I guess that's not an issue. But I still have a item I can't delete. If the reason makes sense, yes it's expected. That's the point of the patchset. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 25000] New: SQL report not updated
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25000 Bug ID: 25000 Summary: SQL report not updated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: kohadevinim(a)devinim.com.tr QA Contact: testopia(a)bugs.koha-community.org Database is not updated when sql reports was edited -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11

[Bug 24872] New: Set languages system preferences after web install
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24872 Bug ID: 24872 Summary: Set languages system preferences after web install Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: bgkriegel(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com After doing a web install, in a language other than English, it is necessary to explicitly activate the 'language' and 'opaclanguages' system preferences using the intranet in English! We could set those preferences using the install language. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 10561] DisplayOPACiconsXSLT and DisplayIconsXSLT descriptions should be clearer
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10561 David Roberts <david.roberts(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |david.roberts(a)ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.

1 0