April 2020 - Koha-bugs - lists.koha-community.org

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101405|0 |1 is obsolete| | --- Comment #68 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 103148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103148&action=e… Bug 8132: Adding a new message 'last_item_for_hold' blocking item deletion If an item is the last one of a biblio that have biblio-level hold placed on it, we should block the deletion. It takes effect if the hold is found (W or T), to follow existing behavior for item-level holds. If we want to block deletion for any holds we should deal with it on a separate bug report. Test plan: 0/ Setup Create Biblio B1 with 1 item Create Biblio B2 with 2 items Create Biblio B3 with 1+ item Create Biblio B4 with 1+ item Create Biblio B5 with 1+ item Place a biblio-level hold on B1 and B2 Place an item-level hold on B3 and B4 Confirm the item-level hold for the items of B3 to mark it waiting. 1/ Delete those 6 items in a batch => delete of item from B1 is blocked on first screen - only 1 item left and there is a biblio-level hold on the record => delete of items from B2 is *not* blocked on first screen - One of them will block the deletion, but so far we are not aware of that situation => delete of item from B3 is blocked on first screen - there is a waiting item-level hold placed on the item => delete of item from B4 is *not* blocked - there is a hold but it is not found => delete of item from B5 is *not* - there is no reason to block its deletion Note that you can only select items from B2, B4 and B5 2/ Select them and confirm the deletion => Nothing happened and you get a message saying that one of the 2 items from B2 is blocking the whole deletion process 3/ Remove the biblio-level hold 4/ Repeat 1 => The deletion has been effective! => Note that there is something a bit weird as we are blocking items from a biblio that has biblio-level holds on it (not found), but we do not blocking the deletion of an item with a waiting item-level hold Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101404|0 |1 is obsolete| | --- Comment #67 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 103147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103147&action=e… Bug 8132: No changes but disable checkboxes When the list of items is displayed we already know if there will be a problem during the deletion. So let's disable the checkbox to tell the user in advance that items cannot be deleted. Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #61 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #60) > (In reply to Kyle M Hall from comment #55) > > Also modifies the log4perl.conf to lazy-open filehandles to log files, > > so the same config can be used with log-files needing different > > permissions. > > Kyle, why do you need those changes? > Isn't the SIP server running with the same user as Koha? That particular code was written by Olli. If you think it should be removed please feel free to do so! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 25175] New: Don't die on broken plugins
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25175 Bug ID: 25175 Summary: Don't die on broken plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #66 from Victor Grousset/tuxayo <victor(a)tuxayo.net> --- > "Has been effective", so you should be on the next screen, not the confirmation screen. Okay, indeed after confirmation the deletion works. >> I guess that's not an issue. But I still have a item I can't delete. > If the reason makes sense, yes it's expected. That's the point of the patchset. Indeed, the item-level hold is the cause. >From what I understand, no issue found, so I will sign it off. Later in the day I think. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24487] build_query_params helper builds path parameter with matching criteria
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24487 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103144|Bug 24487: Add 2 more tests |[19.11.x] Bug 24487: Add 2 description| |more tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24487] build_query_params helper builds path parameter with matching criteria
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24487 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103143|Bug 24487: Don't apply |[19.11.x] Bug 24487: Don't description|matching criteria to path |apply matching criteria to |parameters |path parameters -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24487] build_query_params helper builds path parameter with matching criteria
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24487 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103142|Bug 24487: Regresion test |[19.11.x] Bug 24487: description| |Regresion test -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24487] build_query_params helper builds path parameter with matching criteria
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24487 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98165|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24487] build_query_params helper builds path parameter with matching criteria
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24487 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com Attachment #98166|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0