April 2020 - Koha-bugs - lists.koha-community.org

[Bug 24487] build_query_params helper builds path parameter with matching criteria
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24487 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103143|Bug 24487: Don't apply |[19.11.x] Bug 24487: Don't description|matching criteria to path |apply matching criteria to |parameters |path parameters -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24487] build_query_params helper builds path parameter with matching criteria
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24487 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103142|Bug 24487: Regresion test |[19.11.x] Bug 24487: description| |Regresion test -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24487] build_query_params helper builds path parameter with matching criteria
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24487 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98165|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24487] build_query_params helper builds path parameter with matching criteria
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24487 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com Attachment #98166|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24487] build_query_params helper builds path parameter with matching criteria
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24487 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98166|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 103144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103144&action=e… Bug 24487: Add 2 more tests And make sure tests pass if there is no patron with borrowernumber=10 in DB. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Ammended test description Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24487] build_query_params helper builds path parameter with matching criteria
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24487 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98165|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 103143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103143&action=e… Bug 24487: Don't apply matching criteria to path parameters This patch separates query parameters from path parameters, and uses exact matching for the later. To test: 1. Apply this patch 2. prove t/Koha/REST/Plugin/Query.t t/db_dependent/Koha/REST/Plugin/Objects.t SUCCESS => tests ok 3. Sign off Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24487] build_query_params helper builds path parameter with matching criteria
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24487 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103105|0 |1 is obsolete| | Attachment #103106|0 |1 is obsolete| | Attachment #103107|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 103142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103142&action=e… Bug 24487: Regresion test This patch introduces a regresion test where a path parameter is combined with 'contains' match criteria To test: 1. apply this patch 2. prove t/db_dependent/Koha/REST/Plugin/Objects.t Test should fail at this point. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt(a)gmail.com |jonathan.druart(a)bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518 --- Comment #5 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 103130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103130&action=e… Bug 13518: Delete patron's modifications along with the patron The table borrower_modifications has no FK constraint on the borrowernumber and will remain untouched when the patron is deleted. If the borrowernumber doesn't exist in the database, the modification entry is no longer visible in Koha. The problem is that this table is used for the borrower modifications and the self-registration features. So far borrowernumber is the PK (int(11) NOT NULL DEFAULT '0'), for the self-registration feature we can have borrowernumber that is not defined (0 is used) Ideally we would like to have borrowernumber a DEFAULT NULL, and use NULL for self-reg, but then we will loose the PK (PK cannot be NULL). As we cannot keep the correct constraints at DB level anyway, we will need to handle consistency at code-level. Test plan: Create a new patron Do some modification at the OPAC Delete the patron Confirm that the modifications as been removed (directly in DB) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0