April 2020 - Koha-bugs - lists.koha-community.org

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102200|0 |1 is obsolete| | --- Comment #158 from David Nind <david(a)davidnind.com> --- Created attachment 102318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102318&action=e… Bug 4461: Better error handling Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102198|0 |1 is obsolete| | --- Comment #157 from David Nind <david(a)davidnind.com> --- Created attachment 102317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102317&action=e… Bug 4461: Simplify recipients code As the feature is now turned off without KohaAdminEmailAddress, we only need to check if the email address of the library if defined. Not that we should not check for $library->branchreplyto or ReplytoDefault, but only $library->branchemail, as we do everywhere else (I think) Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102196|0 |1 is obsolete| | --- Comment #156 from David Nind <david(a)davidnind.com> --- Created attachment 102316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102316&action=e… Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102195|0 |1 is obsolete| | --- Comment #155 from David Nind <david(a)davidnind.com> --- Created attachment 102315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102315&action=e… Bug 4461: Use our local_referer instead of HTTP_REFERER Cannot remember why exactly, but it seems that we should not use HTTP_REFERER directly. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102194|0 |1 is obsolete| | --- Comment #154 from David Nind <david(a)davidnind.com> --- Created attachment 102314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102314&action=e… Bug 4461: Use KohaAdminEmailAddress pref as 'from' We usually do not specify the from_address on enqueuing the notice, but when sending it (from _send_message_by_email). That way a) the code is centralized (as we must use $patron->notice_email_address) and b) the email used is the one that is in the DB when the letter is effectively sent. Here I guess you need to give it when the notice is enqueued as you want to default to the koha admin address. I do not think it's a good idea, we should not send an email with "from" if not really sent by the user. We have the borrowernumber anyway to know who filled the form. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102193|0 |1 is obsolete| | --- Comment #153 from David Nind <david(a)davidnind.com> --- Created attachment 102313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102313&action=e… Bug 4461: Rename report date with created_on And make it a timestamp type column Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102192|0 |1 is obsolete| | --- Comment #152 from David Nind <david(a)davidnind.com> --- Created attachment 102312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102312&action=e… Bug 4461: (follow-up) Creating sample notice and other fixes - filters - capitalisation - atomic update Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102191|0 |1 is obsolete| | --- Comment #151 from David Nind <david(a)davidnind.com> --- Created attachment 102311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102311&action=e… Bug 4461: (follow-up) Redirect to 404 if OPACProblemReport not enabled Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102190|0 |1 is obsolete| | --- Comment #150 from David Nind <david(a)davidnind.com> --- Created attachment 102310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102310&action=e… Bug 4461: Submit a problem report To test: 1) Apply patch, update database, rebuild schema file 2) Restart koha-common and memcached 3) Confirm that your user has an email address. 4) Confirm that your library does NOT have an email address. 5) Confirm that syspref KohaAdminEmailAddress and syspref ReplytoDefault are not filled. Enable the OPACReportProblem syspref. 6) Log into OPAC 7) Click the 'Report a problem' link at the bottom of whatever page you're on 8) Notice that there is no form is and there is an error message alerting that reports cannot be submitted 9) Add an email address for your library (in either the email field or the replyto field). Refresh the OPAC problem report page. The form should now show, and the recipient field should say 'library'. 10) Complete the form and submit. Check the message_queue in the database and confirm the to_address is correct. Confirm there is a success message. 11) Add an email address for the syspref KohaAdminEmailAddress and refresh the OPAC problem report page again. The recipient field should now be a dropdown. Select the Koha Administrator option. 12) Complete the form and submit. Check the message_queue in the database and confirm the to_address is the value in KohaAdminEmailAddress. Confirm there is a success message. 13) Ensure all details in the message_queue are correct. 14) Log out of the OPAC 15) Click the Report a problem link again and confirm you are forced to log in Sponsored-by: Catalyst IT Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102189|0 |1 is obsolete| | --- Comment #149 from David Nind <david(a)davidnind.com> --- Created attachment 102309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102309&action=e… Bug 4461: Problem Report Koha objects Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0